From patchwork Thu Jun 27 00:41:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13713579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 801A1C41513 for ; Thu, 27 Jun 2024 00:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=lHmTyeEPTdKV0aIjYD3j9FbsHg cm81SHsxloAIBK8XoPKmAxE1j1ZIVNJqDjHM7n8h542HTv9wRxmyF6yel35K7ObzBJhBzBUqY/cBe mTcCUZEaI7RF6sX17oOQpPWymPqib7arh/7sTeHNj4uzjp19h2zB/c5pBh9akVhhpchsbZB248ZZX Ir5BGQFajAPiEGIfePqrDvGGaxhjHU7r/de53J5MpWcSiPSyEWf0kx+LO0pBOhaNM1MxEliY1jtjL JxRMTXYxUtvm8y10Hf7s5/nveLItmmK1AWPfZlHnoeuUA7VeRh6dsL/ky+Z+w2jgOtIsVtgIJHXKF F6HtAbng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMdDe-00000008l8j-1EZa; Thu, 27 Jun 2024 00:42:34 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMdDS-00000008l4y-2Anl for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 00:42:24 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-52ce01403f6so4685613e87.0 for ; Wed, 26 Jun 2024 17:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719448941; x=1720053741; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=kRMNeuSBNNJX498nRRr7wTzSZW1bk99Rq+jJLVGOM9mRcH5eqPXVQsAHiIsvm6wnxA B3S4r6sUz9wbuMSsH2jJCEjtq3Rnhd6gStODjdliLTVlngT94xCpWa6uh0ZF2ljvaUGG vgtTdZqrAZETOq2QEYqC9FLI6ddCbQXfllvcQRQY2qQuac7joHSbwRmOb3zu9UPU9VPO ctkzmrq8IOyYuSHoQf/gnDG6Mqonffkg9UpdK2A8STTiaXhojJSWdCAf2V47sqm+/zk3 +SWxGEafkhpnkpJYwCYh007ONXKdegAthltmk07zm4NgDNB/KOQgBiEaA4f6v9pDc6T5 jwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719448941; x=1720053741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=BdNiQ9sJtIXkZBK4rdLJEiGsUTHx3plY2kYV+V06rn8xvs7m753gvjok+W4mX4M3zd NM7Essz+/ZI/umEgGF0cvmRNzv/NhlFwobUPzpb3tsQjOqy/9moWaUO7irXedi/MivVw 4mBepGBHhTeU72hSlLJzNkD0UJ2wF5veR/4waLMiEqn8AczLJpXp0j6pICQsydWZts6+ Awq50JeY1+bG53cQQCi6i1TD2vmFtJpFegJ9tElmWHbI2HhgdeuNaKOaONE1qoiex0JH GQoEmArgJVhovKRX2aQ39B/Ij+Z6A9K1TqfZyA9eiIJxGCDAzbbdIk4WspmiEs21QfUU jZWQ== X-Forwarded-Encrypted: i=1; AJvYcCVJOUwVbl7ui7vnTZfUV8m9uq1Zz/3eLc+3hatuZMtOP+Pgkq5pWeagpkqzYMPkuNFbINHOcJAtWWiDbSzi3wA5W0JG8PsVKtAGX6oMbbouL3PBY50= X-Gm-Message-State: AOJu0YzeWBQpuHqacrPk2J9NzkMCtaD5k15fN6ul5Xaiu4GWXAN4xuFI 157iV59yezgcicbMsY9ffSIfnmcUzRJ7+D8I8fq11gS5I7HqcMXF X-Google-Smtp-Source: AGHT+IHkActpZTtjsuzyiNyp+unFcBPGmpORKiX6h3v1xsvn9qGifn4FXEoGGX308UY64dnWHiAHzA== X-Received: by 2002:ac2:46ee:0:b0:52c:dc25:d706 with SMTP id 2adb3069b0e04-52ce185ec9emr6605174e87.52.1719448940728; Wed, 26 Jun 2024 17:42:20 -0700 (PDT) Received: from localhost ([89.113.147.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e7131ec55sm18792e87.231.2024.06.26.17.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 17:42:20 -0700 (PDT) From: Serge Semin To: Andrew Lunn , Heiner Kallweit , Russell King , Alexandre Torgue , Jose Abreu , Jose Abreu , Vladimir Oltean , Florian Fainelli , Maxime Chevallier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Serge Semin , Sagar Cheluvegowda , Abhishek Chauhan , Andrew Halaney , Jiawen Wu , Mengyuan Lou , Tomer Maimon , openbmc@lists.ozlabs.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next v3 10/10] net: stmmac: Add DW XPCS specified via "pcs-handle" support Date: Thu, 27 Jun 2024 03:41:30 +0300 Message-ID: <20240627004142.8106-11-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627004142.8106-1-fancer.lancer@gmail.com> References: <20240627004142.8106-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_174223_219976_18F76C0A X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Recently the DW XPCS DT-bindings have been introduced and the DW XPCS driver has been altered to support the DW XPCS registered as a platform device. In order to have the DW XPCS DT-device accessed from the STMMAC driver let's alter the STMMAC PCS-setup procedure to support the "pcs-handle" property containing the phandle reference to the DW XPCS device DT-node. The respective fwnode will be then passed to the xpcs_create_fwnode() function which in its turn will create the DW XPCS descriptor utilized in the main driver for the PCS-related setups. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index 74de6ec00bbf..03f90676b3ad 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -497,15 +497,22 @@ int stmmac_mdio_reset(struct mii_bus *bus) int stmmac_pcs_setup(struct net_device *ndev) { + struct fwnode_handle *devnode, *pcsnode; struct dw_xpcs *xpcs = NULL; struct stmmac_priv *priv; int addr, mode, ret; priv = netdev_priv(ndev); mode = priv->plat->phy_interface; + devnode = priv->plat->port_node; if (priv->plat->pcs_init) { ret = priv->plat->pcs_init(priv); + } else if (fwnode_property_present(devnode, "pcs-handle")) { + pcsnode = fwnode_find_reference(devnode, "pcs-handle", 0); + xpcs = xpcs_create_fwnode(pcsnode, mode); + fwnode_handle_put(pcsnode); + ret = PTR_ERR_OR_ZERO(xpcs); } else if (priv->plat->mdio_bus_data && priv->plat->mdio_bus_data->pcs_mask) { addr = ffs(priv->plat->mdio_bus_data->pcs_mask) - 1; @@ -515,10 +522,8 @@ int stmmac_pcs_setup(struct net_device *ndev) return 0; } - if (ret) { - dev_warn(priv->device, "No xPCS found\n"); - return ret; - } + if (ret) + return dev_err_probe(priv->device, ret, "No xPCS found\n"); priv->hw->xpcs = xpcs;