| Message ID | 20240627075856.2314804-5-leith@bade.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix up pin definitions for BPI-R3 board | expand |
Il 27/06/24 09:58, Leith Bade ha scritto: > The current definition of the uart1_pins pin group does not include the > CTS and RTS pins that are available on header CON1. > > In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A", > revision "V1.1", sheet 4), the UART1_RTS and UART1_CTS pins are connected > via nets to the connector CON1 (sheet 14) UART0-RTS and UART0-CTS pins. > The datasheet does not show these nets as connected to anything else. > > These pins can be configured for either UART1 or as a GPIO, with no other > alternate usage listed in the pinctrl driver. By changing the pin group > definition from uart1_rx_tx to uart1 the additional RTS and CTS pins are > included. > > Signed-off-by: Leith Bade <leith@bade.nz> Fixes tag please, after which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index 54087001cc8c..48bd1e04963c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -349,7 +349,7 @@ mux { uart1_pins: uart1-pins { mux { function = "uart"; - groups = "uart1_rx_tx"; + groups = "uart1"; }; };
The current definition of the uart1_pins pin group does not include the CTS and RTS pins that are available on header CON1. In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A", revision "V1.1", sheet 4), the UART1_RTS and UART1_CTS pins are connected via nets to the connector CON1 (sheet 14) UART0-RTS and UART0-CTS pins. The datasheet does not show these nets as connected to anything else. These pins can be configured for either UART1 or as a GPIO, with no other alternate usage listed in the pinctrl driver. By changing the pin group definition from uart1_rx_tx to uart1 the additional RTS and CTS pins are included. Signed-off-by: Leith Bade <leith@bade.nz> --- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)