From patchwork Fri Jun 28 22:35:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13716706 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 904A3C2BD09 for ; Fri, 28 Jun 2024 22:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bK4GVLftRcx1G43I5RNC1VZ+kMnAGIqU8rAyC3MW8BY=; b=y+RnUvsmdZZDnz9D+OKqNC4+0/ QWxee+PU1yYDm98p0XBGFGQtOpFClg5WCIuUnf6NDGNHmj/66/ALnHVF/mISpnNSN6l5+T6O3wRS1 hzcF6m2uccnKTJ5AwJUC2Xml8iNg+LgwbIJwAcZbq59k8rDQjzjIP7CqMumggthFSk67+HOZNeA8e wqNnrS7SeMMZqlFDhYJGtTD3aRNuHTcLRh1t2eu22YJdiefZ+xNhkvKzCABoZvrV0v9Vtk5cEI8s6 Ag+SyqMXy1VzGgxCYvyacYg8qIsPK7BALYJ/bsveR2wW82HZQbB5dfiytSYYojXVbT0mG2teUfO2r WD/dgGWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNKC7-0000000FCDo-2tgF; Fri, 28 Jun 2024 22:35:52 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNKBY-0000000FBwc-44r5 for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 22:35:18 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4256eec963eso7591985e9.1 for ; Fri, 28 Jun 2024 15:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719614115; x=1720218915; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bK4GVLftRcx1G43I5RNC1VZ+kMnAGIqU8rAyC3MW8BY=; b=qMpBAe2e37h/rfYPI6TpL0dWDSxsm0IAU5+lBLWotU7yzMMXemJhKXart46PoNj4nf Pfy9k4VKs95NBUj3hePnkmQ9MgJUee5YKaTON5cu2jNf7CexKMLKA1Z7fk7SN8wCqYF8 8o+Zzv6SLfVe5QYn0pFGZ7dzq4ffFLtKpy2ep7i03gZ7Avt3Lajeoda2i497nVkWGjnC 2nw4nRW9mfBiBDNXfjTXzmuxfioPKkIUtIrOumZZ7xi8L7l8l4ghLY4SyGdSqCMSWenY kbTUBdRA+z9HKLbBhQXMDUITm2ZHDlHR1CFlCEkbXrAtxdfTG+jWvX5cJrMiy45O6F5S E+4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719614115; x=1720218915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bK4GVLftRcx1G43I5RNC1VZ+kMnAGIqU8rAyC3MW8BY=; b=QUMs+hjyfhrFsRCU8+JpsM0ZJS7ciVEUBDQmC/LLmq5Q4lh2CmZONLrAR4kA+Z/JzV ypQapML1ofj2tll1aW3tjJCz1ZcViXbUgqADXxxQ2rm35djZNaTvG5ibAegK6fGsVDKi VSJuSgjRiovN/zCQT5oxmpQCmNHfyg8FGEWtd7WLB2LwXSNMKDJwCAwTaidAJKmpcqZs HR9AEay66bAOvK9cg7TWA4tITkigvObZUG7rHcXGC/8DlQgb0u/19BjgEAVW/92UDpPC XWqqkw7jgzg/jlCtceA9hs7m1LGzFr2cbrpn8PJCsjVZXOwXAmbFZ5p+4hWKdiPsPxFN 52sQ== X-Gm-Message-State: AOJu0YwX5vcNnzzGo74aj42flzgK0P38yVF+r0IaNNW4/IKIS0uw2qmv tFzOjJ9tnDpyntOg03RdjY+juzKiY1umeO4LN27Zw4SsdIPQdgLBlvV9At+Bd7Q= X-Google-Smtp-Source: AGHT+IGAx/+hg7U8vXysG5fFaJ+7znqTB7jHT7deRrgK6fDUyfus/N4BjGymdOMvzYq/K9V9/QTmyA== X-Received: by 2002:a05:600c:6b16:b0:424:a3d7:2a89 with SMTP id 5b1f17b1804b1-424a3d72b27mr80778525e9.4.1719614115166; Fri, 28 Jun 2024 15:35:15 -0700 (PDT) Received: from gpeter-l.lan ([2a0d:3344:2e8:8510::3aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a043a16sm3496711f8f.0.2024.06.28.15.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 15:35:14 -0700 (PDT) From: Peter Griffin To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Peter Griffin Subject: [PATCH v2 3/3] clk: samsung: gs101: mark gout_hsi2_ufs_embd_i_clk_unipro as critical Date: Fri, 28 Jun 2024 23:35:06 +0100 Message-ID: <20240628223506.1237523-5-peter.griffin@linaro.org> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog In-Reply-To: <20240628223506.1237523-1-peter.griffin@linaro.org> References: <20240628223506.1237523-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_153517_034339_4FAC18FA X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The system hangs on poweroff when this UFS clock is turned off, meaning the system never powers down. For the moment mark the clock as critical. Reviewed-by: Will McVicker Tested-by: Will McVicker Signed-off-by: Peter Griffin --- drivers/clk/samsung/clk-gs101.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index ba9570f7a5fa..85098c61c15e 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2846,7 +2846,7 @@ static const struct samsung_gate_clock hsi2_gate_clks[] __initconst = { GATE(CLK_GOUT_HSI2_UFS_EMBD_I_CLK_UNIPRO, "gout_hsi2_ufs_embd_i_clk_unipro", "mout_hsi2_ufs_embd_user", CLK_CON_GAT_GOUT_BLK_HSI2_UID_UFS_EMBD_IPCLKPORT_I_CLK_UNIPRO, - 21, 0, 0), + 21, CLK_IS_CRITICAL, 0), GATE(CLK_GOUT_HSI2_UFS_EMBD_I_FMP_CLK, "gout_hsi2_ufs_embd_i_fmp_clk", "mout_hsi2_bus_user", CLK_CON_GAT_GOUT_BLK_HSI2_UID_UFS_EMBD_IPCLKPORT_I_FMP_CLK,