From patchwork Tue Jul 2 11:42:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13719492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41CF5C3064D for ; Tue, 2 Jul 2024 11:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g5GizAVgyxmL8de/Ai1ppF7kgqOMshmJUC8PNXOrpgk=; b=WUz88QIQ6qj1L0tSaxxdSW7Igc DIfst9km32tRy6lCLycSKiXcYFUvXLgJl2/MBuUg9iC/zlI8SblHWska6w3BlrMwCQi/YI5ssj102 J4g57Te0IztgQex5ZWPcOXwjeIgG/yUigykjaZM27EwNv349kbpjud2lKzphywPejaBJDMvUnv+uC CqGmncIjJu/L+kwn4QWtpSeITezmzfAMNQv22aXuHpKOmcDRcxuYVmM1xeV53XUqd6lntF4KF3Zu5 CqWcP+TQZHfBrKLlW/qPsbWTTTx3QBsiFyje+YLrc8cjIAgkinyU+yo3aB6cG2kB6H0sEu8shrjTr K6BqkuWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sObx7-00000006XLy-3ve7; Tue, 02 Jul 2024 11:45:41 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sObvG-00000006WFU-2pOb for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 11:43:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E286ACE1DCD; Tue, 2 Jul 2024 11:43:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67DB9C116B1; Tue, 2 Jul 2024 11:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719920624; bh=xfdwBm73zrsE8jJbz66cyUfza8+3mTMfHMR1ZtugqdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UbV6+XVW1/C6mscSmcfkb9HU+yrEU/sVRAZeEd8bjDHT8ekegj489M7oA+VyyoSji LRRHrtvyN4yvG3ZFs+AtjSYZrp4bmClo5J/KILh8Yt2OOSxFPtG0XA8qd435S9GWNJ CedbDKTQoJhcVdEic31KRViOmG6VynsKFOdJD5XwcIpERvXT1SjbO1P8VvMd/2AGyY eVW0qzrsS99YeNhbcCiKN6QBMQvMMIAMmtB9CIbUQ0LCPVs956esVHndBB6fGPTxZ2 cCTcZMROHdg/QJWfGC+7WAkKevwXLZhYLL3cZR3OwWzw9ih8df7QpzqlW0cVbhfH3v Bk8s7mqY5YULA== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH v2 14/30] irqchip/armada-370-xp: Simplify ipi_resume() code Date: Tue, 2 Jul 2024 13:42:46 +0200 Message-ID: <20240702114302.22475-15-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240702114302.22475-1-kabel@kernel.org> References: <20240702114302.22475-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_044346_927456_4E68B565 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactor the ipi_resume() function to drop one indentation level. Signed-off-by: Marek Behún --- drivers/irqchip/irq-armada-370-xp.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index c007610413fe..316c27c97951 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -462,16 +462,14 @@ static const struct irq_domain_ops ipi_domain_ops = { static void ipi_resume(void) { for (int i = 0; i < IPI_DOORBELL_END; i++) { - unsigned int virq; + unsigned int virq = irq_find_mapping(ipi_domain, i); + struct irq_data *d; - virq = irq_find_mapping(ipi_domain, i); - if (!virq) + if (!virq || !irq_percpu_is_enabled(virq)) continue; - if (irq_percpu_is_enabled(virq)) { - struct irq_data *d; - d = irq_domain_get_irq_data(ipi_domain, virq); - armada_370_xp_ipi_unmask(d); - } + + d = irq_domain_get_irq_data(ipi_domain, virq); + armada_370_xp_ipi_unmask(d); } }