From patchwork Thu Jul 4 17:28:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13724126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C35C30653 for ; Thu, 4 Jul 2024 17:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZReY5oQp5q5JDnQkU4OgYtMQicBtBNzGvNRsdVnSk/U=; b=uZfKQCItnaL9W9qKrKhZuhMn4u leSmobuHueih2WVzm1ljJew6LrZzVxY0dt2hbsZqO+q/lybhArEGucy5SIcGO5NzRQt6f8lEvj3Pj uynznPuNJbHdYJ6TgT2nrKBLkIEbFYCi4fBibkGpLHr46VRfd42V89ncvgYw5I2PxzTmEfnj1kBFP gag8LSGrOrTqCJqdp7H82n/KhgcD34rPHJIRe3DQHZI0Gg4hyzaJTauxWyWxIUxeJe2g2p3vy6qxp eOSgZIMAX529ngNb0sz98Oar2yQtuOF4q8KZc21FWifE20EAnLaOEoBRxJq1ZARgdjLIBZoxsDRRK 3VFLmgJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPQGx-0000000E18u-1iCn; Thu, 04 Jul 2024 17:29:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPQGE-0000000E0r1-2jCM for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 17:28:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B7E4A6283A; Thu, 4 Jul 2024 17:28:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54163C4AF0A; Thu, 4 Jul 2024 17:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720114125; bh=hZLMZ8MyT6kMtoPFEmNPK6rAznf1lF+TnbSpYE4U9Gw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=czq7fVvfpw8zZ9PDpBBuOELWM23B9djKCrim22XAI5fmUIN8QOucWyYZe3144UcOk /Kk5oa+UvNcHYK/24TZZjwKpkkOMwmG6/ugf+Oyq+goVadm2v9Vs70Its8M9d6t07Q t/KyuJ49x5qKjggMfrelShf+DEQ3LNf3nAp2OLjVQCKZmdiDhjsyICOzYYPL2i3YZ+ oY60zGybNcrgw3502h0+WOZ1iD3FxBV49x8+9ZjdHnnGPs8uYZf1geyoaGbxgI1uxE OgO/EzxTTCPJweyQqe8TKF6tj80KsuwjzaJNwkbsEAKnPN8ezdmANRWdw9RVmYVabJ g/nhuZmJiAJog== From: Mark Brown Date: Thu, 04 Jul 2024 18:28:16 +0100 Subject: [PATCH v4 1/4] arm64/fpsimd: Introduce __bit_to_vl() helper MIME-Version: 1.0 Message-Id: <20240704-kvm-arm64-fix-pkvm-sve-vl-v4-1-b6898ab23dc4@kernel.org> References: <20240704-kvm-arm64-fix-pkvm-sve-vl-v4-0-b6898ab23dc4@kernel.org> In-Reply-To: <20240704-kvm-arm64-fix-pkvm-sve-vl-v4-0-b6898ab23dc4@kernel.org> To: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Mark Brown X-Mailer: b4 0.14-dev-d4707 X-Developer-Signature: v=1; a=openpgp-sha256; l=3064; i=broonie@kernel.org; h=from:subject:message-id; bh=hZLMZ8MyT6kMtoPFEmNPK6rAznf1lF+TnbSpYE4U9Gw=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBmhtvFK7ynTjDA3VBW5+3nCTmmSgV+pDygMv8Pa5of tovF3L2JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZobbxQAKCRAk1otyXVSH0NjzB/ 9wAyCRckkz1EF1KyO3aLbh6rTu90S/RI2qugJgleo/PlnfJsFd0CP4Jhk6M1hPpm6EyqjwD47VRihf 1dvghkKGzVEbbk9UNzGROESbYg5fq8g8V+CZZnF5CCI9iSpdwHRnkERVuzwWVG7T35vlRf2fKrJ5ru xGRteEn1YU9i4c2txqKYLHuwV2KmOSXcan0h3hfV5N3SThCpBzJ6X5/Wy7AiYAtTeRZzy6Wycxobxj zf/5/zXZ/82T/8W0WC4IWJ6rmolkkDK/39Zz6pfvc8KdYYzPCrwyT4luLwp9PU5TqOG2z/firzEwFR 0s8nhJ/IZhIdnIqp4SStA7Qj0TcTWG X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_102846_936922_C8D43A5D X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In all cases where we use the existing __bit_to_vq() helper we immediately convert the result into a VL. Provide and use __bit_to_vl() doing this directly. Acked-by: Catalin Marinas Signed-off-by: Mark Brown --- arch/arm64/include/asm/fpsimd.h | 4 ++++ arch/arm64/kernel/fpsimd.c | 12 ++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/arm64/include/asm/fpsimd.h b/arch/arm64/include/asm/fpsimd.h index bc69ac368d73..51c21265b4fa 100644 --- a/arch/arm64/include/asm/fpsimd.h +++ b/arch/arm64/include/asm/fpsimd.h @@ -172,6 +172,10 @@ static inline unsigned int __bit_to_vq(unsigned int bit) return SVE_VQ_MAX - bit; } +static inline unsigned int __bit_to_vl(unsigned int bit) +{ + return sve_vl_from_vq(__bit_to_vq(bit)); +} struct vl_info { enum vec_type type; diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 82e8a6017382..22542fb81812 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -530,7 +530,7 @@ static unsigned int find_supported_vector_length(enum vec_type type, bit = find_next_bit(info->vq_map, SVE_VQ_MAX, __vq_to_bit(sve_vq_from_vl(vl))); - return sve_vl_from_vq(__bit_to_vq(bit)); + return __bit_to_vl(bit); } #if defined(CONFIG_ARM64_SVE) && defined(CONFIG_SYSCTL) @@ -1103,7 +1103,7 @@ int vec_verify_vq_map(enum vec_type type) * Mismatches above sve_max_virtualisable_vl are fine, since * no guest is allowed to configure ZCR_EL2.LEN to exceed this: */ - if (sve_vl_from_vq(__bit_to_vq(b)) <= info->max_virtualisable_vl) { + if (__bit_to_vl(b) <= info->max_virtualisable_vl) { pr_warn("%s: cpu%d: Unsupported vector length(s) present\n", info->name, smp_processor_id()); return -EINVAL; @@ -1169,7 +1169,7 @@ void __init sve_setup(void) set_bit(__vq_to_bit(SVE_VQ_MIN), info->vq_map); max_bit = find_first_bit(info->vq_map, SVE_VQ_MAX); - info->max_vl = sve_vl_from_vq(__bit_to_vq(max_bit)); + info->max_vl = __bit_to_vl(max_bit); /* * For the default VL, pick the maximum supported value <= 64. @@ -1188,7 +1188,7 @@ void __init sve_setup(void) /* No virtualisable VLs? This is architecturally forbidden. */ info->max_virtualisable_vl = SVE_VQ_MIN; else /* b + 1 < SVE_VQ_MAX */ - info->max_virtualisable_vl = sve_vl_from_vq(__bit_to_vq(b + 1)); + info->max_virtualisable_vl = __bit_to_vl(b + 1); if (info->max_virtualisable_vl > info->max_vl) info->max_virtualisable_vl = info->max_vl; @@ -1305,10 +1305,10 @@ void __init sme_setup(void) WARN_ON(bitmap_empty(info->vq_map, SVE_VQ_MAX)); min_bit = find_last_bit(info->vq_map, SVE_VQ_MAX); - info->min_vl = sve_vl_from_vq(__bit_to_vq(min_bit)); + info->min_vl = __bit_to_vl(min_bit); max_bit = find_first_bit(info->vq_map, SVE_VQ_MAX); - info->max_vl = sve_vl_from_vq(__bit_to_vq(max_bit)); + info->max_vl = __bit_to_vl(max_bit); WARN_ON(info->min_vl > info->max_vl);