| Message ID | 20240704151411.69558-4-andrei.simion@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Update the eeprom nodename following device tree specification | expand |
On 04/07/2024 17:14, Andrei Simion wrote: > Align the eeprom nodename according to device tree specification > and at24.yaml. > > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> Squash. > --- > arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts > index bffd61397cb5..18943b873fff 100644 > --- a/arch/arm/boot/dts/microchip/sama5d34ek.dts > +++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts > @@ -36,7 +36,7 @@ i2c0: i2c@f0014000 { > i2c1: i2c@f0018000 { > status = "okay"; > > - 24c256@50 { > + eeprom@50 { What about other names? Why not fixing everything at once? Best regards, Krzysztof
On 05.07.2024 09:43, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 04/07/2024 17:14, Andrei Simion wrote: >> Align the eeprom nodename according to device tree specification >> and at24.yaml. >> >> Signed-off-by: Andrei Simion <andrei.simion@microchip.com> > > Squash. > I will squash. >> --- >> arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts >> index bffd61397cb5..18943b873fff 100644 >> --- a/arch/arm/boot/dts/microchip/sama5d34ek.dts >> +++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts >> @@ -36,7 +36,7 @@ i2c0: i2c@f0014000 { >> i2c1: i2c@f0018000 { >> status = "okay"; >> >> - 24c256@50 { >> + eeprom@50 { > > What about other names? Why not fixing everything at once? > There are 149 dts+dtsi files. I would like to fix them step by step. (lots to check) > Best regards, > Krzysztof > Best regards, Andrei Simion
On 05/07/2024 11:31, Andrei.Simion@microchip.com wrote: > On 05.07.2024 09:43, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 04/07/2024 17:14, Andrei Simion wrote: >>> Align the eeprom nodename according to device tree specification >>> and at24.yaml. >>> >>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com> >> >> Squash. >> > > I will squash. > >>> --- >>> arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts >>> index bffd61397cb5..18943b873fff 100644 >>> --- a/arch/arm/boot/dts/microchip/sama5d34ek.dts >>> +++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts >>> @@ -36,7 +36,7 @@ i2c0: i2c@f0014000 { >>> i2c1: i2c@f0018000 { >>> status = "okay"; >>> >>> - 24c256@50 { >>> + eeprom@50 { >> >> What about other names? Why not fixing everything at once? >> > > There are 149 dts+dtsi files. I would like to fix them step by step. (lots to check) I meant, if doing cosmetic changes like this to these files, why not fixing other names? Some of the work is automatic. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts index bffd61397cb5..18943b873fff 100644 --- a/arch/arm/boot/dts/microchip/sama5d34ek.dts +++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts @@ -36,7 +36,7 @@ i2c0: i2c@f0014000 { i2c1: i2c@f0018000 { status = "okay"; - 24c256@50 { + eeprom@50 { compatible = "atmel,24c256"; reg = <0x50>; pagesize = <64>;
Align the eeprom nodename according to device tree specification and at24.yaml. Signed-off-by: Andrei Simion <andrei.simion@microchip.com> --- arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)