From patchwork Fri Jul 5 10:40:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13724932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3E23C30658 for ; Fri, 5 Jul 2024 10:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z9Np41486ZPQDGlzQweAJezAFo0bzffLP3y8AkeihYA=; b=JLXDd4RGvsZ5SK4TscxfiP1tDt 9AGMz1VT3c/Q4mF1FK7258AaWbWBPaV1KQQlcIRan4c9ukMn/269TeWt+HbQ12VoPxJIC8awMBs5I ikketXDvb0KKqQjl1Dh+Ll2NwdZPc+SYak2XiNiC+ZZJfbEh51DOJk8AcPWNhCJe5VUuktzMNFWte GJaps1G/HDRasilYykdZUp78Y1ksErlRVYs13hg/voFXUfNa+twzHNWiqXNeHPpVzmhHgPyJfligj hI34xu50v66Osqgh2LdR2VfDVp58oXUZLqdEiCmusGZ+V+nW03e0exkt3V1bjach5M4k62H1DaBtw V4FgO7Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgOR-0000000FgEz-009P; Fri, 05 Jul 2024 10:42:19 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgNE-0000000Ffla-3yFr for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 10:41:06 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-36799fb93baso1012944f8f.0 for ; Fri, 05 Jul 2024 03:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720176063; x=1720780863; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z9Np41486ZPQDGlzQweAJezAFo0bzffLP3y8AkeihYA=; b=bj7LFZdK/lCVLPcc9UHLBsZC6BjTf21T5slqwwQ0/KQ7W9l6cxBKEvDs4/Kg1IAueT zYj/THxcUQw2qe91pyEhboQswfQyN7Z+qruVwnqz9AizX59XxmkML5xD9O9oZamm4XcC cwb9w0sq3YbBkpGVcNmoMonhUTdEk4P9EUXMM2mj0lo4/wiEHQIBmjjuU8Y99ob1gOfU GLd9a2aIpgZc5C7eCVjaAWOtX8MTOrJsBvb50mc/r1H9c8JEji4aXiOq5tOfsS3mn0oD KfjBVRIOzqUobz0zIpYS/c9rldlifTXkOEvTS/++oKA4BG1arJC0IIFr2XHHWYiF+93V Bx6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720176063; x=1720780863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z9Np41486ZPQDGlzQweAJezAFo0bzffLP3y8AkeihYA=; b=SmK25Xd8mQ4Xt+gtNu349Wo4EWQmB+qAQaMWT4uNuvQNtjOo6A6dKhMJgE/U1g+opo sNGpphrv/PSno2XR7hZU7Cq+P2W522FBx8ka5sFWwH8tCo/EqTUuNf3QsJAlb1j0PFNm OJUbEFmu1gOeTNqLkjwXwnIkepoI4T7jj4QQAQrASR+hnTBYowbHkuuSvSO/kkINHKpk WvifbX8xY/Dt6yBzfTR3hmjSVR3hY/Tn5hN0Aysn3FbTiEZCd1G5F+OgzAew/R/Qkl2O LJ4WBzvfxSCps1k5Uni8uS1AFH3Sx1FZxho5/HnokgWkizpnzRf3AfQ4Pv9n2JDaclLo c0pg== X-Forwarded-Encrypted: i=1; AJvYcCXFlrei/heqVbLGq2DFTwg+eTVc5EGoAGGLo2piMaPKxx3Afj5CA1fQK/cQNUDXg2qQdjy8312TaygqEdOvCMN4k7JE+bVU80QqvCKVUmgjL557MhI= X-Gm-Message-State: AOJu0YyXP1aWZtdsLKKu7Z9eEulCbQLr/cVDONcJ/z7Id0UCL317Yzk3 WkzdwWRQTA37cW/p2Yde2HPl2AYyclYLdHD+GhH4unbR8nxXSWEpfwGIIvk+VhE= X-Google-Smtp-Source: AGHT+IGJmF2yz6CclwNaZobfkh+KzmhezsSI6pZ1+CVEOHBJkhN00D9Q5QVyJPreYMVR2oHvYBqtxQ== X-Received: by 2002:a5d:6849:0:b0:367:9614:fb99 with SMTP id ffacd0b85a97d-3679dd31137mr2795078f8f.10.1720176063285; Fri, 05 Jul 2024 03:41:03 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36789d5ec1csm8680446f8f.37.2024.07.05.03.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 03:41:02 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 05 Jul 2024 12:40:49 +0200 Subject: [PATCH 6/6] iio: adc: ad5755: drop redundant devm_kfree() MIME-Version: 1.0 Message-Id: <20240705-cleanup-h-iio-v1-6-77114c7e84c5@linaro.org> References: <20240705-cleanup-h-iio-v1-0-77114c7e84c5@linaro.org> In-Reply-To: <20240705-cleanup-h-iio-v1-0-77114c7e84c5@linaro.org> To: Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Oleksij Rempel , kernel@pengutronix.de Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=661; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=wAVpbgQ5bIpyCcGTaGFP8RLhuVeOqnrOwZ6oTfnW4nw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmh82yqE4WDfmxPDBzauwZ3Iq6vku5GtvtWvYVd MK7kTqYSIKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZofNsgAKCRDBN2bmhouD 1+4WD/0QMoTcaJIkRnw0sl/FKPn/9xu4+bNaTVtxm3Oxvxf02oev5VhaxB/RJzKUopuc9Cv9TPc t5V+qudWwmVC3/6vIMZGISLvYkNkpTBIg7SZs74tbZ//7NGVeYfC8s4ev8SJ9r5X3TvMgihmu32 JDEMyQ0+klT275tvSKA+cYiaBmUDRGolzvO+uLc/ZMTdTrBOvajCSrjP1LNCSNVaCX7uc4gvXQ0 I6VGNMb1glQMD+CqNQQ2/7wHcctG/vqmmMneeln6lYioC3njEV2NVJ7txWExIB3w4NhMQWyIswZ QzPh1o70THWr0Hv7KhbeC6o3777jFBthV8k66WA9cybDPF6SuNwzyFOAIhyuFrBv8q+NxhVeTDr +MUCHc90reVhXMlmtSxpU5I0apW01OHOThkXoKs6GE6/10879YqP4xAcpZYW1hIH52q4dsxmSzh 2J0fts9TPugTQvZO1IU4U4i/1Sk8N/WbyjCzbCuNgjsRXigEtrDALzXboSrFCr4LEijx8y/t8OQ EeYHwqDY8qrVPGVsRCTIg2XARx/A/0pC5G5CEB7vHDQ2IKCDSQ0Bs1f6bSgGXhNI6x5QFVg8Z94 zbF2g56BKULxngx2n4TgUEXShv3yzJR5xRh8rRncc0BIluerLglDleXmovbT3iCGLf4g/nWp/kE gfF4RCMThWVj7tQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_034105_022342_3B560C45 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver calls ad5755_parse_fw() only from probe() function, so devm_kfree() during error path is not necessary and only makes code weirder. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Nuno Sa --- drivers/iio/dac/ad5755.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index 0b24cb19ac9d..bfbfc3c1b6a5 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -803,7 +803,6 @@ static struct ad5755_platform_data *ad5755_parse_fw(struct device *dev) error_out: fwnode_handle_put(pp); - devm_kfree(dev, pdata); return NULL; }