From patchwork Fri Jul 5 09:31:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 13724668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F5EAC30658 for ; Fri, 5 Jul 2024 09:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4cG80Tu/R6ba96dbyZQmaA30Cjd0d/7IQnLNMOP8lhw=; b=na39ggicaNegSn548UKA0fzHRr t0Qa6bIMEL79tCuqxQXzmqzBlEIcMoa9imX09cQ8pTFe35XBmgT5+M+/z4ZdWIHw6He8QOgeKcd4E VjaK8DxtfAHDRzvE/g4tUbMgkL+0FF28m6fiBpVkA+UGBvk7ETen0HtjYS9wb8N8vd+pPEgTKSR3L ApOJiHCYgGTGg7ysx8iayNZmLTFlT1k8BQSNSY0AHiqyttYgh/9mBRz6I45JiHfMHvQIFU/8bOIgb S3YePKRmeMM2mYW3YTDWSNXOzXQakeoRaZe2bN7NnjpE+hQ92dLsTSv30NCVO2z7xdzPnxbz86fwF Y6CUOyjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPfIe-0000000FS3t-2n4i; Fri, 05 Jul 2024 09:32:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPfIQ-0000000FRyg-1hwq for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 09:32:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5546562AE4; Fri, 5 Jul 2024 09:32:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A5DCC32781; Fri, 5 Jul 2024 09:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720171921; bh=nzaJSHHvHLH4tw2NS88X2blB90LpkIyqdRotWeSvNdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l1x7D6TbGvzN0orBc1T5rVFA9zBXP6ySBl1DRMs7OBq2jTKIh0HogJS+qy1CWoK3v xTF52gz5KHoVCuVE8tdni+gUbp8I5nmK86yaUe4dDDPtTfkDHSdidv0iy8xRw4sKPO /LCG/9aQb8iD623oAja57AtHxuKPhi6PUZbda6WNo+GmQyTo8MFu1pUs3tHNLvTZM4 CAkrqJRTnbYPl9oQv3EVtM36SyhFvz7SbNAjr/J5SEfnTCqwZZF7G76j/MFwk7PSvf GDilttOWS7Dft3HUfLPLjxh6LyyGiY5CiP6+ek/xv75zUtVnYfNLmXZoRQ3rbtbxz7 BeCz/wkr9ojBA== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sPfIM-00A0NK-PY; Fri, 05 Jul 2024 10:31:58 +0100 From: Marc Zyngier To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Nianyao Tang Subject: [PATCH 1/3] irqchip/gic-v4: Always configure affinity on VPE activation Date: Fri, 5 Jul 2024 10:31:53 +0100 Message-Id: <20240705093155.871070-2-maz@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705093155.871070-1-maz@kernel.org> References: <20240705093155.871070-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, tangnianyao@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_023202_551376_2F05FD85 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We currently have two paths to set the initial affinity of a VPE: - at activation time on GICv4 without the stupid VMOVP list, and on GICv4.1 - at map time for GICv4 with VMOVP list The latter location may end-up modifying the affinity of VPE that is currently running, making the results unpredictible. Instead, unify the two paths, making sure we only set the initial affinity at activation time. Reported-by: Nianyao Tang Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 3c755d5dad6e6..a00c5e8c4ea65 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -1809,13 +1809,9 @@ static void its_map_vm(struct its_node *its, struct its_vm *vm) for (i = 0; i < vm->nr_vpes; i++) { struct its_vpe *vpe = vm->vpes[i]; - struct irq_data *d = irq_get_irq_data(vpe->irq); - /* Map the VPE to the first possible CPU */ - vpe->col_idx = cpumask_first(cpu_online_mask); its_send_vmapp(its, vpe, true); its_send_vinvall(its, vpe); - irq_data_update_effective_affinity(d, cpumask_of(vpe->col_idx)); } } @@ -4562,6 +4558,10 @@ static int its_vpe_irq_domain_activate(struct irq_domain *domain, struct its_vpe *vpe = irq_data_get_irq_chip_data(d); struct its_node *its; + /* Map the VPE to the first possible CPU */ + vpe->col_idx = cpumask_first(cpu_online_mask); + irq_data_update_effective_affinity(d, cpumask_of(vpe->col_idx)); + /* * If we use the list map, we issue VMAPP on demand... Unless * we're on a GICv4.1 and we eagerly map the VPE on all ITSs @@ -4570,9 +4570,6 @@ static int its_vpe_irq_domain_activate(struct irq_domain *domain, if (!gic_requires_eager_mapping()) return 0; - /* Map the VPE to the first possible CPU */ - vpe->col_idx = cpumask_first(cpu_online_mask); - list_for_each_entry(its, &its_nodes, entry) { if (!is_v4(its)) continue; @@ -4581,8 +4578,6 @@ static int its_vpe_irq_domain_activate(struct irq_domain *domain, its_send_vinvall(its, vpe); } - irq_data_update_effective_affinity(d, cpumask_of(vpe->col_idx)); - return 0; }