| Message ID | 20240708133348.3592667-3-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: Use generic interface to simplify crashkernel reservation | expand |
On Mon, Jul 8, 2024 at 3:29 PM Jinjie Ruan <ruanjinjie@huawei.com> wrote: > On QEMU vexpress-a9 with 1GB memory, the crash kernel "crashkernel=4G" > is ok as below: > Reserving 4096MB of memory at 2432MB for crashkernel (System RAM: 1024MB) > > The above info is confusing, because the System memory is as below: > # cat /proc/iomem | grep Sys > 60000000-9fffffff : System RAM > > The cause is that the crash_size is parsed and printed with "unsigned long > long" data type which is 8 bytes but used with "phys_addr_t" which is > 4 bytes in memblock_phys_alloc_range(). Is that the whole explanation? > /* invalid value specified or crashkernel=0 */ > + crash_size = (phys_addr_t)crash_size; > if (ret || !crash_size) > return; How did crash_size get assigned before you added this oneliner? Yours, Linus Walleij
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index e6a857bf0ce6..59e1a13b5cf6 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -1012,6 +1012,7 @@ static void __init reserve_crashkernel(void) &crash_size, &crash_base, NULL, NULL); /* invalid value specified or crashkernel=0 */ + crash_size = (phys_addr_t)crash_size; if (ret || !crash_size) return;
On QEMU vexpress-a9 with 1GB memory, the crash kernel "crashkernel=4G" is ok as below: Reserving 4096MB of memory at 2432MB for crashkernel (System RAM: 1024MB) The above info is confusing, because the System memory is as below: # cat /proc/iomem | grep Sys 60000000-9fffffff : System RAM The cause is that the crash_size is parsed and printed with "unsigned long long" data type which is 8 bytes but used with "phys_addr_t" which is 4 bytes in memblock_phys_alloc_range(). Fixes: 9d17f3372306 ("ARM: 9190/1: kdump: add invalid input check for 'crashkernel=0'") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- arch/arm/kernel/setup.c | 1 + 1 file changed, 1 insertion(+)