| Message ID | 20240716-a38x-utmi-phy-v2-1-dae3a9c6ca3e@solid-run.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy: mvebu-cp110-utmi: add support for armada-380 utmi phys | expand |
On Tue, 16 Jul 2024 22:52:37 +0200, Josua Mayer wrote: > Armada 38x USB-2.0 PHYs are similar to Armada 8K (CP110) and can be > supported by the same driver with small differences. > > Add new compatible string for armada-38x variant of utmi phy. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.example.dtb: utmi@580000: reg: [[5767168, 8192]] is too short from schema $id: http://devicetree.org/schemas/phy/marvell,armada-cp110-utmi-phy.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240716-a38x-utmi-phy-v2-1-dae3a9c6ca3e@solid-run.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml index 9ce7b4c6d208..b90bda10b779 100644 --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml @@ -25,10 +25,21 @@ description: properties: compatible: - const: marvell,cp110-utmi-phy + enum: + - marvell,a38x-utmi-phy + - marvell,cp110-utmi-phy reg: - maxItems: 1 + items: + - description: UTMI registers + - description: USB config register + - description: UTMI config registers + + reg-names: + items: + - const: utmi + - const: usb-cfg + - const: utmi-cfg "#address-cells": const: 1
Armada 38x USB-2.0 PHYs are similar to Armada 8K (CP110) and can be supported by the same driver with small differences. Add new compatible string for armada-38x variant of utmi phy. Signed-off-by: Josua Mayer <josua@solid-run.com> --- .../bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)