From patchwork Sun Jul 21 16:28:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 13738047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB0DBC3DA61 for ; Sun, 21 Jul 2024 17:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=iBPqu3IeGZ2ShEb3T0YKA0yecc aMkIUkpIq17TMr35S7OAetaLUuZV2QPQEiotIg8KgK9/bDCZqjUnCQI55nRlQE6yZrxsX/DRx7C7B ZLzRzxUZtkNMItt1rG74Mds0vMA5h8p4gWj+hcKM9MMcXFnDjBso64nVK8macXdoCRVi1LrYU9Qrm w49bOzd7LVRX0YpB5LhWz2cmJPKfJWaEnvUsuyDu7kRandgsb4PC9K4zSMQ9CNxoQfXysvjElZ6gK dV9teW/6bpbSr3kNul1GAPIshDMy1reXVj9uOr1TXQPmuNAGrABT/1iJbic4qDtKP+Ya8hFCvS1bZ XDgRyT7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa4s-00000007CZX-2eCj; Sun, 21 Jul 2024 17:10:30 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa3q-00000007CCd-1oqK for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 17:09:28 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-8063553b837so150908639f.1 for ; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581765; x=1722186565; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=P+j66gp5IGqTveAlA5V9heFtlRw0ipmen20Huz4ITTz4iTeE/ZJaydEHDw+obJkaUs 5yeOxXCPSoxEe+QtXOPC0Fnx2jD44zAeDxqY+ZfYn32vPg2imnZM2XBPNE5u0xMJg4zy bL1c7ol9oV5BTqizfWXHDi2x5XoNkIvwR6mSkcNY6yvY7ip7bqPhEvYKh8lT9m7PEYXH jCEZtpOfCKrJOwvBPl0KmNiQfc1qH7V3pT9t1yED6FhGoN8Y/w158lOEDoEOW6Lc/JRU 3fZIPasgSridGRp3S5fUnFxoSTPkTD7qyiQcCRcG5V16xqPWxar6gjK/liMVD8MrR5ng g0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581765; x=1722186565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=w9GrbMTf7iWUMph6vk5+hb3/0chJXjZ8Ys+Q83L4V7DGOsUrijCuQyFzbGamHFUlsu rwyM0wbvAHpW6KMBv0IgkSgxfneWMQHnoTYu0EkKTgf7sQ5aBQY91QpSN2Vo9GG/hFF5 0xsF/iVqRHl8dXq3ltTYNSuhKAQE+M7DfyrMFkmO9DoLoPQf48X6k1c539vNMQTyZrLS xFn0GaOzlRAABmHQ4C41mH4lAK9mtXlczR3MLWmfdix9kd61OQT+Lr+V3sZ5TxN53U2t 5vqCoBEE1lS7DaN410loCAXSau5ME/OpMALa7YklcJ10nTrQRIM7PwzIUPwRcdEGJMof M8Hg== X-Forwarded-Encrypted: i=1; AJvYcCWksabqPVQY/f+tYEvp/U+1R+yUw/wxzuDRX59tdv2ZzERfb10NyTVql/DiNoKkGd2u0CdBKBjpcF2zV9CKUPX7mKk4u59T6tcfRtleebByCfbsCoM= X-Gm-Message-State: AOJu0YzxQdZjk40jj3hYODFCg9/o3ZnHU3b4U17Y05PFPMoPq0upU1eS HSYDhzGlHpnCLUhlrgtM44ffOF7k6Qgamyyd01Hu9RcGPEQtAkht X-Google-Smtp-Source: AGHT+IHTUuDmrSkpDNTCs+DM7fkQIf/sYoD1C3wpPlVfiRwZYjxYuCgZLbQbZW5lfAz3EpEk6s1CMw== X-Received: by 2002:a05:6602:6422:b0:806:31ee:13b with SMTP id ca18e2360f4ac-81aa538d525mr787891739f.4.1721581765062; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:24 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames Date: Sun, 21 Jul 2024 21:58:36 +0530 Message-ID: <20240721170840.15569-4-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_100926_495630_8383E5D0 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow for validation with the corresponding dtschema and gives errors $ make CHECK_DTBS=y DT_SCHEMA_FILES=ti,davinci-wdt.yaml \ ti/keystone/keystone-k2g-ice.dtb DTC_CHK arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb: wdt@02250000: $nodename:0: 'wdt@02250000' does not match '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$' from schema $id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# Therefore change "wdt@" to "watchdog@". While at it, remove "ti,davinci-wdt" compatible from the keystone dts code. Signed-off-by: Kousik Sanagavarapu --- Question: Should "wdt@" be changed everywhere in the dts code or is it only a requirement of validation against dtschema? Also, I'm not sure about removing "ti,davinci-wdt" from the keystone dts code. I'm thinking it is only there so that the driver code can get information from keystone nodes too, because it seems that there is no code for ti,keystone-wdt. So question, - Is WDT Controller driver for keystone not written yet? Or - Does the WDT Controller driver for keystone have the same functionality as one on davinci - hence leading us to simply do .compatible = "ti,keystone-wdt" ? arch/arm/boot/dts/ti/davinci/da850.dtsi | 2 +- arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi | 4 ++-- arch/arm/boot/dts/ti/keystone/keystone.dtsi | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/ti/davinci/da850.dtsi b/arch/arm/boot/dts/ti/davinci/da850.dtsi index 1d3fb5397ce3..89055ab87256 100644 --- a/arch/arm/boot/dts/ti/davinci/da850.dtsi +++ b/arch/arm/boot/dts/ti/davinci/da850.dtsi @@ -525,7 +525,7 @@ clocksource: timer@20000 { interrupt-names = "tint12", "tint34"; clocks = <&pll0_auxclk>; }; - wdt: wdt@21000 { + wdt: watchdog@21000 { compatible = "ti,davinci-wdt"; reg = <0x21000 0x1000>; clocks = <&pll0_auxclk>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi index dafe485dfe19..884402a5fe4a 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi @@ -610,8 +610,8 @@ spi3: spi@21806000 { clocks = <&k2g_clks 0x0013 0>; }; - wdt: wdt@02250000 { - compatible = "ti,keystone-wdt", "ti,davinci-wdt"; + wdt: watchdog@02250000 { + compatible = "ti,keystone-wdt"; reg = <0x02250000 0x80>; power-domains = <&k2g_pds 0x22>; clocks = <&k2g_clks 0x22 0>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone.dtsi b/arch/arm/boot/dts/ti/keystone/keystone.dtsi index ff16428860a9..f697f27edcfc 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone.dtsi @@ -225,8 +225,8 @@ usb0: usb@2690000 { }; }; - wdt: wdt@22f0080 { - compatible = "ti,keystone-wdt","ti,davinci-wdt"; + wdt: watchdog@22f0080 { + compatible = "ti,keystone-wdt"; reg = <0x022f0080 0x80>; clocks = <&clkwdtimer0>; };