From patchwork Fri Jul 26 21:56:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13743203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA0DEC3DA4A for ; Fri, 26 Jul 2024 21:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8nZLWCmhXrmYUcbWpC3fz65qVeODiDrBacSCpc6CkS0=; b=mKqrdXlLPjeifsVzlxA5T3Zrzb Dn/RsyYtY/NXIMTVnJAdzNBHoGQKvVhEUEyWDN9MPDM0YRi1wWSpKUHNjOM1K3nQuJnw9qXeEbTCQ U6Vung6jXSiDgR+DBFXgMXkuZVCbXqACnotIHqCeILexYKegX+V0jaaob/ho/pTwEODRDEaOLqg9x Zwy5AhY0RE33X13K38Q0LUOQC3eojQCoJt3BS0NnVy5bX9mq74f3PBTZSy297LSZ+/eo36C+5he84 v3+mV9Ggz3lgB1aVyobQzrXEzdEJUGqwluDEahqr5BNY5HOy29QsLE+RTAhhmmSAKbtjnlNqYzTmG 6+hHY1JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXSws-000000057nk-3Wrq; Fri, 26 Jul 2024 21:58:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXSwG-000000057SM-11cB for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 21:57:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9211B6199F; Fri, 26 Jul 2024 21:57:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD7DC32782; Fri, 26 Jul 2024 21:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722031043; bh=KUPM3WCD3VyrnlEzvVZNfdnolRYrDWJJnT+Gw+3b/Oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N7xB+7B/CH4lSoIo1HiT1+qTw9+wJAq2aSmIP4N16GSjzvi0SjpcTz5sP6DpJW1wX 0R2Zca1ViPmS+tA6juWFZXdZjfCQySN6tiP8mUQBt4qHUW/bsGpM2wPYtzHZUJfTjI 94ufFxgWH75hz2XPhPW1jFo11kvE8NfxhhVtD1sz0BipYnRxAyaPhep6lo+gGFA3Pn dhQrORpQbR8HWfJKOAGov3x+mfuNNyA7vUw+VIKIOHU0fs2beU/nbCK+7VlXlcaUit em3uNRgRk/Z/c+P9tGsgNWCX3FgzXXL4SkJGytmJUVqdwLuFJrTaHBPwuBjM/IXOjN 48KIpB6oKmnfw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Peter Zijlstra , Thomas Gleixner Subject: [PATCH 07/20] soc/qman: test: Use kthread_run_on_cpu() Date: Fri, 26 Jul 2024 23:56:43 +0200 Message-ID: <20240726215701.19459-8-frederic@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240726215701.19459-1-frederic@kernel.org> References: <20240726215701.19459-1-frederic@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_145724_372958_E2797DEB X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the proper API instead of open coding it. However it looks like kthreads here could be replaced by the use of a per-cpu workqueue instead. Signed-off-by: Frederic Weisbecker --- drivers/soc/fsl/qbman/qman_test_stash.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c b/drivers/soc/fsl/qbman/qman_test_stash.c index b7e8e5ec884c..f4d3c2146f4f 100644 --- a/drivers/soc/fsl/qbman/qman_test_stash.c +++ b/drivers/soc/fsl/qbman/qman_test_stash.c @@ -108,14 +108,12 @@ static int on_all_cpus(int (*fn)(void)) .fn = fn, .started = ATOMIC_INIT(0) }; - struct task_struct *k = kthread_create(bstrap_fn, &bstrap, - "hotpotato%d", cpu); + struct task_struct *k = kthread_run_on_cpu(bstrap_fn, &bstrap, + cpu, "hotpotato%d"); int ret; if (IS_ERR(k)) return -ENOMEM; - kthread_bind(k, cpu); - wake_up_process(k); /* * If we call kthread_stop() before the "wake up" has had an * effect, then the thread may exit with -EINTR without ever