From patchwork Wed Jul 31 18:58:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13749064 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A998C3DA64 for ; Wed, 31 Jul 2024 19:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HRJ4rDOmPjWn4iWdpMUQdIoWNUbrXdtsCGyr9RSic3g=; b=PomxAZBVnbMVBko++NzATYr165 cXdh7zgDJX2a3B46rlWm3IBfZr9hZ4VoQPknm+77tCxwrBdd96oTULRbwWvZ/jM/W7ZlmbgcQol93 QawU8G30Fn8tUz82uTIlhh01n8K8XqlUV8FllcFgww1omd7Mbjf2HlY9UCl+QWAr6WlwiIu6Ehm/H emMijKkmUKUqD+hSLipj/JLk0bpI36fuoVDS6AdvVkviAQTwuawY/g5pDxUotXV3EfxtVVo/tp7fn uZCcS8S1jx069D4NPTyGglaQ6d+m894wzqlxEGVX0qBVmwGBhkUD73K6WN9DBT2qv220/qlcQGsh4 xrp0g7Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZEZB-00000002CjE-3icT; Wed, 31 Jul 2024 19:00:53 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZEXi-00000002CAg-2qZs for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 18:59:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4722CE17D4; Wed, 31 Jul 2024 18:59:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D653C116B1; Wed, 31 Jul 2024 18:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722452360; bh=XSg+lwQ2g0nRVDthJlG8jLEJHyIpajpAAFoMvVS2r5k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=vESV6yaq+se8b/obD5lptkajKWudiLt9pSQ9lwZc3cId+JXJiC85ZmYUFN5Oj6NIC JyRcKhkm3kcezmQDUMYsdALc+66WllZVwa/4wuptaDf9Q2xmuzvdZhu2WtK0gYy74h mCFfyhbcs3512drL+X4KJDwOgZA3jjbcSfpX+6eNS61u8Edx8g4SPdMRJO2SqBdTgh d5L+qCQDKKuzJ76eeXwXbR+0ZTJDH+a2ZERVSTsv8QMYFKH+VS49JplnK4Xzf5Yz0E lKiqB30Y9xrtjJdF+ckAbInzxvjQOFXHg53hCaWWglxWq1ZDVlHghAz0dhAn/Ti80E BOQKZuzv5DtNg== From: Mark Brown Date: Wed, 31 Jul 2024 19:58:37 +0100 Subject: [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions MIME-Version: 1.0 Message-Id: <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org> References: <20240731-kvm-arm64-fgt-doc-v1-0-abb364f8fe57@kernel.org> In-Reply-To: <20240731-kvm-arm64-fgt-doc-v1-0-abb364f8fe57@kernel.org> To: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-37811 X-Developer-Signature: v=1; a=openpgp-sha256; l=1401; i=broonie@kernel.org; h=from:subject:message-id; bh=XSg+lwQ2g0nRVDthJlG8jLEJHyIpajpAAFoMvVS2r5k=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBmqomCoNLrvAvRpKGkMdbEwhgsRaot3JhlgytOQAJI 6WjxHLuJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZqqJggAKCRAk1otyXVSH0CmpB/ 9C4Ym5KBqxoNgXRss3lajUhwhZiOEoo5xFr6umTw5c/SWiK2uOVEKgElVyeM+yAOJE4KOX8zFQqHSd S+AMf1oXBbEOchQ/ULdIALTqTGyjMZ1kJEdSTCl5ljGXkqelqZ+qrbE3DZEoqQ3y/hTuMRyrD2ENuK yi4wODmI7ksUEcbBFJtdnYD5Zqi7vpzMGy+1Xnl0G9wJT2+gVgYWDnFvnysNcPWzYuGy+YXSNJbfd8 lhrgAiK/0u4qG46xWwst+dVzWjUzDcFgXc8TcEWSEOeMjSsZc+lXy/hdrnZyomm/fiQSiKf93kXOCi 5c9KFx7FMOPYTNY+OkZn5k7JtuR3XI X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_115924_373618_BCB50FA9 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Comments in the code say that our definitions for the FGT registers are not the generated ones and are updated only as far as DDI0487 J.a however in commit 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of specifying them") we updated to use the generated definitions, and as of the release of DDI0487 K.a the XML in DD0601 is in sync with the ARM. Remove the outdated comment about divergence. Fixes: 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of specifying them") Signed-off-by: Mark Brown --- arch/arm64/include/asm/kvm_arm.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h index d81cc746e0eb..d347483395b4 100644 --- a/arch/arm64/include/asm/kvm_arm.h +++ b/arch/arm64/include/asm/kvm_arm.h @@ -342,12 +342,7 @@ /* * FGT register definitions * - * RES0 and polarity masks as of DDI0487J.a, to be updated as needed. - * We're not using the generated masks as they are usually ahead of - * the published ARM ARM, which we use as a reference. - * - * Once we get to a point where the two describe the same thing, we'll - * merge the definitions. One day. + * RES0 and polarity masks for the FGT registers. */ #define __HFGRTR_EL2_RES0 HFGxTR_EL2_RES0 #define __HFGRTR_EL2_MASK GENMASK(49, 0)