| Message ID | 20240801160136.1281291-3-peteryin.openbmc@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revise Meta(Facebook) Harma BMC(AST2600) | expand |
On Fri, 2024-08-02 at 00:01 +0800, Peter Yin wrote: > Add isl69260, xdpe152c4 device > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > --- > .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > index d99fba321379..8fb30029e46c 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > @@ -398,6 +398,30 @@ imux28: i2c@0 { > #address-cells = <1>; > #size-cells = <0>; > reg = <0>; > + power-monitor@61 { > + compatible = "isil,isl69260"; > + reg = <0x61>; > + }; > + power-monitor@62 { > + compatible = "isil,isl69260"; > + reg = <0x62>; > + }; > + power-monitor@63 { > + compatible = "isil,isl69260"; > + reg = <0x63>; > + }; As of v6.11-rc1 this gives me: ``` $ ./scripts/checkpatch.pl --strict -g HEAD ... WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ #24: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:402: + compatible = "isil,isl69260"; WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ #28: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:406: + compatible = "isil,isl69260"; WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ #32: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:410: + compatible = "isil,isl69260"; total: 0 errors, 3 warnings, 0 checks, 30 lines checked ``` and ``` $ make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-harma.dtb 2>&1 | grep isil ... arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@61: failed to match any schema with compatible: ['isil,isl69260'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@62: failed to match any schema with compatible: ['isil,isl69260'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@63: failed to match any schema with compatible: ['isil,isl69260'] ``` While there's already an Aspeed-based Quanta platform that also specifies this device, let's not add to the problems of the Aspeed devicetrees. Please make sure to run `make dtbs_check ...` and checkpatch on your changes. Regarding `make dtbs_check` and related tests, this blog post is helpful: https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ Andrew
On Fri, 2024-08-02 at 16:06 +0930, Andrew Jeffery wrote: > On Fri, 2024-08-02 at 00:01 +0800, Peter Yin wrote: > > Add isl69260, xdpe152c4 device > > > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > > --- > > .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > > index d99fba321379..8fb30029e46c 100644 > > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts > > @@ -398,6 +398,30 @@ imux28: i2c@0 { > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <0>; > > + power-monitor@61 { > > + compatible = "isil,isl69260"; > > + reg = <0x61>; > > + }; > > + power-monitor@62 { > > + compatible = "isil,isl69260"; > > + reg = <0x62>; > > + }; > > + power-monitor@63 { > > + compatible = "isil,isl69260"; > > + reg = <0x63>; > > + }; > > As of v6.11-rc1 this gives me: > > ``` > $ ./scripts/checkpatch.pl --strict -g HEAD > ... > WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ > #24: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:402: > + compatible = "isil,isl69260"; > > WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ > #28: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:406: > + compatible = "isil,isl69260"; > > WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/ > #32: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:410: > + compatible = "isil,isl69260"; > > total: 0 errors, 3 warnings, 0 checks, 30 lines checked > ``` > > and > > ``` > $ make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-harma.dtb 2>&1 | grep isil > ... > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@61: failed to match any schema with compatible: ['isil,isl69260'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@62: failed to match any schema with compatible: ['isil,isl69260'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus@1e78a000/i2c@700/i2c-mux@70/i2c@0/power-monitor@63: failed to match any schema with compatible: ['isil,isl69260'] > ``` > > While there's already an Aspeed-based Quanta platform that also > specifies this device, let's not add to the problems of the Aspeed > devicetrees. > > Please make sure to run `make dtbs_check ...` and checkpatch on your > changes. Regarding `make dtbs_check` and related tests, this blog post > is helpful: > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ On the basis of the reviews on [1] and Rob stating he's applied the binding patch, I've applied this series to be picked up through the BMC tree. [1]: https://lore.kernel.org/all/20240809070056.3588694-1-peteryin.openbmc@gmail.com/ Thanks, Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts index d99fba321379..8fb30029e46c 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts @@ -398,6 +398,30 @@ imux28: i2c@0 { #address-cells = <1>; #size-cells = <0>; reg = <0>; + power-monitor@61 { + compatible = "isil,isl69260"; + reg = <0x61>; + }; + power-monitor@62 { + compatible = "isil,isl69260"; + reg = <0x62>; + }; + power-monitor@63 { + compatible = "isil,isl69260"; + reg = <0x63>; + }; + power-monitor@64 { + compatible = "infineon,xdpe152c4"; + reg = <0x64>; + }; + power-monitor@66 { + compatible = "infineon,xdpe152c4"; + reg = <0x66>; + }; + power-monitor@68 { + compatible = "infineon,xdpe152c4"; + reg = <0x68>; + }; }; imux29: i2c@1 { #address-cells = <1>;
Add isl69260, xdpe152c4 device Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> --- .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)