| Message ID | 20240805065051.3129354-1-treapking@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mediatek: mt8183: Remove clock from mfg_async power domain | expand |
Il 05/08/24 08:50, Pin-yen Lin ha scritto: > This clock dependency introduced a mutual dependency between mfg_async > power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that > this dependency is not needed. Remove this to avoid potential deadlock. > Uhm, have you tested this upstream with Panfrost, or only downstream with the proprietary Mali stack? Regards, Angelo > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index fbf145639b8c..267378fa46c0 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -872,8 +872,6 @@ power-domain@MT8183_POWER_DOMAIN_CONN { > > mfg_async: power-domain@MT8183_POWER_DOMAIN_MFG_ASYNC { > reg = <MT8183_POWER_DOMAIN_MFG_ASYNC>; > - clocks = <&topckgen CLK_TOP_MUX_MFG>; > - clock-names = "mfg"; > #address-cells = <1>; > #size-cells = <0>; > #power-domain-cells = <1>;
On Mon, Aug 5, 2024 at 7:46 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 05/08/24 08:50, Pin-yen Lin ha scritto: > > This clock dependency introduced a mutual dependency between mfg_async > > power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that > > this dependency is not needed. Remove this to avoid potential deadlock. > > > > Uhm, have you tested this upstream with Panfrost, or only downstream with the > proprietary Mali stack? Tested-by: Chen-Yu Tsai <wenst@chromium.org> With glmark2-es2-drm on linux-next-20240805: # glmark2-es2-drm Warning: DRM_CAP_ASYNC_PAGE_FLIP not supported, falling back to 'mailbox' mode for SwapInterval(0). ======================================================= glmark2 2023.01 ======================================================= OpenGL Information GL_VENDOR: Panfrost GL_RENDERER: Mali-G72 (Panfrost) GL_VERSION: OpenGL ES 3.1 Mesa 22.3.6 Surface Config: buf=32 r=8 g=8 b=8 a=8 depth=24 stencil=0 samples=0 Surface Size: 1366x768 fullscreen ======================================================= [build] use-vbo=false: FPS: 134 FrameTime: 7.485 ms [build] use-vbo=true: FPS: 391 FrameTime: 2.559 ms [texture] texture-filter=nearest: FPS: 378 FrameTime: 2.652 ms [texture] texture-filter=linear: FPS: 329 FrameTime: 3.046 ms [texture] texture-filter=mipmap: FPS: 369 FrameTime: 2.717 ms [shading] shading=gouraud: FPS: 367 FrameTime: 2.731 ms [shading] shading=blinn-phong-inf: FPS: 372 FrameTime: 2.690 ms [shading] shading=phong: FPS: 342 FrameTime: 2.930 ms [shading] shading=cel: FPS: 338 FrameTime: 2.964 ms [bump] bump-render=high-poly: FPS: 336 FrameTime: 2.978 ms [bump] bump-render=normals: FPS: 376 FrameTime: 2.663 ms [bump] bump-render=height: FPS: 328 FrameTime: 3.052 ms [effect2d] kernel=0,1,0;1,-4,1;0,1,0;: FPS: 316 FrameTime: 3.169 ms [effect2d] kernel=1,1,1,1,1;1,1,1,1,1;1,1,1,1,1;: FPS: 118 FrameTime: 8.511 ms [pulsar] light=false:quads=5:texture=false: FPS: 372 FrameTime: 2.692 ms [desktop] blur-radius=5:effect=blur:passes=1:separable=true:windows=4: FPS: 51 FrameTime: 19.764 ms [desktop] effect=shadow:windows=4: FPS: 191 FrameTime: 5.254 ms [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 49 FrameTime: 20.746 ms [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=subdata: FPS: 49 FrameTime: 20.437 ms [buffer] columns=200:interleave=true:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 53 FrameTime: 18.997 ms [ideas] speed=duration: FPS: 117 FrameTime: 8.554 ms [jellyfish] <default>: FPS: 282 FrameTime: 3.559 ms ... Thanks ChenYu > Regards, > Angelo > > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") > > > > --- > > > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index fbf145639b8c..267378fa46c0 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -872,8 +872,6 @@ power-domain@MT8183_POWER_DOMAIN_CONN { > > > > mfg_async: power-domain@MT8183_POWER_DOMAIN_MFG_ASYNC { > > reg = <MT8183_POWER_DOMAIN_MFG_ASYNC>; > > - clocks = <&topckgen CLK_TOP_MUX_MFG>; > > - clock-names = "mfg"; > > #address-cells = <1>; > > #size-cells = <0>; > > #power-domain-cells = <1>; > >
On Mon, 05 Aug 2024 14:50:23 +0800, Pin-yen Lin wrote: > This clock dependency introduced a mutual dependency between mfg_async > power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that > this dependency is not needed. Remove this to avoid potential deadlock. > > Applied to v6.11-next/dts64, thanks! [1/1] arm64: dts: mediatek: mt8183: Remove clock from mfg_async power domain commit: 8294c090a05d10fa17fc63ffdaa643f1d123addc Cheers, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index fbf145639b8c..267378fa46c0 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -872,8 +872,6 @@ power-domain@MT8183_POWER_DOMAIN_CONN { mfg_async: power-domain@MT8183_POWER_DOMAIN_MFG_ASYNC { reg = <MT8183_POWER_DOMAIN_MFG_ASYNC>; - clocks = <&topckgen CLK_TOP_MUX_MFG>; - clock-names = "mfg"; #address-cells = <1>; #size-cells = <0>; #power-domain-cells = <1>;
This clock dependency introduced a mutual dependency between mfg_async power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that this dependency is not needed. Remove this to avoid potential deadlock. Signed-off-by: Pin-yen Lin <treapking@chromium.org> Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 -- 1 file changed, 2 deletions(-)