From patchwork Fri Aug 9 17:27:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 13759036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAE90C52D7C for ; Fri, 9 Aug 2024 17:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=WQPvShp7okcQ7JAAqXTExHsdJANgIA/pYy+7v5WQOgw=; b=SAY3PnnhSLEBMHx1y+xA7ReT82 Bxt4b4rOmiRNTh2dbrSJw9jExNOZlS+dfnMOH6sMk6ZeTAALvSpBCsXPHhYnDXkMa5M8Ya78aRQhZ eP/r0i9fSVjf2jdHbdI5hU+xoBZFpPohune6+Wp/J69cBBn7QVh6G/wU0DQPHbCW9F9nnMK640SM8 eGRDab3JyZnq50TtJbK06uKx+u99tFBpF+3PAV8VjycjCpMwXWOTatbaqYYdKZlnKcVFPBxclZDl9 uQbKY0tbrjb72orMcPvhok5QICwLsCyn17BYbhzxTT7knAxW2opyDNeyfbUZBWr4WZSbQlRdT0fOr sKueR+6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scTPI-0000000C4MO-0SDX; Fri, 09 Aug 2024 17:28:04 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scTOe-0000000C43m-1Qmz for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 17:27:26 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-7a23fbb372dso1705986a12.0 for ; Fri, 09 Aug 2024 10:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723224441; x=1723829241; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WQPvShp7okcQ7JAAqXTExHsdJANgIA/pYy+7v5WQOgw=; b=mycR67Gq8fPH+07CUQ06VpHGB0T4aEmKy5KX/8nTEeaAfRaOKfOcbrbNCyBx/E+/Ob Jztzd/tvqZIxUOKyDDhbPo4xQHiBPzIyD+K/khpXviHDd4/PbXQN4Eoycvv6qQziDF0v AklMMzP/e4OlV3c58CJgwxzHt38V4AXbtd6oXt5Q2nhtRewHZyNi07Z4f3LPWmjG//nF W5CmmQYTfkUnaW06K6JKGuW4ddgkPtdN2HxxccogjRka/XFceWWEbsvwgimk3NeIVWgV 3Bbt0WPVkWH8A6nvOnWx4v0squfBYj+6eqyiUZ+8yWXArTQ1BJKHPZBxaiRMMrGk2Ybh g7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723224441; x=1723829241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WQPvShp7okcQ7JAAqXTExHsdJANgIA/pYy+7v5WQOgw=; b=EtcHF8O9n+iG3izyOVRA4RAbxAa9hJU2DnkuulOKJ0RP8ej1Sby+Fmmzh+JYM3iZXn 8P+vqPXKo6F6rAYNNuhB8DfEaV4CB/oFBB/L2o/qHrNKh/vWRlfFaOK4a2vMN3XetACi qpkt/dhPX7d3mNjd60Gu0gvCcZbBf/LncI2QMtzaw4r2QzVZaKmgqoX+l6Y7F6aLL4CR 2OjIg/VJE2hgH4frLRQNQhawE16UsQOa+v3m5fdSmtvRNCfpCscqGPdgNyNIZj8H0LTR 2752RwHzwArbsS+SwkypnZiYGvtCMcK1rgUim4FvueVJuE+7niNnBqrUywIuLuUhZnYx 7IRw== X-Forwarded-Encrypted: i=1; AJvYcCVUKmvOpqNeCHZ4FvGEvUxIlduT+w53F/DWDni8A4tXalcOYri81nfFyMkdv5I+ILlqhtqYD3CfgegEUNP24S7jpXAHNQWbYqlJU6PHIcFZYXKFoao= X-Gm-Message-State: AOJu0YxvL4NFqTQ2NYSb7ejY2wdl3ZlYcC+LUqNYOWT3gHU+Q9VDLgKn y/092xM9OrTUY91UsZ3MfOUMBdGZ64nqJfHvdMOOgdesH3cC2+rr X-Google-Smtp-Source: AGHT+IEkjgGPg89j21Z6sTTJq8iGEXpSiujWsxC7JsiG4AHSF1ZSDSAZTLb4PrewOtx7fnimA5C9Jg== X-Received: by 2002:a17:903:2308:b0:1fb:8cab:ccc9 with SMTP id d9443c01a7336-200ae5cf9aemr27913985ad.45.1723224441376; Fri, 09 Aug 2024 10:27:21 -0700 (PDT) Received: from localhost ([2a00:79e1:2e00:1301:12e9:d196:a1e9:ab67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200bba0db27sm56455ad.239.2024.08.09.10.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 10:27:20 -0700 (PDT) From: Rob Clark To: iommu@lists.linux.dev Cc: Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Krzysztof Kozlowski , Georgi Djakov , Dmitry Baryshkov , Pranjal Shrivastava , linux-arm-kernel@lists.infradead.org (moderated list:ARM SMMU DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Date: Fri, 9 Aug 2024 10:27:14 -0700 Message-ID: <20240809172716.10275-1-robdclark@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_102724_402926_C6AAA3A8 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rob Clark Previously this was dev_err_ratelimited() but it got changed to a ratelimited dev_dbg(). Change it back to dev_err(). Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs") Signed-off-by: Rob Clark Reviewed-by: Pranjal Shrivastava --- We have crash telemetry watching for "Unhandled context fault", so we want to preserve this error msg. drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c index 723273440c21..8321962b3714 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c @@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx, void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx, const struct arm_smmu_context_fault_info *cfi) { - dev_dbg(smmu->dev, + dev_err(smmu->dev, "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n", cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);