diff mbox series

[v2,2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation

Message ID 20240812135231.43744-3-andrei.simion@microchip.com (mailing list archive)
State New, archived
Headers show
Series Add input voltage suppliers for PMIC MCP16502 regulators | expand

Commit Message

Andrei Simion Aug. 12, 2024, 1:52 p.m. UTC 
Update the yaml schema with info about input supply phandle for
each buck and ldo according with the PMIC MCP16502 Datasheet.

Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
v1 -> v2:
- added in v2
---
 .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Krzysztof Kozlowski Aug. 14, 2024, 9:07 a.m. UTC | #1 
On 12/08/2024 15:52, Andrei Simion wrote:
> Update the yaml schema with info about input supply phandle for
> each buck and ldo according with the PMIC MCP16502 Datasheet.
> 
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> ---
> v1 -> v2:
> - added in v2
> ---
>  .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> index 1aca3646789e..c3e1fc6e260e 100644
> --- a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> +++ b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> @@ -28,6 +28,21 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  lvin-supply:
> +    description: Input supply phandle for LDO1 and LDO2

If there is going to be respin, drop phandle. Stating obvious is not
helping - you describe here hardware, not DT.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
index 1aca3646789e..c3e1fc6e260e 100644
--- a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
+++ b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
@@ -28,6 +28,21 @@  properties:
   reg:
     maxItems: 1
 
+  lvin-supply:
+    description: Input supply phandle for LDO1 and LDO2
+
+  pvin1-supply:
+    description: Input supply phandle for VDD_IO (BUCK1)
+
+  pvin2-supply:
+    description: Input supply phandle for VDD_DDR (BUCK2)
+
+  pvin3-supply:
+    description: Input supply phandle for VDD_CORE (BUCK3)
+
+  pvin4-supply:
+    description: Input supply phandle for VDD_OTHER (BUCK4)
+
   regulators:
     type: object
     additionalProperties: false
@@ -68,6 +83,11 @@  examples:
         pmic@5b {
             compatible = "microchip,mcp16502";
             reg = <0x5b>;
+            lvin-supply = <&reg_5v>;
+            pvin1-supply = <&reg_5v>;
+            pvin2-supply = <&reg_5v>;
+            pvin3-supply = <&reg_5v>;
+            pvin4-supply = <&reg_5v>;
 
             regulators {
                 VDD_IO {