From patchwork Mon Aug 12 17:41:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13760896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DEE7C3DA7F for ; Mon, 12 Aug 2024 17:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0/4g5AstBf1dmI4SOaZ5hNLPO4RZC6PVnFvBCU45/bQ=; b=LVe/e7hjfCxiVnyve4V+T0K/Of SQQkCrMDH6LTeEwALI00ybPRdvofX+k+w8LVfiF2wvHWHFgRw8mzT5bgI04iKhmBX41Dx6h9+qj+Y A+o3BRsNVik+CuMhQJSQy4sFHhv1ai9kuIyoSBkneIkqplkU4w7DOzZEONYDIEzdPLAGhG1pX/12X 6JY2g6U8Quz+h9ATt0EixgEHzlLLda8V1V3WS/ajlpOYvLULHIxm4kyHZmcAlG/pr2mzC4xWv+vhN waWkhjDFmBz1DXoPwdBfvakRxXauuQZDjOFoGgfsbWV/B2PYBzCPrgSMk9i6P10zFT8Tw9Z56bPTK 1dDQllzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdZ53-000000014oi-0atE; Mon, 12 Aug 2024 17:43:41 +0000 Received: from out-186.mta1.migadu.com ([2001:41d0:203:375::ba]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdZ37-000000014KX-3hsD for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 17:41:43 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723484499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0/4g5AstBf1dmI4SOaZ5hNLPO4RZC6PVnFvBCU45/bQ=; b=NgoLLMCJu8UDjzStpCiZNF7p/PAPHJayI6lqlKGrq+KH+0EJqAwfY5BzIRbR9r1xCTNZu7 BHh/sRkwTxy+YEhmRnu28yWL+6QLQVZIDmVK4WO4DKqY8PDM1bk9zPclkqoVZhWWuOl06+ xHax1XphmuhJYXpKTrJFoIycTiJsjn0= From: Sean Anderson To: Andrew Lunn , Radhey Shyam Pandey , netdev@vger.kernel.org Cc: Simon Horman , Jakub Kicinski , Russell King , "David S . Miller" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paolo Abeni , Michal Simek , Eric Dumazet , Sean Anderson Subject: [PATCH net-next v2 1/2] net: xilinx: axienet: Report RxRject as rx_dropped Date: Mon, 12 Aug 2024 13:41:17 -0400 Message-Id: <20240812174118.3560730-2-sean.anderson@linux.dev> In-Reply-To: <20240812174118.3560730-1-sean.anderson@linux.dev> References: <20240812174118.3560730-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_104142_389654_3079E213 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Receive Frame Rejected interrupt is asserted whenever there was a receive error (bad FCS, bad length, etc.) or whenever the frame was dropped due to a mismatched address. So this is really a combination of rx_otherhost_dropped, rx_length_errors, rx_frame_errors, and rx_crc_errors. Mismatched addresses are common and aren't really errors at all (much like how fragments are normal on half-duplex links). To avoid confusion, report these events as rx_dropped. This better reflects what's going on: the packet was received by the MAC but dropped before being processed. Signed-off-by: Sean Anderson Reviewed-by: Andrew Lunn --- (no changes since v1) drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index ca04c298daa2..b2d7c396e2e3 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1296,7 +1296,7 @@ static irqreturn_t axienet_eth_irq(int irq, void *_ndev) ndev->stats.rx_missed_errors++; if (pending & XAE_INT_RXRJECT_MASK) - ndev->stats.rx_frame_errors++; + ndev->stats.rx_dropped++; axienet_iow(lp, XAE_IS_OFFSET, pending); return IRQ_HANDLED;