From patchwork Wed Aug 14 15:39:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 13763659 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA4DC3DA4A for ; Wed, 14 Aug 2024 15:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SVC8+R3o277w5fNoilij6jhy0Uz3vrCP4aj5epdO9AI=; b=0GiY8dKfsQXhJx3GPHOI5ltRr2 t0CgaKlC+S2gocYRj5dqkRuLjorHats3hmsDA2vIjTIykUmBC6E4jo2DO5+ac72NE4ZHUJxUNnzA9 LWHaZqVXOhbaLgbyVKGur/MAVTMHN45Qy1O+bNXmo5lY52GyuKf/wvm5us/NebJ5B52dWQBGPJDWr aPfH79Mcnp4R4EAHkVyRJRngUuDOy++2QweJPfniyLnNcuUQnYZ/5p33eLZFW96kTOa0F7jSnFG8s 8T+J4jHgyrrB/likQLEJv1LN1o7K37bJ1UNfQxlgTIXH33n47yz9zQUCkrUuFPBdCQCtd52MgI8m9 BN9I5u6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seG8D-00000007VMu-2NkB; Wed, 14 Aug 2024 15:41:49 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seG6O-00000007UwJ-3r57 for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 15:39:58 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1fc47abc040so45386335ad.0 for ; Wed, 14 Aug 2024 08:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723649996; x=1724254796; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SVC8+R3o277w5fNoilij6jhy0Uz3vrCP4aj5epdO9AI=; b=QgdLT/hcqT/oVYjRhG8L11psNCE99em5vXbwFfjF+VDzGxCskflKDdvIie8irV5KjS 03t6iF8fTS9uXLna+2kGXlQmHG9QFOO7Yp5bK0I1m3/MRpAq841RgyJCRtzquBnCSCiq 4IsJbBVT3WNpPY03kO72TppY9Qi4UmZhumfVsNocUShMSTBSoQ7H/tmsuBpoI7K/jzhO c+BLdkXYR/4f2WbEsUJV7htXZ+ks0vRozuAmEr7+LjGleGqBfanXXziDya/y27LsbNKc aBhMxtcF9wWMW/ZT72fgAsR6wAHijvbcLW/baegPNr1Ay8RsJIuy69PqxQYhFOSOTu+e vn5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723649996; x=1724254796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SVC8+R3o277w5fNoilij6jhy0Uz3vrCP4aj5epdO9AI=; b=HkLEZBp20PpP5q5tjsrGi2aEdCN8FWf3yZ4mNbQGsTkAPv5/NM43c9PGagwCrsy4yj 3/tfuFE128trCcIwQmBI/b4PazPRoKF8yYhDxPAzfdE6H1KsoPU7QU7z0ytUL199SZtr hJQ5/NQBL5vmub0YXyO0WpqGQKCclAeu5K5JQGd4k282ehurs1sPfKpQKET2JKbnKblN diLXuGP2IYwzOaNIv56r9xiU7qBYufxeRYHceYMgVzJHxHf/jn03xw9x9KeehmNiARs8 GcEUvaL5uV76UgUOatxCmI9WcCZosm0Ztrc5AWLGXM8Pv6Rc06irRK00Sij8iSZQU2Ll 9ucw== X-Gm-Message-State: AOJu0YzPxO8IEiSBwWQzxw5BiF0ZoD9nljbiMCPgfvkiW3x8QPxGfw6L sz3OfGgxaMFUHI7R9koGRl9JofHDAk7zK1qiDlbyE2D0mzautg/4Isz+VlRg4ZQ= X-Google-Smtp-Source: AGHT+IF5oDNr91igBSg2NfRwuOvbCVJoL4vmoO1/1J8Fnt1BqFQUkyXIHnt6DufRL2VaEduL5OBEIg== X-Received: by 2002:a17:902:dad2:b0:1ff:4a1e:865c with SMTP id d9443c01a7336-201d642a47amr34790655ad.29.1723649995515; Wed, 14 Aug 2024 08:39:55 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1cfae8sm30998135ad.264.2024.08.14.08.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:39:54 -0700 (PDT) From: Kevin Hilman Date: Wed, 14 Aug 2024 08:39:29 -0700 Subject: [PATCH v10 2/4] firmware: ti_sci: Add system suspend and resume call MIME-Version: 1.0 Message-Id: <20240814-lpm-constraints-firmware-msp-v10-2-bee4314bbdc8@baylibre.com> References: <20240814-lpm-constraints-firmware-msp-v10-0-bee4314bbdc8@baylibre.com> In-Reply-To: <20240814-lpm-constraints-firmware-msp-v10-0-bee4314bbdc8@baylibre.com> To: Nishanth Menon , Tero Kristo , Santosh Shilimkar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Markus Schneider-Pargmann X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=11683; i=khilman@baylibre.com; h=from:subject:message-id; bh=SApvXlKvTU624fFIvy/O4UZ3820V3is+SI1BRhZolQg=; b=owEBbQKS/ZANAwAKAVk3GJrT+8ZlAcsmYgBmvM/Ie+n+Nf3UcgIudixyFrsttDD2YnNWjE6RM noHtGd/VMWJAjMEAAEKAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCZrzPyAAKCRBZNxia0/vG ZUH9D/oDFbGSy0yrvCYC2a9tvln5b9lk1Oe4O1iqylXwy6bOQ4Q9kp+7CV4OModr9zxJPQrm8Y+ Rb90Wexniq/T233MTyydLh6miZhaMsYKxyX3PdIiTL5J8wJXgcrUk/InT0z3Q5ACGDrIlYvnWpF S9nDb6GP5rh67UHzIdJNUPi8ygqCwKRQgIbFQkfx8lJGpV3Qh9DqH+4Vu8i+7ByJFF7GD+J9f6z gruedE4zauyliLjq5mlnv6ekts9gtvYW4/9bm8qiaRkAkuW5K9daubXmtbEU1e6Cl+E4pXAwl/f V8xVy+ScqJtOYn/O5U9NwiyjQU2vCSZmw/lu3NIpFpQL5JMtXFTXmy3ikmO+879qVVN7/aIemzz Q8JIsyEjGryo6Cad4LEze3QiJkoZtRQh7+EslA9VMdovvunCf0GLiF9gJhTKn1MA7uAbgPwBSUt QIyyH+EWlZUN2NrR1DDKYWmoJZId0TPKc0cSfswI7XpTPYfIqDw3i1TKpOogX6ZeQVKTkn914gl mWAU1Cu6Y6pGTDxkrOSPtJKaotdXYz0EDkW+zWQP5OHKprCgeBh3BlzK8OOc/oJFkByA8ioEkJe 9kgkKgRweIMsR4Lh5JErMLullMGfpjyVj2RQ80eMPEa+fj1tpkwTk3D2dRvr6Z0qf9JTNHqayPS CULLTb0VnvNGw/Q== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_083957_014788_059CE15C X-CRM114-Status: GOOD ( 34.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Vibhore Vardhan Introduce system suspend call that enables the ti_sci driver to support low power mode when the user space issues a suspend to mem. The following power management operations defined in the TISCI Low Power Mode API [1] are implemented to support suspend and resume: 1) TISCI_MSG_PREPARE_SLEEP Prepare the SOC for entering into a low power mode and provide details to firmware about the state being entered. 2) TISCI_MSG_SET_IO_ISOLATION Control the IO isolation for Low Power Mode. Also, write a ti_sci_prepare_system_suspend call to be used in the driver suspend handler to allow the system to identify the low power mode being entered and if necessary, send TISCI_MSG_PREPARE_SLEEP with information about the mode being entered. Sysfw version >= 10.00.04 support LPM_DM_MANAGED capability [2], where Device Mgr firmware now manages which low power mode is chosen. Going forward, this is the default configuration supported for TI AM62 family of devices. The state chosen by the DM can be influenced by sending constraints using the new LPM constraint APIs. In case the firmware does not support LPM_DM_MANAGED mode, the mode selection logic can be extended as needed. If no suspend-to-RAM modes are supported, return without taking any action. We're using "pm_suspend_target_state" to map the kernel's target suspend state to SysFW low power mode. Make sure this is available only when CONFIG_SUSPEND is enabled. Suspend has to be split into two parts, ti_sci_suspend() will send the prepare sleep message to prepare suspend. ti_sci_suspend_noirq() sets IO isolation which needs to be done as late as possible to avoid any issues. On resume this has to be done as early as possible. [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html Co-developed-by: Dave Gerlach Signed-off-by: Dave Gerlach Signed-off-by: Georgi Vlaev Signed-off-by: Dhruva Gole Signed-off-by: Vibhore Vardhan Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Kevin Hilman --- drivers/firmware/ti_sci.c | 188 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/firmware/ti_sci.h | 45 ++++++++++++++++++++++++++++++++++++++++- include/linux/soc/ti/ti_sci_protocol.h | 4 ++++ 3 files changed, 236 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index f77e13577eb8..808149dcc635 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -1654,6 +1655,65 @@ static int ti_sci_cmd_clk_get_freq(const struct ti_sci_handle *handle, return ret; } +/** + * ti_sci_cmd_prepare_sleep() - Prepare system for system suspend + * @handle: pointer to TI SCI handle + * @mode: Device identifier + * @ctx_lo: Low part of address for context save + * @ctx_hi: High part of address for context save + * @debug_flags: Debug flags to pass to firmware + * + * Return: 0 if all went well, else returns appropriate error value. + */ +static int ti_sci_cmd_prepare_sleep(const struct ti_sci_handle *handle, u8 mode, + u32 ctx_lo, u32 ctx_hi, u32 debug_flags) +{ + struct ti_sci_info *info; + struct ti_sci_msg_req_prepare_sleep *req; + struct ti_sci_msg_hdr *resp; + struct ti_sci_xfer *xfer; + struct device *dev; + int ret = 0; + + if (IS_ERR(handle)) + return PTR_ERR(handle); + if (!handle) + return -EINVAL; + + info = handle_to_ti_sci_info(handle); + dev = info->dev; + + xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_PREPARE_SLEEP, + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, + sizeof(*req), sizeof(*resp)); + if (IS_ERR(xfer)) { + ret = PTR_ERR(xfer); + dev_err(dev, "Message alloc failed(%d)\n", ret); + return ret; + } + + req = (struct ti_sci_msg_req_prepare_sleep *)xfer->xfer_buf; + req->mode = mode; + req->ctx_lo = ctx_lo; + req->ctx_hi = ctx_hi; + req->debug_flags = debug_flags; + + ret = ti_sci_do_xfer(info, xfer); + if (ret) { + dev_err(dev, "Mbox send fail %d\n", ret); + goto fail; + } + + resp = (struct ti_sci_msg_hdr *)xfer->xfer_buf; + + ret = ti_sci_is_response_ack(resp) ? 0 : -ENODEV; + +fail: + ti_sci_put_one_xfer(&info->minfo, xfer); + + return ret; +} + /** * ti_sci_msg_cmd_query_fw_caps() - Get the FW/SoC capabilities * @handle: Pointer to TI SCI handle @@ -1710,6 +1770,58 @@ static int ti_sci_msg_cmd_query_fw_caps(const struct ti_sci_handle *handle, return ret; } +/** + * ti_sci_cmd_set_io_isolation() - Enable IO isolation in LPM + * @handle: Pointer to TI SCI handle + * @state: The desired state of the IO isolation + * + * Return: 0 if all went well, else returns appropriate error value. + */ +static int ti_sci_cmd_set_io_isolation(const struct ti_sci_handle *handle, + u8 state) +{ + struct ti_sci_info *info; + struct ti_sci_msg_req_set_io_isolation *req; + struct ti_sci_msg_hdr *resp; + struct ti_sci_xfer *xfer; + struct device *dev; + int ret = 0; + + if (IS_ERR(handle)) + return PTR_ERR(handle); + if (!handle) + return -EINVAL; + + info = handle_to_ti_sci_info(handle); + dev = info->dev; + + xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_IO_ISOLATION, + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, + sizeof(*req), sizeof(*resp)); + if (IS_ERR(xfer)) { + ret = PTR_ERR(xfer); + dev_err(dev, "Message alloc failed(%d)\n", ret); + return ret; + } + req = (struct ti_sci_msg_req_set_io_isolation *)xfer->xfer_buf; + req->state = state; + + ret = ti_sci_do_xfer(info, xfer); + if (ret) { + dev_err(dev, "Mbox send fail %d\n", ret); + goto fail; + } + + resp = (struct ti_sci_msg_hdr *)xfer->xfer_buf; + + ret = ti_sci_is_response_ack(resp) ? 0 : -ENODEV; + +fail: + ti_sci_put_one_xfer(&info->minfo, xfer); + + return ret; +} + static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle) { struct ti_sci_info *info; @@ -3321,6 +3433,79 @@ static int tisci_reboot_handler(struct sys_off_data *data) return NOTIFY_BAD; } +#ifdef CONFIG_SUSPEND +static int ti_sci_prepare_system_suspend(struct ti_sci_info *info) +{ + u8 mode; + + /* + * Map and validate the target Linux suspend state to TISCI LPM. + * Default is to let Device Manager select the low power mode. + */ + switch (pm_suspend_target_state) { + case PM_SUSPEND_MEM: + if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) + mode = TISCI_MSG_VALUE_SLEEP_MODE_DM_MANAGED; + else + /* DM Managed is not supported by the firmware. */ + return -EOPNOTSUPP; + break; + default: + /* + * Do not fail if we don't have action to take for a + * specific suspend mode. + */ + return 0; + } + + return ti_sci_cmd_prepare_sleep(&info->handle, mode, 0, 0, 0); +} + +static int ti_sci_suspend(struct device *dev) +{ + struct ti_sci_info *info = dev_get_drvdata(dev); + int ret; + + ret = ti_sci_prepare_system_suspend(info); + if (ret) + return ret; + + return 0; +} + +static int ti_sci_suspend_noirq(struct device *dev) +{ + struct ti_sci_info *info = dev_get_drvdata(dev); + int ret = 0; + + ret = ti_sci_cmd_set_io_isolation(&info->handle, TISCI_MSG_VALUE_IO_ENABLE); + if (ret) + return ret; + dev_dbg(dev, "%s: set isolation: %d\n", __func__, ret); + + return 0; +} + +static int ti_sci_resume_noirq(struct device *dev) +{ + struct ti_sci_info *info = dev_get_drvdata(dev); + int ret = 0; + + ret = ti_sci_cmd_set_io_isolation(&info->handle, TISCI_MSG_VALUE_IO_DISABLE); + if (ret) + return ret; + dev_dbg(dev, "%s: disable isolation: %d\n", __func__, ret); + + return 0; +} + +static const struct dev_pm_ops ti_sci_pm_ops = { + .suspend = ti_sci_suspend, + .suspend_noirq = ti_sci_suspend_noirq, + .resume_noirq = ti_sci_resume_noirq, +}; +#endif /* CONFIG_SUSPEND */ + /* Description for K2G */ static const struct ti_sci_desc ti_sci_pmmc_k2g_desc = { .default_host_id = 2, @@ -3490,6 +3675,9 @@ static struct platform_driver ti_sci_driver = { .name = "ti-sci", .of_match_table = of_match_ptr(ti_sci_of_match), .suppress_bind_attrs = true, +#ifdef CONFIG_SUSPEND + .pm = &ti_sci_pm_ops, +#endif }, }; module_platform_driver(ti_sci_driver); diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h index 73ca9503606b..8efe4d0e61fb 100644 --- a/drivers/firmware/ti_sci.h +++ b/drivers/firmware/ti_sci.h @@ -6,7 +6,7 @@ * The system works in a message response protocol * See: https://software-dl.ti.com/tisci/esd/latest/index.html for details * - * Copyright (C) 2015-2016 Texas Instruments Incorporated - https://www.ti.com/ + * Copyright (C) 2015-2024 Texas Instruments Incorporated - https://www.ti.com/ */ #ifndef __TI_SCI_H @@ -36,6 +36,10 @@ #define TI_SCI_MSG_QUERY_CLOCK_FREQ 0x010d #define TI_SCI_MSG_GET_CLOCK_FREQ 0x010e +/* Low Power Mode Requests */ +#define TI_SCI_MSG_PREPARE_SLEEP 0x0300 +#define TI_SCI_MSG_SET_IO_ISOLATION 0x0307 + /* Resource Management Requests */ #define TI_SCI_MSG_GET_RESOURCE_RANGE 0x1500 @@ -567,6 +571,45 @@ struct ti_sci_msg_resp_get_clock_freq { u64 freq_hz; } __packed; +/** + * struct tisci_msg_req_prepare_sleep - Request for TISCI_MSG_PREPARE_SLEEP. + * + * @hdr TISCI header to provide ACK/NAK flags to the host. + * @mode Low power mode to enter. + * @ctx_lo Low 32-bits of physical pointer to address to use for context save. + * @ctx_hi High 32-bits of physical pointer to address to use for context save. + * @debug_flags Flags that can be set to halt the sequence during suspend or + * resume to allow JTAG connection and debug. + * + * This message is used as the first step of entering a low power mode. It + * allows configurable information, including which state to enter to be + * easily shared from the application, as this is a non-secure message and + * therefore can be sent by anyone. + */ +struct ti_sci_msg_req_prepare_sleep { + struct ti_sci_msg_hdr hdr; + +#define TISCI_MSG_VALUE_SLEEP_MODE_DM_MANAGED 0xfd + u8 mode; + u32 ctx_lo; + u32 ctx_hi; + u32 debug_flags; +} __packed; + +/** + * struct tisci_msg_set_io_isolation_req - Request for TI_SCI_MSG_SET_IO_ISOLATION. + * + * @hdr: Generic header + * @state: The deseared state of the IO isolation. + * + * This message is used to enable/disable IO isolation for low power modes. + * Response is generic ACK / NACK message. + */ +struct ti_sci_msg_req_set_io_isolation { + struct ti_sci_msg_hdr hdr; + u8 state; +} __packed; + #define TI_SCI_IRQ_SECONDARY_HOST_INVALID 0xff /** diff --git a/include/linux/soc/ti/ti_sci_protocol.h b/include/linux/soc/ti/ti_sci_protocol.h index bd0d11af76c5..1f1871e23f76 100644 --- a/include/linux/soc/ti/ti_sci_protocol.h +++ b/include/linux/soc/ti/ti_sci_protocol.h @@ -195,6 +195,10 @@ struct ti_sci_clk_ops { u64 *current_freq); }; +/* TISCI LPM IO isolation control values */ +#define TISCI_MSG_VALUE_IO_ENABLE 1 +#define TISCI_MSG_VALUE_IO_DISABLE 0 + /** * struct ti_sci_resource_desc - Description of TI SCI resource instance range. * @start: Start index of the first resource range.