| Message ID | 20240814104151.2038457-2-b-padhi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Reserve Timer Nodes to avoid clash with Remoteproc | expand |
On 8/14/2024 4:11 PM, Beleswar Padhi wrote: > The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain There is no DSP on this SOC. Please consider to re-word commit message > use timers. Therefore, change the status of the timer nodes to > "reserved" to avoid any clash. Usage is described as below: > > +===================+==========================+ > | Remoteproc node | Timer Node | > +===================+==========================+ > | main_r5fss0_core0 | main_timer0, main_timer2 | > +-------------------+--------------------------+ > | main_r5fss0_core1 | main_timer1 | > +-------------------+--------------------------+ > This change is already incorporated for timer nodes in the MCU voltage > domain. For whole series, on MCU domain R5 we have device-manager firmware, which is needed to get SOC functional. So MCU domain timers are reserved. So my suggestion will be to avoid above message > > Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers") > Signed-off-by: Beleswar Padhi <b-padhi@ti.com> > --- > .../boot/dts/ti/k3-j7200-common-proc-board.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 6593c5da82c0..a65066bd7f09 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -471,3 +471,16 @@ &main_mcan3 { > pinctrl-0 = <&main_mcan3_pins_default>; > phys = <&transceiver3>; > }; > + > +/* Timers are used by Remoteproc firmware */ > +&main_timer0 { > + status = "reserved"; > +}; > + > +&main_timer1 { > + status = "reserved"; > +}; > + > +&main_timer2 { > + status = "reserved"; > +};
Hi Udit, On 14-08-2024 20:41, Kumar, Udit wrote: > > On 8/14/2024 4:11 PM, Beleswar Padhi wrote: >> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain > > There is no DSP on this SOC. > > Please consider to re-word commit message Thanks for catching this! Will fix in revision. > > >> use timers. Therefore, change the status of the timer nodes to >> "reserved" to avoid any clash. Usage is described as below: >> >> +===================+==========================+ >> | Remoteproc node | Timer Node | >> +===================+==========================+ >> | main_r5fss0_core0 | main_timer0, main_timer2 | >> +-------------------+--------------------------+ >> | main_r5fss0_core1 | main_timer1 | >> +-------------------+--------------------------+ > > >> This change is already incorporated for timer nodes in the MCU voltage >> domain. > > For whole series, on MCU domain R5 we have device-manager firmware, > > which is needed to get SOC functional. So MCU domain timers are reserved. Understood. Will fix in revision. > > So my suggestion will be to avoid above message > > >> >> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose >> timers") >> Signed-off-by: Beleswar Padhi <b-padhi@ti.com> >> --- >> .../boot/dts/ti/k3-j7200-common-proc-board.dts | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index 6593c5da82c0..a65066bd7f09 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -471,3 +471,16 @@ &main_mcan3 { >> pinctrl-0 = <&main_mcan3_pins_default>; >> phys = <&transceiver3>; >> }; >> + >> +/* Timers are used by Remoteproc firmware */ >> +&main_timer0 { >> + status = "reserved"; >> +}; >> + >> +&main_timer1 { >> + status = "reserved"; >> +}; >> + >> +&main_timer2 { >> + status = "reserved"; >> +};
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts index 6593c5da82c0..a65066bd7f09 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts @@ -471,3 +471,16 @@ &main_mcan3 { pinctrl-0 = <&main_mcan3_pins_default>; phys = <&transceiver3>; }; + +/* Timers are used by Remoteproc firmware */ +&main_timer0 { + status = "reserved"; +}; + +&main_timer1 { + status = "reserved"; +}; + +&main_timer2 { + status = "reserved"; +};
The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain use timers. Therefore, change the status of the timer nodes to "reserved" to avoid any clash. Usage is described as below: +===================+==========================+ | Remoteproc node | Timer Node | +===================+==========================+ | main_r5fss0_core0 | main_timer0, main_timer2 | +-------------------+--------------------------+ | main_r5fss0_core1 | main_timer1 | +-------------------+--------------------------+ This change is already incorporated for timer nodes in the MCU voltage domain. Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers") Signed-off-by: Beleswar Padhi <b-padhi@ti.com> --- .../boot/dts/ti/k3-j7200-common-proc-board.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)