diff mbox series

[v4,10/10] ARM: dts: samsung: exynos4212-tab3: Drop CHARGER regulator

Message ID 20240816-max77693-charger-extcon-v4-10-050a0a9bfea0@gmail.com (mailing list archive)
State New, archived
Headers show
Series power: supply: max77693: Toggle charging/OTG based on extcon status | expand

Commit Message

Artur Weber Aug. 16, 2024, 8:19 a.m. UTC 
We don't use it for managing charging, and it interferes with the
extcon-based charging mode switching.

Tested-by: Henrik Grimler <henrik@grimler.se>
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v3:
- Added this commit
---
 arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 7 -------
 1 file changed, 7 deletions(-)

Comments

Krzysztof Kozlowski Aug. 16, 2024, 10:04 a.m. UTC | #1 
On 16/08/2024 10:19, Artur Weber wrote:
> We don't use it for managing charging, and it interferes with the
> extcon-based charging mode switching.
> 
> Tested-by: Henrik Grimler <henrik@grimler.se>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v3:
> - Added this commit
> ---
>  arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 7 -------
>  1 file changed, 7 deletions(-)

This probably should be squashed with previous commit. The previous
commit re-implements charger, right? Or you want to keep it for some
other release, after driver code reaches Linus' tree?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
index 7309b4e1cc3d..2006cdcf3909 100644
--- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
@@ -148,13 +148,6 @@  esafeout1_reg: ESAFEOUT1 {
 				esafeout2_reg: ESAFEOUT2 {
 					regulator-name = "ESAFEOUT2";
 				};
-
-				charger_reg: CHARGER {
-					regulator-name = "CHARGER";
-					regulator-min-microamp = <60000>;
-					regulator-max-microamp = <2580000>;
-					regulator-boot-on;
-				};
 			};
 
 			muic {