From patchwork Mon Aug 19 09:03:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Eichenberger X-Patchwork-Id: 13768100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE0CDC5320E for ; Mon, 19 Aug 2024 09:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=73KaV9INZpxIDOJ2Xw69bHLb9GRPh7H+PU9DOGB19/g=; b=K7zZn8W4l4RwMu8LukWE5Uptnn tBoM++LcW8QXjd5OuoYARUoUTBlzFOUTwWsFE1roaCBy303XH8/KKgdKcLczK4T/A3/AIrc+GovUj 6sezLRY5cG/ExEE2lwTHO7vlMhoxgq51V9mptgKXFud+i5EQSczw/gKwmebIOSAWRv+CJ8r755AEf wyvxnn7aq6Im4nt2JGzSXEZm5pnsrzQe4SaA9ETSUckDb8q4Hv1jQnz8RO1GFuaMWIGWQpG2moclT Y7oHjpqtH6YRN+kV8eZ9bhx70kIbNT/QvIlPR16WBv3CyaIluMrZ8ToDuuVC0uJU711wibNqFNuHV pkPc83oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfyLS-00000000sTg-2yT2; Mon, 19 Aug 2024 09:06:35 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfyJZ-00000000rrH-2RVd for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 09:04:38 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-371941bbfb0so1858756f8f.0 for ; Mon, 19 Aug 2024 02:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724058275; x=1724663075; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=73KaV9INZpxIDOJ2Xw69bHLb9GRPh7H+PU9DOGB19/g=; b=h/tBho5RjfREO8oR9uOJAvj+yOM9kNwUuaNv/+KrT+2zPD4KAU+jZMYqwBH3U14Mr5 2pzM9QOc08UUohChEc3M0KmAbeh5zzG5ACPC/PIES3A75QT1xHRXBf/YeCbJzhoBe2Vc AcyQiooCVNG4lxneJYUZuc0TXwV6LJM6ESqHIcrdQDn171Sc1tjjIFWT2EQn3/oKOenq eVa2/vpRvvegYTMWtqFZfQ1X15ozTLVBrR/8AKd3vz88GMrwk5im4NC1+GPlS+UcipJQ tM3ygWVbZAAyiqezXIZ8EDPmjPzZLDapodaBh1JYnRSvqfYSgvAa36+OMXuZsu3w+SDB TDWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724058275; x=1724663075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=73KaV9INZpxIDOJ2Xw69bHLb9GRPh7H+PU9DOGB19/g=; b=TRLNDrx+KOko2pc//YJWlDe6fdw1qfQiJCVWwcV4YudxboPXgZIrdCnomHSeiFC4LV 0hPw2IJhsuG18Qoo3wt/bkiL/6ed+XwXlKLZPdKeZTnvRY2BQA5RMB3lzUc1szLpaC8P GVV0w+78/uEUKQCevnJeCLxL9OgecP7dtm6hhDEQ2FPYoDZ7NxCD95/VuHkUIAQ3p8TY Hh3/ntDndMvj5Qc0a+HgR04D9sec7Otzdsfp1L6L1PLF7aYl5oNQNH0uX3HSNmY7RS35 D7u6ohFRxPHYM453PG8Di6AWudSY1MTZeWlXqJCEd3CAC1qE+s8k1KkeB/ms3otevrOF 9h3w== X-Forwarded-Encrypted: i=1; AJvYcCWNa/J3MfoBSAPMag/eMbJTJIr4Eri7TatAckHn6E40sd7e7V7+sik4ASyv+6Gk+vQXWZOOvusqw3aN1SykPNn1kuq3vgTWrIVjJtTRHq1neUcmulQ= X-Gm-Message-State: AOJu0YwgQAHq0GOpc1FDeTEfA/i+nZMKFAxRlJYSopATlWzkyL57xtSq 1VRVg+Sfl8LZDWWmQGwalcd3IkBA9L5EAJJWQwWhanVR1uN9oqWG X-Google-Smtp-Source: AGHT+IFj0i36M1XtioC1FP1u9W1VBkISL7S6BIM5YHh9arQA28kGUfNyxyAdUgfl+WXFeQvQpsZc6A== X-Received: by 2002:adf:e78b:0:b0:371:885f:73a with SMTP id ffacd0b85a97d-37194695bf8mr6200443f8f.58.1724058275150; Mon, 19 Aug 2024 02:04:35 -0700 (PDT) Received: from eichest-laptop.toradex.int ([2a02:168:af72:0:a64c:8731:e4fb:38f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded19627sm154672095e9.5.2024.08.19.02.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 02:04:34 -0700 (PDT) From: Stefan Eichenberger To: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, francesco.dolcini@toradex.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: [PATCH v1 2/3] PCI: imx6: move the wait for clock stabilization to enable ref clk Date: Mon, 19 Aug 2024 11:03:18 +0200 Message-ID: <20240819090428.17349-3-eichest@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240819090428.17349-1-eichest@gmail.com> References: <20240819090428.17349-1-eichest@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_020437_646717_06BC3964 X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Stefan Eichenberger After enabling the ref clock, we should wait for the clock to stabilize. To eliminate the need for code duplication in the future, move the usleep to the enable_ref_clk function. Signed-off-by: Stefan Eichenberger --- drivers/pci/controller/dwc/pci-imx6.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index fda704d82431f..f17561791e35a 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -632,6 +632,9 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) break; } + /* allow the clocks to stabilize */ + usleep_range(200, 500); + return ret; } @@ -672,8 +675,6 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) goto err_ref_clk; } - /* allow the clocks to stabilize */ - usleep_range(200, 500); return 0; err_ref_clk: