From patchwork Tue Aug 20 17:53:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13770524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92A93C531DC for ; Tue, 20 Aug 2024 17:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nTZgPced0EBacNzgZdl3oKXmRtpOubbN18kV7+HqIIA=; b=XRrZbQf+hU+HIvmK+Bhv9+6tBx BpeoQFmu1loKwPr+15+RvJVWQHueRIHjhTiuhR4kKOHmh0lrfVz1hn8n2OqJwcFr/uCmvyRJ9yltB 7d80lckPrtpAq4DGgKQpxk6vozgyP7iLw1AWtoBm4A2SaYgjLEonK3eisCh6JYJVgl6IIXW3NFrQi 3p3ruaDhLVFpxbGjg3LVXY4L/qM7b8BbLnTnlDn4bN9vcBnRvfCoNwqbD+BHs9kLI7QpiOLVjH7OL jgV0YSMPjqDeyjGyntwLQH4x9xxZoXlnjmHzNLdeB7SXGO7hiom89o7ypSaRQfiOGBhLKWTqk8/QC zHRZvS2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgT4t-00000006FBK-3G6o; Tue, 20 Aug 2024 17:55:31 +0000 Received: from out-186.mta1.migadu.com ([95.215.58.186]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgT3X-00000006Eob-0lEy for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 17:54:08 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724176444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nTZgPced0EBacNzgZdl3oKXmRtpOubbN18kV7+HqIIA=; b=OTzhgWHGCq9yhk3BBxLgXO8KySqTGJWIvleEsZNneLkuCaEqmL7AE5W0f3uyHIjQxLvYRl 8Z47m7JECNBiIrkg+xVxaxPUhI1ALmog3Ue8Vc3aeCQFD00T/pa7kYU0oxWktmnFR1/fxP I5kDhZBKmsujt5ecE7lDKPJZ3a5WaQU= From: Sean Anderson To: Andrew Lunn , Radhey Shyam Pandey , netdev@vger.kernel.org Cc: Michal Simek , linux-kernel@vger.kernel.org, Russell King , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Simon Horman , linux-arm-kernel@lists.infradead.org, Sean Anderson Subject: [PATCH net-next v4 1/2] net: xilinx: axienet: Report RxRject as rx_dropped Date: Tue, 20 Aug 2024 13:53:41 -0400 Message-Id: <20240820175343.760389-2-sean.anderson@linux.dev> In-Reply-To: <20240820175343.760389-1-sean.anderson@linux.dev> References: <20240820175343.760389-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_105407_387678_B75AF1D7 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Receive Frame Rejected interrupt is asserted whenever there was a receive error (bad FCS, bad length, etc.) or whenever the frame was dropped due to a mismatched address. So this is really a combination of rx_otherhost_dropped, rx_length_errors, rx_frame_errors, and rx_crc_errors. Mismatched addresses are common and aren't really errors at all (much like how fragments are normal on half-duplex links). To avoid confusion, report these events as rx_dropped. This better reflects what's going on: the packet was received by the MAC but dropped before being processed. Signed-off-by: Sean Anderson Reviewed-by: Andrew Lunn Reviewed-by: Radhey Shyam Pandey --- (no changes since v1) drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index ca04c298daa2..b2d7c396e2e3 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1296,7 +1296,7 @@ static irqreturn_t axienet_eth_irq(int irq, void *_ndev) ndev->stats.rx_missed_errors++; if (pending & XAE_INT_RXRJECT_MASK) - ndev->stats.rx_frame_errors++; + ndev->stats.rx_dropped++; axienet_iow(lp, XAE_IS_OFFSET, pending); return IRQ_HANDLED;