| Message ID | 20240821120517.330868-1-ada@thorsis.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: nand: raw: atmel: Add message on DMA usage | expand |
Hi Alexander, ada@thorsis.com wrote on Wed, 21 Aug 2024 14:05:16 +0200: > Like for other atmel drivers (serial, crypto, mmc, …), too. > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index dc75d50d52e8..9e6dea2cf140 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > nc->dmac = dma_request_channel(mask, NULL, NULL); > if (!nc->dmac) > dev_err(nc->dev, "Failed to request DMA channel\n"); > + dev_info(nc->dev, "using %s for DMA transfers\n", > + dma_chan_name(nc->dmac)); The message here would be misleading if !nc->dmac. > } > > /* We do not retrieve the SMC syscon when parsing old DTs. */ > > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399 Thanks, Miquèl
Hi Miquel, Am Wed, Aug 21, 2024 at 03:17:01PM +0200 schrieb Miquel Raynal: > Hi Alexander, > > ada@thorsis.com wrote on Wed, 21 Aug 2024 14:05:16 +0200: > > > Like for other atmel drivers (serial, crypto, mmc, …), too. > > > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > > --- > > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > > index dc75d50d52e8..9e6dea2cf140 100644 > > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > > @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > > nc->dmac = dma_request_channel(mask, NULL, NULL); > > if (!nc->dmac) > > dev_err(nc->dev, "Failed to request DMA channel\n"); > > + dev_info(nc->dev, "using %s for DMA transfers\n", > > + dma_chan_name(nc->dmac)); > > > The message here would be misleading if !nc->dmac. Of course you're right, this is somewhat embarassing. I'll send a v2. Thanks for reviewing. Alex > > > } > > > > /* We do not retrieve the SMC syscon when parsing old DTs. */ > > > > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399 > > > Thanks, > Miquèl
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index dc75d50d52e8..9e6dea2cf140 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, nc->dmac = dma_request_channel(mask, NULL, NULL); if (!nc->dmac) dev_err(nc->dev, "Failed to request DMA channel\n"); + dev_info(nc->dev, "using %s for DMA transfers\n", + dma_chan_name(nc->dmac)); } /* We do not retrieve the SMC syscon when parsing old DTs. */
Like for other atmel drivers (serial, crypto, mmc, …), too. Signed-off-by: Alexander Dahl <ada@thorsis.com> --- drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++ 1 file changed, 2 insertions(+) base-commit: 47ac09b91befbb6a235ab620c32af719f8208399