From patchwork Fri Aug 23 15:14:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13775416 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9071C52D7C for ; Fri, 23 Aug 2024 15:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0c0COUOBxosZ6Dh6bvR6TkUXfLHs/HYf1LvR6gsqcgQ=; b=jDO2o7ijOyPwpCVMBS7pg2CM3P ymdQoiGlpjNXJwUyNhMDB0Mg/tgO0DUMjs5JpT6bTNLW4xuAxJSxgWNaL4D90b0C+6vSPznXyncKr NXJhypXKTFqsG8ONRfQqObCkRl7M3nTNnYpxCLf+ggSpWmZdzO/AoUjJ1zxmGNVJv6b+Ro3C674g5 rAZm/vvzibjBVheV9nMBlV4DOoHPsx5pJxuwHX5hg0aZ6bWHO3mK1Nyc89u/U1YwfjRdooNTWx8jT 5yWi7zjjDmSGjUCqx66XM4w2habvPDXt1PefAqipGdOGLXXkaGrpmUALiOYiKbEQRvM9TQos7y/tv ESVCbj5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shW6X-0000000HHJ0-1L1e; Fri, 23 Aug 2024 15:21:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVzy-0000000HFoD-1weF; Fri, 23 Aug 2024 15:14:48 +0000 Received: from [192.168.29.25] (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 29C2F2D5; Fri, 23 Aug 2024 17:13:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1724426021; bh=ft5HmVJ271Ka/bJA/94LL3znx98d6bWSWFX0dUAPefw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Q3DZFXpclHdZ/+6e4Jd18ji1LPG6XHt6HoeugzKlc1vCDyuPyKukYEfbts7zoTRsJ IMWj87TkkD21HmPnkkOM3XufvajTkaKTv73XwZGGQW82o5pDm3iCDoyPzAP08aGxRc uYEopsfFomI9/abZflIW58K6KfGmX8enyjRpw9f8= From: Umang Jain Date: Fri, 23 Aug 2024 20:44:27 +0530 Subject: [PATCH 7/7] staging: vchiq_core: Pass enumerated flag instead of int MIME-Version: 1.0 Message-Id: <20240823-to_sent2-v1-7-8bc182a0adaf@ideasonboard.com> References: <20240823-to_sent2-v1-0-8bc182a0adaf@ideasonboard.com> In-Reply-To: <20240823-to_sent2-v1-0-8bc182a0adaf@ideasonboard.com> To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Laurent Pinchart , Kieran Bingham , Arnd Bergmann , Stefan Wahren , Dave Stevenson , Phil Elwell , Umang Jain X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724426064; l=1116; i=umang.jain@ideasonboard.com; s=20240731; h=from:subject:message-id; bh=ft5HmVJ271Ka/bJA/94LL3znx98d6bWSWFX0dUAPefw=; b=706rLwU+aQ7hCnwi1dFxvBR3MCVDFdJxF5p7v54O82gJEHTRCNQvzEUFefEXbgDTezf176Ldi 5FZTvpp/mEMDk9U3lAXJI0dnlAtyS/HHN9x78XUHnnRvtNZpX/iqfW3 X-Developer-Key: i=umang.jain@ideasonboard.com; a=ed25519; pk=7pvnIBNsDpFUMiph0Vlhrr01+rAn5fSIn/QtDeLeXL0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_081446_735261_48169986 X-CRM114-Status: UNSURE ( 7.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pass proper enumerated flag which exists, instead of an integer while calling queue_message(). It helps with readability of the code. Signed-off-by: Umang Jain Reviewed-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 84631878f77d..54e21a4273b8 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3146,7 +3146,8 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle, switch (service->srvstate) { case VCHIQ_SRVSTATE_OPEN: status = queue_message(service->state, service, data_id, - copy_callback, context, size, 1); + copy_callback, context, size, + QMFLAGS_IS_BLOCKING); break; case VCHIQ_SRVSTATE_OPENSYNC: status = queue_message_sync(service->state, service, data_id,