From patchwork Sun Aug 25 05:16:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 13776691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3290C5320E for ; Sun, 25 Aug 2024 05:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+36NNSRmVK5FdylQPpVTYi2UVBcAisEyHgKp3fnH560=; b=uL/SOHQ9Aumd/25t61ePe7NQK7 haPoSIGOFBVtEAzr7ftcv1XXXGK9FBvQip3at83lyYQpsQXwilo6nW0HNJqalebBZjl/TICpvoXy8 +WT8ShU21+LbAS6Fb6tJr+jtn4djpPO8WVON3slTXnnJz8udo4IlnG8Mx+0clzCfOkoSFHH7OMuFj mWZui4MsNxay+6gsUrWz7Q7h+Pe1LuwdCJfnH96CRv/8njAK7PlTiL6ZhACOVyxB/xpBAhk3H3tFd GNatOFDneLdF1OMzLUmsZ/YFWzb1BM4PWVtBjr/GjHIzZzAk+cF4RBGLs7mZQc8l1GOMvoQcZZ6lM aGaST2mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1si5no-00000003gZU-36NX; Sun, 25 Aug 2024 05:28:36 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1si5cQ-00000003dgO-2MdV for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 05:16:51 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-2703967b10cso2397282fac.0 for ; Sat, 24 Aug 2024 22:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724563009; x=1725167809; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+36NNSRmVK5FdylQPpVTYi2UVBcAisEyHgKp3fnH560=; b=V1Kuf8UfWo/S+uenWcxb1upvKzKEjQv6Nl6VWQSJOlRjJ0Kc1DGrEOdyaFK5p4NcSI IcS0uH0iEiw8VcX0fIbEJh6c5hx4r4W0PIZ0jRRr59NC8KaoMGJHPMbA6fylpySSIDXW JdaCsB846ENeD0lwRAiKGQomT/2ET3zzEKbeouPS4gV/wt8vbDhzGv/NMWUIGHP2J9xl mZSTeADuR5UBc9pUgBJYRMMtd6bLPGy8Z9k2dXBU+ZrX/HhYy9xxP5ALd2rjlRiHnLpM CBUY+tB2HW+RSBCrqcJkEkGNbo9Im29Kly90rKOD8HOUqXtxDwi1syTskzyEEzoXrCQy kpiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724563009; x=1725167809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+36NNSRmVK5FdylQPpVTYi2UVBcAisEyHgKp3fnH560=; b=PWwYQVrWqHF2SkcB7tftl97x28kK93PhfGgzZT4bJ7oKmoypSfaA0cZs2tEZ0rbu4q vLmsN6U/Zd7/prNv361jEWdfUSrDbyRyQnD3Gl8iTihfhh8pAsU7o3A58WvtjESsH3RS wA53Z/MHdEsksWZ5RFY+82rdCd+R0ixByyK9E/cGv6/ofG8p5joadRLZ2CddxyOUSrx1 P5faI5ta/P1F0fNnwqN4btr18vk5PkPYm99NfctyIeErl656/c8DN6xmy7JS6c9rE0Zl OjUOYrjnDaCcFrkiRDshBpDDt0w0stYkyr9WsPnSfHEN5zq4jf9tlMEngaIfCtU//D/F 5clg== X-Forwarded-Encrypted: i=1; AJvYcCW4cZeIbAtVvnl/EskvsgXNa3+Wgj3XqeciAjEP0tnzdB8uGmU1Xq0v/OWeJbWDVxgq0bkuUBsP6U01ZqDRmEbu@lists.infradead.org X-Gm-Message-State: AOJu0YyapQnJ5URvH5Cv7eHMl06bMInjJ9E+Fcxd6htEcwz26EVKrwzF wThTbovr7jZ2+ywue3fE/8fLLU/I9giWlNYA/h6JdWsb9b++FglB X-Google-Smtp-Source: AGHT+IH50jfqsAxngsJyrNPRIognUKjg0ENHDCRW+P0AHBitO/WlT6UscLBhxwYmGb+kHjshcMLPag== X-Received: by 2002:a05:6870:2010:b0:270:1fc6:18 with SMTP id 586e51a60fabf-273e64458d2mr7894304fac.3.1724563009229; Sat, 24 Aug 2024 22:16:49 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2620:15c:9d:2:66dc:ce07:b7cc:51ea]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7cd9ad55a94sm5622442a12.57.2024.08.24.22.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 22:16:48 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Michael Hennerich , Shawn Guo , Sascha Hauer , Fabio Estevam , Laxman Dewangan , Thierry Reding , Hans de Goede , Tony Lindgren , Jeff LaBundy , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH 08/17] Input: iqs62x-keys - use cleanup facility for fwnodes Date: Sat, 24 Aug 2024 22:16:12 -0700 Message-ID: <20240825051627.2848495-9-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.46.0.295.g3b9ea8a38a-goog In-Reply-To: <20240825051627.2848495-1-dmitry.torokhov@gmail.com> References: <20240825051627.2848495-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_221650_629631_A68595ED X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use __free(fwnode_handle) cleanup facility to ensure that references to acquired fwnodes are dropped at appropriate times automatically. Signed-off-by: Dmitry Torokhov Reviewed-by: Jeff LaBundy --- drivers/input/keyboard/iqs62x-keys.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/input/keyboard/iqs62x-keys.c b/drivers/input/keyboard/iqs62x-keys.c index 688d61244b5f..1315b0f0862f 100644 --- a/drivers/input/keyboard/iqs62x-keys.c +++ b/drivers/input/keyboard/iqs62x-keys.c @@ -45,7 +45,6 @@ struct iqs62x_keys_private { static int iqs62x_keys_parse_prop(struct platform_device *pdev, struct iqs62x_keys_private *iqs62x_keys) { - struct fwnode_handle *child; unsigned int val; int ret, i; @@ -68,7 +67,8 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, } for (i = 0; i < ARRAY_SIZE(iqs62x_keys->switches); i++) { - child = device_get_named_child_node(&pdev->dev, + struct fwnode_handle *child __free(fwnode_handle) = + device_get_named_child_node(&pdev->dev, iqs62x_switch_names[i]); if (!child) continue; @@ -77,7 +77,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, if (ret) { dev_err(&pdev->dev, "Failed to read switch code: %d\n", ret); - fwnode_handle_put(child); return ret; } iqs62x_keys->switches[i].code = val; @@ -91,8 +90,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, iqs62x_keys->switches[i].flag = (i == IQS62X_SW_HALL_N ? IQS62X_EVENT_HALL_N_T : IQS62X_EVENT_HALL_S_T); - - fwnode_handle_put(child); } return 0;