From patchwork Sun Aug 25 12:36:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13776745 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAFC6C5321E for ; Sun, 25 Aug 2024 12:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=1CeKLJiREErcfFDmVmFht0rfeHvolojmCG1SEp0D9eA=; b=DmMjzfihhAlrox4tPYD7amFieA +zrtHDBtp2amLcTGUNuW64oXcJ6Gf5nTLKal/6zLZo1XP4oLzILJyMV7Pqj2a+4/5byP3N+VVFX1P k4/zmWdahq7mUvSBAwxb4qtaSnQ28tuHL3GRHA3WjKxu5AhGVRUNvZC928dxY5TVFldu0LWK8DyVg UIzy7/isps31LK45v0wF/v/cplq3qrgFil5z8OoalhqmtgJ5HBxsNbrKlYdZthwZnMtB0PI891BHF oKGIflNdfVLaoa4PQR48TVSmQFP97n+4ltqtgV7sTgFG8sTrs6Jb2T2CgBDvph8mB62eOLN/SRZ44 LV7aPmDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siCUk-00000004Izi-2X0c; Sun, 25 Aug 2024 12:37:22 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siCTx-00000004Ios-450a for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 12:36:35 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5bf01bdaff0so3680903a12.3 for ; Sun, 25 Aug 2024 05:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1724589391; x=1725194191; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1CeKLJiREErcfFDmVmFht0rfeHvolojmCG1SEp0D9eA=; b=MEiFRbJxmL8fREUjJZ9PJhUJFm2hjfO0tTys5utGP7cKIMU2gni89jgstmPJMqi/QE ECSEjDe5bWRpbsloTCtg3QRzqKqFSyr31iqIHEFGMQgRBhHgfMP2gMVKeBUKVw0qd38O mnH/TliqaErXGUmXGQ5HGJewCyc5Snek8FtkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724589391; x=1725194191; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1CeKLJiREErcfFDmVmFht0rfeHvolojmCG1SEp0D9eA=; b=YCkuug4++QBUtUhZ5mkrHvc8Kh4RsTi7eVyApTJ51zCjXcPqTFg6udMXim6Fs0KRW8 SazG3XU1UUq8N6ZDvqkVyWx6ipuLioZvCbXnthRKwFJtJeIfq058tQic9As8uSfpO5Tr eTwlb4TduErV/VsPqToIU5dH/NJqvn8wtBqMoU3ownc8/3w5TiolZXGeAu9rKoNLckG6 tWtpzpofoqVFsEvvIynj8PqOPqXUHWMmbWXfm3TNLPFwI7GMvYRGH5t6v2O4xHoY8Tbe NKUcIojwoJ4p+n5a9qKY27rSLCl36IGJg8fgzPiDMDnhmZyFlZo7SGf4qaPEN4wUOwin gVew== X-Forwarded-Encrypted: i=1; AJvYcCUvfVu2d0Ey+6YsWLs/wjm1x9985Yt2FCtiQxtScvjg+XAt8CB2f7rAzhoa5Vdc72PE3IDUELsLBujDGT3ALwnJ@lists.infradead.org X-Gm-Message-State: AOJu0YzdaC1/ZuEvMhRAsS4uLj9EEExrAfQ81S2j5LdAx3AO6AnrgOC5 TxS5btH7Rc4m3WnU9huY/6/91Bnpw1oC1a6tromKT4HCNGEI6bEDdtljORq31tc= X-Google-Smtp-Source: AGHT+IFHSFH/DUCkWWR0GBh4a/QABa5dvYX0l+xr818EafuCdl7Z/HffbouhFE5+OopSoVp6HJHHKA== X-Received: by 2002:a05:6402:d0a:b0:5a2:8bef:c370 with SMTP id 4fb4d7f45d1cf-5c08916403amr5020278a12.15.1724589390746; Sun, 25 Aug 2024 05:36:30 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-25-99-149.retail.telecomitalia.it. [79.25.99.149]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3e89ebsm4350404a12.43.2024.08.25.05.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 05:36:30 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Fabio Estevam , Geert Uytterhoeven , Peng Fan , Pengutronix Kernel Team , "Rafael J. Wysocki" , Sascha Hauer , Shawn Guo , Ulf Hansson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH 1/3] pmdomain: imx93-pd: replace dev_err() with dev_err_probe() Date: Sun, 25 Aug 2024 14:36:14 +0200 Message-ID: <20240825123626.3877812-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_053634_048215_7ED56490 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This way, the code becomes more compact, and dev_err_probe() is used in every error path of the probe() function. Signed-off-by: Dario Binacchi --- drivers/pmdomain/imx/imx93-pd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pmdomain/imx/imx93-pd.c b/drivers/pmdomain/imx/imx93-pd.c index d750a7dc58d2..afc482ec563f 100644 --- a/drivers/pmdomain/imx/imx93-pd.c +++ b/drivers/pmdomain/imx/imx93-pd.c @@ -126,9 +126,9 @@ static int imx93_pd_probe(struct platform_device *pdev) if (!domain->init_off) { ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { - dev_err(domain->dev, "failed to enable clocks for domain: %s\n", - domain->genpd.name); - return ret; + return dev_err_probe(domain->dev, ret, + "failed to enable clocks for domain: %s\n", + domain->genpd.name); } }