diff mbox series

[v2] dts: nxp: mxs: Fix partitions definitions and remove saif (imx28-lwe.dtsi)

Message ID 20240827151042.2254651-1-lukma@denx.de (mailing list archive)
State New, archived
Headers show
Series [v2] dts: nxp: mxs: Fix partitions definitions and remove saif (imx28-lwe.dtsi) | expand

Commit Message

Lukasz Majewski Aug. 27, 2024, 3:10 p.m. UTC
The SPI-NOR memory layout has evolved during time lifetime of the
device - for example special partitions to keep track of booted devices
for A/B booting scheme were added.

Additionally the saifX nodes are specific to other group of the imx287
based devices, so needs to be moved to different devices description.

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---
Changes for v2:
- Add more descriptive commit message
- Replace e.g. partition@4 with partition@fe0000
- Use lower case letters for HEX offsets descriptions
---
 arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi | 38 +++++++++---------------
 1 file changed, 14 insertions(+), 24 deletions(-)

Comments

Shawn Guo Sept. 1, 2024, 9:29 a.m. UTC | #1
On Tue, Aug 27, 2024 at 05:10:42PM +0200, Lukasz Majewski wrote:
> The SPI-NOR memory layout has evolved during time lifetime of the
> device - for example special partitions to keep track of booted devices
> for A/B booting scheme were added.
> 
> Additionally the saifX nodes are specific to other group of the imx287
> based devices, so needs to be moved to different devices description.

It seems the patch should be split into two.

> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

We idiomatically use subject prefix "ARM: dts: " for IMX/MXS DTS
changes, so I would suggest "ARM: dts: imx28-lwe: ..." here.

Shawn
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
index 69fcb0dde940..410dfe17f8ca 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
@@ -55,23 +55,6 @@  &i2c0 {
 	status = "okay";
 };
 
-&saif0 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&saif0_pins_a>;
-	#sound-dai-cells = <0>;
-	assigned-clocks = <&clks 53>;
-	assigned-clock-rates = <12000000>;
-	status = "okay";
-};
-
-&saif1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&saif1_pins_a>;
-	fsl,saif-master = <&saif0>;
-	#sound-dai-cells = <0>;
-	status = "okay";
-};
-
 &spi3_pins_a {
 	fsl,pinmux-ids = <
 		MX28_PAD_AUART2_RX__SSP3_D4
@@ -109,7 +92,7 @@  &ssp3 {
 
 	flash@0 {
 		compatible = "jedec,spi-nor";
-		spi-max-frequency = <40000000>;
+		spi-max-frequency = <20000000>;
 		reg = <0>;
 
 		partitions {
@@ -133,14 +116,21 @@  partition@90000 {
 				reg = <0x90000 0x10000>;
 			};
 
-			partition@100000 {
-				label = "kernel";
-				reg = <0x100000 0x400000>;
+			partition@a0000 {
+				label = "rescue";
+				reg = <0xa0000 0xf40000>;
+			};
+
+			partition@fe0000 {
+				/* 1st sector for SPL boot img source data */
+				label = "spl-boot-data1";
+				reg = <0xfe0000 0x10000>;
 			};
 
-			partition@500000 {
-				label = "swupdate";
-				reg = <0x500000 0x800000>;
+			partition@ff0000 {
+				/* 2nd sector for SPL boot img source data */
+				label = "spl-boot-data2";
+				reg = <0xff0000 0x10000>;
 			};
 		};
 	};