diff mbox series

arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash

Message ID 20240828060830.555733-1-p-mantena@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash | expand

Commit Message

Prasanth Mantena Aug. 28, 2024, 6:08 a.m. UTC
Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support
for OSPI flash") introduced the flash node with discontinuous
partitions. Updating the partition offset to be continuous from
the previous partition to maintain linearity.

Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Nishanth Menon Aug. 30, 2024, 11:24 a.m. UTC | #1
On 11:38-20240828, Prasanth Babu Mantena wrote:
> Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support
> for OSPI flash") introduced the flash node with discontinuous
> partitions. Updating the partition offset to be continuous from
> the previous partition to maintain linearity.
> 
> Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
> ---

Please note my response to a similar patch
https://lore.kernel.org/all/20240830092234.veog3e22te7qi3ao@dugout/

I do not want us breaking existing users unless absolutely warranted,
even then, I'd like us to be very cognizant of the minimum amount of
disruption possible.

Normally, I'd say no to this kind of patches. But, since this is in
the backup env, I am not *that* worried, but I want to make sure folks
understand breaking existing users without a just cause is a NO NO.

>  arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> index 5c66e0ec6e82..2e5730216caa 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> @@ -215,9 +215,9 @@ partition@680000 {
>  				reg = <0x680000 0x40000>;
>  			};
>  
> -			partition@740000 {
> +			partition@6c0000 {
>  				label = "ospi.env.backup";
> -				reg = <0x740000 0x40000>;
> +				reg = <0x6c0000 0x40000>;
>  			};
>  
>  			partition@800000 {
> -- 
> 2.34.1
>
Nishanth Menon Sept. 1, 2024, 9:15 p.m. UTC | #2
Hi Prasanth Babu Mantena,

On Wed, 28 Aug 2024 11:38:30 +0530, Prasanth Babu Mantena wrote:
> Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support
> for OSPI flash") introduced the flash node with discontinuous
> partitions. Updating the partition offset to be continuous from
> the previous partition to maintain linearity.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash
      commit: ce9d793b2bbbfdd6d0ce30f94bd014ab5fb87230

NOTE: I have already mentioned this before, so wont repeat it:
https://lore.kernel.org/all/20240830112452.geyv7tecpb6ydhmz@quotable/

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
index 5c66e0ec6e82..2e5730216caa 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
@@ -215,9 +215,9 @@  partition@680000 {
 				reg = <0x680000 0x40000>;
 			};
 
-			partition@740000 {
+			partition@6c0000 {
 				label = "ospi.env.backup";
-				reg = <0x740000 0x40000>;
+				reg = <0x6c0000 0x40000>;
 			};
 
 			partition@800000 {