From patchwork Mon Sep 9 16:10:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13797287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2333DECE579 for ; Mon, 9 Sep 2024 16:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HYLjaJjab8lWILZwaUDKtxHDlmqX2R9MWPau9VCILks=; b=YHX7imlWI8ViD72Q5PIHpRyGCC 8MzM+pppIFhEGe63qikMelzS4YmdKaChjbvpe2QClHludbuf5ImW/cNXG1nu0WUDmiCk5xa8LMm4u WAgXhztWAksMkTOUBA5JH0oaF3z7WD7JiKGpQkGa62QvjgMCDSiZ77fL9QSqwAUHFqyf6x3VeF+bX KIbFtwV8T4dT6vqvKk5QMwlOnHO+VW0QWTyUB5dHUCo/WvnVfqplYdTHfc5A83p7fz8bi2a/s5pab GCiDmdtDEQE16OqBVlh18w5wcxMb7zwhUhgCbBV44XBvPTJe4akV/bBGHcFhyOkMsMOt4g7GERTKy 386FWNJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snhAg-00000002dU9-29m5; Mon, 09 Sep 2024 16:23:22 +0000 Received: from out-176.mta1.migadu.com ([2001:41d0:203:375::b0]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sngyG-00000002bRN-0ar2 for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2024 16:10:33 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725898229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HYLjaJjab8lWILZwaUDKtxHDlmqX2R9MWPau9VCILks=; b=T5/7VLwhGGEvLhNjsfyIe+LzHATEMF010ZU8OMtFrSM2z6VgninQV+HPMNdauzWTsk4jUw qxWNEs3FZK4I8mkDV7pYmGdnmyC9b5YaAyubV/f4PvnyR1zySgs2ULqnAJ0W2TOZFBV89A 4SXKZnNml7VJZTYNvWxV4Lnyk46GTPw= From: Sean Anderson To: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michal Simek , Sean Anderson , Simon Horman Subject: [PATCH net-next v2 4/4] net: xilinx: axienet: Relax partial rx checksum checks Date: Mon, 9 Sep 2024 12:10:16 -0400 Message-Id: <20240909161016.1149119-5-sean.anderson@linux.dev> In-Reply-To: <20240909161016.1149119-1-sean.anderson@linux.dev> References: <20240909161016.1149119-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_091032_338511_C730025E X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The partial rx checksum feature computes a checksum over the entire packet, regardless of the L3 protocol. Remove the check for IPv4. Additionally, testing with csum.py (from kselftests) shows no anomalies with 64-byte packets, so we can remove that check as well. Signed-off-by: Sean Anderson Reviewed-by: Simon Horman --- Testing was performed with csum.py between two axienet netdevs. I also tested with a macb netdev, but I saw some errors due to 007e4ba3ee13 ("net: macb: initialize checksum when using checksum offloading"). I also tested manually with a dpaa netdev, but I wasn't set up for ssh. Changes in v2: - Expand commit message with testing methodology drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 2f7ab0922aed..4185c5708742 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1188,9 +1188,7 @@ static int axienet_rx_poll(struct napi_struct *napi, int budget) csumstatus == XAE_IP_UDP_CSUM_VALIDATED) { skb->ip_summed = CHECKSUM_UNNECESSARY; } - } else if ((lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) != 0 && - skb->protocol == htons(ETH_P_IP) && - skb->len > 64) { + } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) { skb->csum = be32_to_cpu(cur_p->app3 & 0xFFFF); skb->ip_summed = CHECKSUM_COMPLETE; }