From patchwork Wed Sep 18 18:21:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 13807084 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71E55CDD54D for ; Wed, 18 Sep 2024 18:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mSJkyW7PtmsR3xBcC4s2dK8tXSEoVtyj6mYraRaugmc=; b=jsg7o7Oiuy0nJDMfhtGU215ZED TFjeRnfL79X3weD8YKK6FEn0+kq9DXCIP1XpTrtVVNj2Rt2xsX91soF2O+1fpXV5nriJtfn14MXkW videIl1tlhE/a8PNvnjt8s5nWiIoNyh6yuVjXgnOUnhO3W9kPEUsIjeDffTbeq9UCon+q77iUCGh2 A4KoIG1gbuXpwx5psD74b5EpRhFO9aqdDjYJ7UmndnNEeYJlRT6A94MnggPxL8so+pmoaSNrp4LdC AWweojGiBRVbKC07QpuHgHlfjl7I1r34IS0Ulx0adHutfzyJqSyEvTa5ok9h8XwQtdmKgCLkNz8sm 07QaZcog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqzLk-00000008o48-1LaX; Wed, 18 Sep 2024 18:24:24 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqzJf-00000008ndZ-3a3x for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2024 18:22:17 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-53653ee23adso6479951e87.3 for ; Wed, 18 Sep 2024 11:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726683734; x=1727288534; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mSJkyW7PtmsR3xBcC4s2dK8tXSEoVtyj6mYraRaugmc=; b=N7FAPXBuqySDt+NFHRPAigm65LGoEyypCO2SsONpQw7E4bv9+I1ebaX7j73gQ5EtzU F6H5xAsypNmR9Ef6WB7Pn9/QWeqSM8L69iyuqzBqlPvPFZpf9RdYW7Kn7kV6zWc3UNDB 3dIlepF6HvkjKnVLjKkYdjvtz1WM6ed9pt1OUk4AWISTj6ExD01c4tiQuPJEic64ERYt eFsLvV0JfcjD+OofKUmyWyCwcre+A0+qFnzOn3saRbA1dalsEohA14lbrdthREO1RbFv tNXGji+0OFtBMh76Qdyt4F9pHHLNRqONS5TEFgOcCWLVq2oZ1OCGcIQcYGVCKhaF9dQd kiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726683734; x=1727288534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mSJkyW7PtmsR3xBcC4s2dK8tXSEoVtyj6mYraRaugmc=; b=j/14de8ih+UpriWhWePnvye3I2VOOEQiDDQsO8edP0w7QzWAivhPhL5LdEv6BcjeiW mRTraW1VmQqQntsLqcdg7EWQbvpKscu35eaVque3KXyJe9xjTta7wNqF8koCutjKblAA jv8lA+77z7WzSI5iebLyDTOSpENe2RZ8hbjk5NwIui4eyL3a0pDqY+/NTwAR6DSlmjEO YeiHHZHLiEuQAbnmYt8eDapWZv0CKVtMdbbWv/dI2/DbxVQrm9Q7uW4lxFcHi1uQAFlX tpReO3rsRs/Z/oK/ntOgr36/QZ/UrhOLfXewPC+RXgN9HivbFVs6AcDmhJEnoTX4LlIy PCOg== X-Forwarded-Encrypted: i=1; AJvYcCUHupFaqi6P6c9chz7yZUxBZAWn8uu1EcmXWB4rbpkGEM7ONxEpc7yV9MA4aQtO0pYXfIEkr9hlT6kCDp3GBjmr@lists.infradead.org X-Gm-Message-State: AOJu0YxvsSXpN9porhc6e8NFF8DamH1gQDhClgYJ/PtqkY/vs/Oen9CA 50BCM9z27q2hw//xDAxatvhvGFe4r90GkOAWixt28jIKkwVNT/0V X-Google-Smtp-Source: AGHT+IFrDGvV5858WGdycyJ2YnkzCRsAgTv/brwvViai7wsUYS2uRl7bXI1hX02jiCpLYUubqCIlOg== X-Received: by 2002:a05:6512:1052:b0:533:508f:edf1 with SMTP id 2adb3069b0e04-53678ff4e66mr11144621e87.60.1726683733341; Wed, 18 Sep 2024 11:22:13 -0700 (PDT) Received: from playground.localdomain ([86.127.146.72]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb5312dsm5200146a12.23.2024.09.18.11.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 11:22:12 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] dt-bindings: dsp: fix power domain count Date: Wed, 18 Sep 2024 14:21:13 -0400 Message-Id: <20240918182117.86221-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240918182117.86221-1-laurentiumihalcea111@gmail.com> References: <20240918182117.86221-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_112215_923734_88D96460 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Per the current binding, QM/QXP DSPs are supposed to have 4 power domains, while the rest just 1. For QM/QXP, the 4 power domains are: DSP, DSP_RAM, MU13A, MU13B. First off, drop MU13A from the count. This is attached to the platform device of lsio_mu13. This decreases the count to 3. Secondly, drop DSP and DSP_RAM from the count for QXP. These are attached to the platform devices of the lpcgs (used as clock providers for the DSP). With this in mind, the number of required power domains for QXP is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM). Additionally, two extra power domains may be required in the case of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes using the "-hifi4" compatibles these PDs are optional, while for nodes using the "-dsp" compatibles these are mandatory. These changes reflect all of this information. Signed-off-by: Laurentiu Mihalcea --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++---- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index 9af40da5688e..e2f016af1048 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -51,8 +51,6 @@ properties: description: List of phandle and PM domain specifier as documented in Documentation/devicetree/bindings/power/power_domain.txt - minItems: 1 - maxItems: 4 mboxes: description: @@ -97,16 +95,55 @@ allOf: properties: compatible: contains: - enum: - - fsl,imx8qxp-dsp - - fsl,imx8qm-dsp - - fsl,imx8qxp-hifi4 - - fsl,imx8qm-hifi4 + const: fsl,imx8qxp-hifi4 then: properties: power-domains: - minItems: 4 - else: + maxItems: 3 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qxp-dsp + then: + properties: + power-domains: + minItems: 3 + maxItems: 3 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qm-dsp + then: + properties: + power-domains: + minItems: 5 + maxItems: 5 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qm-hifi4 + then: + properties: + power-domains: + minItems: 3 + maxItems: 5 + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mp-dsp + - fsl,imx8mp-hifi4 + - fsl,imx8ulp-dsp + - fsl,imx8ulp-hifi4 + then: properties: power-domains: maxItems: 1 @@ -157,10 +194,9 @@ examples: <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd IMX_SC_R_MU_13A>, - <&pd IMX_SC_R_MU_13B>, - <&pd IMX_SC_R_DSP>, - <&pd IMX_SC_R_DSP_RAM>; + power-domains = <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_IRQSTR_DSP>, + <&pd IMX_SC_R_MU_2A>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; memory-region = <&dsp_reserved>;