| Message ID | 20240925110044.3678055-4-fshao@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MT8188 DT and binding fixes | expand |
Il 25/09/24 12:57, Fei Shao ha scritto: > The MT8188 SoC features two CPU clusters: one with 6 little Cortex-A55 > cores, and the other with 2 big Cortex-A78 cores. No, it doesn't. It features only one cluster, so... > > Update the CPU topology to reflect the actual hardware configurations. ...the actual hardware configuration is already reflected by the currently declared CPU topology, so for this commit: NAK. This SoC uses the ARM DynamIQ technology and embeds both LITTLE and big cores in one single cluster. Check the MT8188 datasheet for more information :-) Cheers, Angelo > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > arch/arm64/boot/dts/mediatek/mt8188.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > index cd27966d2e3c..51bf08b2ff9b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > @@ -195,12 +195,14 @@ core4 { > core5 { > cpu = <&cpu5>; > }; > + }; > > - core6 { > + cluster1 { > + core0 { > cpu = <&cpu6>; > }; > > - core7 { > + core1 { > cpu = <&cpu7>; > }; > };
On Thu, Sep 26, 2024 at 4:33 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 25/09/24 12:57, Fei Shao ha scritto: > > The MT8188 SoC features two CPU clusters: one with 6 little Cortex-A55 > > cores, and the other with 2 big Cortex-A78 cores. > > No, it doesn't. It features only one cluster, so... > > > > > Update the CPU topology to reflect the actual hardware configurations. > > ...the actual hardware configuration is already reflected by the currently > declared CPU topology, so for this commit: NAK. > > This SoC uses the ARM DynamIQ technology and embeds both LITTLE and big > cores in one single cluster. > Check the MT8188 datasheet for more information :-) You are absolutely right. I found that description in the datasheet, and this patch is completely wrong. Thanks for pointing it out! Regards, Fei > > Cheers, > Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index cd27966d2e3c..51bf08b2ff9b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -195,12 +195,14 @@ core4 { core5 { cpu = <&cpu5>; }; + }; - core6 { + cluster1 { + core0 { cpu = <&cpu6>; }; - core7 { + core1 { cpu = <&cpu7>; }; };
The MT8188 SoC features two CPU clusters: one with 6 little Cortex-A55 cores, and the other with 2 big Cortex-A78 cores. Update the CPU topology to reflect the actual hardware configurations. Signed-off-by: Fei Shao <fshao@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8188.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)