From patchwork Wed Sep 25 23:20:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 13812514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB699CCFA06 for ; Wed, 25 Sep 2024 23:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uu8cS5ZVBT2x5Y4ZLBzCkjnuT+mauwDzK9v+GQaA8mc=; b=Rv4yfA6idd4QKPnq7ArtbBsLze jRMS4ghx2NffgdwEx46GTXYIggr/GbsC2z7N1FeMu50jFwPXjE2p0M460XOHrAl6YTnV4/T6SbmEY mOz9rMB9Gr5Cp5d+JEbSv9xijfbTUXWbVE2g+Gikk133Y8ueoOizD6fs3C5IpQ8T6vXC5pkLiYYR2 Mqx8ixJ7mciSJBtNEK13jZPF0ux4tdW4tqrM9LzDiy1EKKrRaj3z6FsntV+EoXSAQkKR8klrRyzAa BvoRLkVCjeh99DZKumtxgX9lhywo7HqZla/C/GgqkVTJCr+e0tAlnve9y34WKJ7R03alQxLWWoIyi JV5iitfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stbLr-00000006jxn-44Xe; Wed, 25 Sep 2024 23:23:20 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stbJf-00000006jU3-0ogs for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 23:21:04 +0000 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2f66423686bso3009611fa.3 for ; Wed, 25 Sep 2024 16:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727306461; x=1727911261; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uu8cS5ZVBT2x5Y4ZLBzCkjnuT+mauwDzK9v+GQaA8mc=; b=g9DFWAYU/aT2b95JE64YqDEFujZIhc3WztUPyG663xchVvjDX5RRWByX8jDCNSQfwP qsdZSGzH/NHqjRVX/oVolHEjgg5Mt5Kv9AWzyrJbKfyD1XwgJB2SsdvEoUbEG2J3e0Pk wI1nA2Z2MzTwZqnryO17LrVffWqDuUWfsM0hMnz6772I9Ic1LrLttD7lr586z10GESrI yeDItcG6jkT2uT5zOEn5+MweguWWSUOGODsqejr3fRNri8QpVi+ozprWia4MrGL0oRfh 7t3gbJ/9huZGb25AyiYQjqOzVKdJPtJ6eSRt7gLIfjMLRP+aRFnJzTBPBbISwhGAP/Z8 fpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727306461; x=1727911261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uu8cS5ZVBT2x5Y4ZLBzCkjnuT+mauwDzK9v+GQaA8mc=; b=niKzy6RPKmKJwebYIvgaJHiR6bmO/p0xlJIpjre+ndhdKJCSP9g/S7Be83XOUDGcVM SJcbNJ15VOn/fu2+zK54BbFZFYD8KYnpovVka8HR2PGgRjdF5y9iqo1zyTfDUBvjaShc DGX7hVXVP0jZV/PVwFguZ5Zc9P8x3m8nYpIX2xPEAy3sfg43w3f/NHnESr62JD8lmflF /UJNCsMnpnXuJ1ogZjxmBLAkLPSNcrOx1pIr882lBgEcOfoigzHy4fXyKaLcgxiiCkTR ZK7PxsYgNc4eBisMTgq/j8Vi4YpluFwgqbIb/B5CP2DVjx/nYsSc2xU/P+jI8jkG81Zv 9OdA== X-Forwarded-Encrypted: i=1; AJvYcCUq8nixYmHBWFXQd6qA1sW8Gtgh/RVJBEsFd5TUY3UWPCkqmcpHGoCHaVlSdfKg5Y4lNDo7/0L8NJI+PFsFRGW6@lists.infradead.org X-Gm-Message-State: AOJu0Yy+iiyvlOHg9DqMCV7js+n1tvdcA0Vu5Dbu0U5iTEGZCO/e4Rb2 9SRP9uPeZmEjxJWxxwhm65PX0eA+u/5sP4qiWtF5Erw0ikEPNYXaUba3grb+ X-Google-Smtp-Source: AGHT+IHdvjn2giBUs0LazmE6P9wU7waFLc1kqAPFWdrrVS2sXKmllv8Wvmvy0TA72d+Ku978kbQ4dg== X-Received: by 2002:a2e:a995:0:b0:2f5:6b4:1d2b with SMTP id 38308e7fff4ca-2f915fdbad6mr30761441fa.13.1727306460945; Wed, 25 Sep 2024 16:21:00 -0700 (PDT) Received: from playground.localdomain ([86.127.146.72]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c5cf48c315sm2481026a12.15.2024.09.25.16.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 16:20:59 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/6] dt-bindings: dsp: fsl,dsp: fix power domain count Date: Wed, 25 Sep 2024 19:20:03 -0400 Message-Id: <20240925232008.205802-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240925232008.205802-1-laurentiumihalcea111@gmail.com> References: <20240925232008.205802-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_162103_261603_EB53465E X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Per the current binding, QM/QXP DSPs are supposed to have 4 power domains, while the rest just 1. For QM/QXP, the 4 power domains are: DSP, DSP_RAM, MU13A, MU13B. First off, drop MU13A from the count. This is attached to the platform device of lsio_mu13. This decreases the count to 3. Secondly, drop DSP and DSP_RAM from the count for QXP. These are attached to the platform devices of the lpcgs (used as clock providers for the DSP). With this in mind, the number of required power domains for QXP is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM). Additionally, two extra power domains may be required in the case of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes using the "-hifi4" compatibles these PDs are optional, while for nodes using the "-dsp" compatibles these are mandatory. These changes reflect all of this information. Signed-off-by: Laurentiu Mihalcea --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++---- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index 9af40da5688e..e2f016af1048 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -51,8 +51,6 @@ properties: description: List of phandle and PM domain specifier as documented in Documentation/devicetree/bindings/power/power_domain.txt - minItems: 1 - maxItems: 4 mboxes: description: @@ -97,16 +95,55 @@ allOf: properties: compatible: contains: - enum: - - fsl,imx8qxp-dsp - - fsl,imx8qm-dsp - - fsl,imx8qxp-hifi4 - - fsl,imx8qm-hifi4 + const: fsl,imx8qxp-hifi4 then: properties: power-domains: - minItems: 4 - else: + maxItems: 3 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qxp-dsp + then: + properties: + power-domains: + minItems: 3 + maxItems: 3 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qm-dsp + then: + properties: + power-domains: + minItems: 5 + maxItems: 5 + + - if: + properties: + compatible: + contains: + const: fsl,imx8qm-hifi4 + then: + properties: + power-domains: + minItems: 3 + maxItems: 5 + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mp-dsp + - fsl,imx8mp-hifi4 + - fsl,imx8ulp-dsp + - fsl,imx8ulp-hifi4 + then: properties: power-domains: maxItems: 1 @@ -157,10 +194,9 @@ examples: <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd IMX_SC_R_MU_13A>, - <&pd IMX_SC_R_MU_13B>, - <&pd IMX_SC_R_DSP>, - <&pd IMX_SC_R_DSP_RAM>; + power-domains = <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_IRQSTR_DSP>, + <&pd IMX_SC_R_MU_2A>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; memory-region = <&dsp_reserved>;