| Message ID | 20240926032821.4171466-4-Delphine_CC_Chiu@wiwynn.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add I2C mux on BUS 14 for yosemite4 | expand |
On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Change the address of Fan IC: Max31790 on fan boards according to > schematic. > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++------------ > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 430c28bdd314..a7e51725c595 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -496,10 +496,8 @@ adc@1f { > }; > > pwm@20{ > - compatible = "max31790"; > + compatible = "maxim,max31790"; This isn't changing the address, it's fixing the compatible string. Please make this a separate patch with an appropriate Fixes: tag. > reg = <0x20>; > - #address-cells = <1>; > - #size-cells = <0>; Maybe put this in the same patch as the compatible fix though, if it's correct. > }; > > gpio@22{ > @@ -509,11 +507,9 @@ gpio@22{ > #gpio-cells = <2>; > }; > > - pwm@23{ > - compatible = "max31790"; > - reg = <0x23>; > - #address-cells = <1>; > - #size-cells = <0>; > + pwm@2f{ > + compatible = "maxim,max31790"; > + reg = <0x2f>; > }; > > adc@33 { > @@ -539,10 +535,8 @@ adc@1f { > }; > > pwm@20{ > - compatible = "max31790"; > + compatible = "maxim,max31790"; > reg = <0x20>; > - #address-cells = <1>; > - #size-cells = <0>; As above for this diff hunk too. Andrew > }; > > gpio@22{ > @@ -552,11 +546,9 @@ gpio@22{ > #gpio-cells = <2>; > }; > > - pwm@23{ > - compatible = "max31790"; > - reg = <0x23>; > - #address-cells = <1>; > - #size-cells = <0>; > + pwm@2f{ > + compatible = "maxim,max31790"; > + reg = <0x2f>; > }; > > adc@33 {
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 430c28bdd314..a7e51725c595 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -496,10 +496,8 @@ adc@1f { }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ @@ -509,11 +507,9 @@ gpio@22{ #gpio-cells = <2>; }; - pwm@23{ - compatible = "max31790"; - reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; + pwm@2f{ + compatible = "maxim,max31790"; + reg = <0x2f>; }; adc@33 { @@ -539,10 +535,8 @@ adc@1f { }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ @@ -552,11 +546,9 @@ gpio@22{ #gpio-cells = <2>; }; - pwm@23{ - compatible = "max31790"; - reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; + pwm@2f{ + compatible = "maxim,max31790"; + reg = <0x2f>; }; adc@33 {