From patchwork Mon Sep 30 12:04:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13816235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4835ACF6499 for ; Mon, 30 Sep 2024 12:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZtS18Z/ph+22OpFMjBj6PDOp8BDjMiQU1mRrp+tqPao=; b=hWJEJBqFTmBS7QIw14CwKczpVW JVxswAqymclg0pvefHqF/6cp7SqUpN9qZSjBXqU5EgiVgunGoBXYYerPF0sI+IYyQvo+eF5D/aDBj jfOOU8m/E3S7b9+zAnbr88v4DDdvISkmq7kZoAwhVFSNQ2ue5hoKXF7sK+ISDEr81tjfscBbfsBrF XjqUdp8egy5BmOdAkSRNCkRYLX1c82ao3UBEVetpnOWijS5rqSM/nLziVL672C5sZm4HJTR12Z3UI Cl8bO9N/htPOyS6bADbBBz9KdIaK5yIsjkIKn2WdbKxwWE3904Ar53rMf2nBuhMccMPaVvFAu/O68 9hxP0kNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svFcD-0000000H4Su-3BsH; Mon, 30 Sep 2024 12:35:01 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svF9B-0000000GwYf-3Zg4 for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2024 12:05:03 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-7a99e4417c3so373727385a.1 for ; Mon, 30 Sep 2024 05:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727697900; x=1728302700; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZtS18Z/ph+22OpFMjBj6PDOp8BDjMiQU1mRrp+tqPao=; b=ii1Mv7UPn9TA+TTX2GDm7CMgjiR72+Au2lxn87L9JVR8osDy+PVUtFyeODX7RGA2bs DoUcTGz+1gRbt8Wf0ZXOS3KfH4jNdTQxZO+rrqiwcJlMp6XkFD0Swz/SGSWKHPuEGIUI b41qLRAQ3299hdp380PSRNmATrhKfIESMnDOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727697900; x=1728302700; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZtS18Z/ph+22OpFMjBj6PDOp8BDjMiQU1mRrp+tqPao=; b=c06qJE9J0aMFdTr4dzkK3NXo/k8qljW6j/pHQfaOIdgJ8aFubyOpleX/J23WXMTiI5 TyyAqlUvpIIpsBwH2UlbNLL+lJ9g4WH4zB2jh+3r2Ad6ESarme2Eu22BKrHuUSRxIjpY diFop4HKWkATIhF+aMh063eCptijzV/tpA/7ZyCON1u8k1pgwZuLk5GQB4V3gdwiM2os O90ZcUopon5XeCaq5n2zECJSdQavKipvI53N/07cEbKs78YBdHt83D7vNk1prApsDCND vBRiYZnpGC3WM6Xj7JKJOKGMtcRQX03vdjNU1t7kgTwAoeALIrX40bAcPzN1LVaOk/cV Wf2g== X-Forwarded-Encrypted: i=1; AJvYcCU0Td4XBOAMxyqFdPD7YwqeldeFfgVX4ctdfTBpFaogOuCzPXKoAVlg4y5+u1h136OlD4HKrgROB701qk74iekE@lists.infradead.org X-Gm-Message-State: AOJu0YwhInVnt9uYHc9kMgsMdRoOquYk7H1UXEY/l3wscRtZCjBUk9w/ zj0NvInqKB8GOPZvhD9yzCTKEDKA0qF+1jitHUeJ38xwU/m07DJVUj0FRDCfag== X-Google-Smtp-Source: AGHT+IHa6kByUW3tXKJTo1om4uBb1NLh+sbjdquYal1McTRlR2Y5X69QcY3HAZ4VU5M0CeLNOC2NrA== X-Received: by 2002:a05:6214:448c:b0:6c4:6217:da9c with SMTP id 6a1803df08f44-6cb3b5da202mr213240066d6.17.1727697900493; Mon, 30 Sep 2024 05:05:00 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b694369sm38822536d6.144.2024.09.30.05.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 05:04:59 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 30 Sep 2024 12:04:23 +0000 Subject: [PATCH 28/45] media: b2c2: Use string_choices helpers MIME-Version: 1.0 Message-Id: <20240930-cocci-opportunity-v1-28-81e137456ce0@chromium.org> References: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> In-Reply-To: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> To: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil , Mike Isely , Olli Salonen , Maxim Levitsky , Sean Young , Sergey Kozlov , Abylay Ospan , Jemma Denson , Patrick Boettcher , Ming Qian , Zhou Peng , Andy Walls , Laurent Pinchart , Michal Simek , Jean-Christophe Trotin , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Eddie James , Joel Stanley , Andrew Jeffery , Hans Verkuil , Tomasz Figa , Marek Szyprowski , Tim Harvey , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org, Ricardo Ribalda X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_050502_053870_4F2D7D44 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The following cocci warnings are fixed: drivers/media/common/b2c2/flexcop-hw-filter.c:119:20-25: opportunity for str_on_off(onoff) drivers/media/common/b2c2/flexcop-hw-filter.c:12:35-40: opportunity for str_on_off(onoff) Signed-off-by: Ricardo Ribalda --- drivers/media/common/b2c2/flexcop-hw-filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/common/b2c2/flexcop-hw-filter.c b/drivers/media/common/b2c2/flexcop-hw-filter.c index c5a3345c99e9..d64a03452e22 100644 --- a/drivers/media/common/b2c2/flexcop-hw-filter.c +++ b/drivers/media/common/b2c2/flexcop-hw-filter.c @@ -9,7 +9,7 @@ static void flexcop_rcv_data_ctrl(struct flexcop_device *fc, int onoff) { flexcop_set_ibi_value(ctrl_208, Rcv_Data_sig, onoff); - deb_ts("rcv_data is now: '%s'\n", onoff ? "on" : "off"); + deb_ts("rcv_data is now: '%s'\n", str_on_off(onoff)); } void flexcop_smc_ctrl(struct flexcop_device *fc, int onoff) @@ -116,7 +116,7 @@ static void flexcop_pid_control(struct flexcop_device *fc, return; deb_ts("setting pid: %5d %04x at index %d '%s'\n", - pid, pid, index, onoff ? "on" : "off"); + pid, pid, index, str_on_off(onoff)); /* First 6 can be buggy - skip over them if option set */ if (fc->skip_6_hw_pid_filter)