diff mbox series

ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description

Message ID 20241005125824.2037222-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description | expand

Commit Message

Fabio Estevam Oct. 5, 2024, 12:58 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Per fixed-clock.yaml, it is not correct to pass unit address and
reg to represent 'fixed-clock'.

Remove it to fix the following dt-schema warning:

clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'

Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Lothar Waßmann Oct. 8, 2024, 6:15 a.m. UTC | #1
Hi,

> From: Fabio Estevam <festevam@denx.de>
> 
> Per fixed-clock.yaml, it is not correct to pass unit address and
> reg to represent 'fixed-clock'.
> 
> Remove it to fix the following dt-schema warning:
> 
> clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Lothar Waßmann <LW@KARO-electronics.de>

> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> index 5a194f4c0cb9..2fa37d1b16cc 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> @@ -70,9 +70,8 @@ clocks {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		mclk: clock@0 {
> +		mclk: clock {
>  			compatible = "fixed-clock";
> -			reg = <0>;
>  			#clock-cells = <0>;
>  			clock-frequency = <26000000>;
>  		};

Lothar Waßmann
Shawn Guo Oct. 21, 2024, 9:38 a.m. UTC | #2
On Sat, Oct 05, 2024 at 09:58:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fixed-clock.yaml, it is not correct to pass unit address and
> reg to represent 'fixed-clock'.
> 
> Remove it to fix the following dt-schema warning:
> 
> clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
index 5a194f4c0cb9..2fa37d1b16cc 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
@@ -70,9 +70,8 @@  clocks {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		mclk: clock@0 {
+		mclk: clock {
 			compatible = "fixed-clock";
-			reg = <0>;
 			#clock-cells = <0>;
 			clock-frequency = <26000000>;
 		};