From patchwork Mon Oct 7 10:28:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13824459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF001CFB43F for ; Mon, 7 Oct 2024 11:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eVypFZndkb1hDBUGAh8t09mRCyK4drfE9GWmDKb6pno=; b=z+dJ37YFb/PPVRYiB8k8UMGKOl C+ZfdPXr3tYBxjIhtl+kWbop1x3DghwV/tRiIS77tIFBXx28TkoDnXtKuGdxFjAs5JWEgBssYvaCB 9gAnDlhVpWdxuBtQl3SJpkY5YA4E6hJIwN49gPgIcXx3EGqs3d1WDoyliywBzCpKrCF9jTNcxZERS TZpHrarCIL/KsiGoJTHtLt5705bwt0fsTY0QAO9avMqoHtv4dXesiqwtQRBFm/bZARsJ5J84GxHvt pwHsAYxQLxHuTRYAN6Y4NFP6NRgzmFwOAu7qVieIGKjFE78z3OIb8bObqvO3SHd3q1Wl/OxinNp02 UfGuahXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxlWD-000000028Mr-24Z4; Mon, 07 Oct 2024 11:03:13 +0000 Received: from out-181.mta0.migadu.com ([91.218.175.181]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxlRO-000000027BQ-2AtU for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 10:58:16 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728298692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVypFZndkb1hDBUGAh8t09mRCyK4drfE9GWmDKb6pno=; b=Zm6I7VlQmDUwlKb/YjknRT4RT1FEJSf4kD6G4DBU0o/l4mOu6cy8i8YOP5jp3PAlwsijoY EaS0x+Zgn9pIrvsDuAzZA3YPS+WNzksjS9H+bGO3FOZ3gigogjel+8/EYPtzOla+ke1VnH ikJ597MLpohaKorPEkdUCGooDcGHCUaIv1+ABVaYKOUttLsDauIAkxJh0BUDqo9f3oIwHA lM8pu+sMPWcHm4+enw/3K4eCBdc9IZjUed5gU6lcSVavpvMOr9m5xb8s61RRygQHXgoH5b 0b2kOz7urxloIK5XGrzRtH8hYKpHbOL8M2tF4IlL/W6Sm/mfij30z46h7D4x4A== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 Date: Mon, 7 Oct 2024 12:28:17 +0200 Message-ID: <20241007105657.6203-4-didi.debian@cknow.org> In-Reply-To: <20241007105657.6203-2-didi.debian@cknow.org> References: <20241007105657.6203-2-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_035814_736175_9A034FF3 X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts property of the hdmi node has 'maxItems: 1', so the hdmi node in rk3328.dtsi having 2 is incorrect. Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1 page 16 and 17 define the following hdmi related interrupts: - 67 hdmi_intr - 103 hdmi_intr_wakeup The difference of 32 is due to a different base used in the TRM. The RK3399 (which uses the same binding) has '23: hdmi_irq' and '24: hdmi_wakeup_irq' according to its TRM (page 19). The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi' according to page 17 of its TRM. In both cases the non-wakeup IRQ was used, so use that too for rk3328. Helped-by: Heiko Stuebner Signed-off-by: Diederik de Haas --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b5cbe7cab10b..0597de415fe0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -754,8 +754,7 @@ hdmi: hdmi@ff3c0000 { compatible = "rockchip,rk3328-dw-hdmi"; reg = <0x0 0xff3c0000 0x0 0x20000>; reg-io-width = <4>; - interrupts = , - ; + interrupts = ; clocks = <&cru PCLK_HDMI>, <&cru SCLK_HDMI_SFC>, <&cru SCLK_RTC32K>;