| Message ID | 20241008-csi_dcmipp_mp25-v1-12-e3fd0ed54b31@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: stm32: introduction of CSI / DCMIPP for STM32MP25 | expand |
On Tue, Oct 08, 2024 at 01:18:14PM +0200, Alain Volmat wrote: > Addition of the stm32mp25 compatible for the DCMIPP. "Add" See submitting patches. > The stm32mp25 distinguish with the stm32mp13 by the fact that: > - supports also csi inputs in addition to parallel inputs > - requires an addition csi clock to be present > > The commit also adds access-controllers, an optional property that "Add", see submitting patches. > allows a peripheral to refer to one or more domain access controller(s). > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > .../devicetree/bindings/media/st,stm32-dcmipp.yaml | 53 +++++++++++++++++++--- > 1 file changed, 47 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > index 87731f3ce7bd..bda28fef0b78 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > @@ -10,9 +10,40 @@ maintainers: > - Hugues Fruchet <hugues.fruchet@foss.st.com> > - Alain Volmat <alain.volmat@foss.st.com> > > +allOf: Please put allOf: like in example schema, so after required:. > + - if: > + properties: > + compatible: > + contains: > + enum: Best regards, Krzysztof
Hi Krzysztof, On Tue, Oct 08, 2024 at 03:41:59PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 08, 2024 at 01:18:14PM +0200, Alain Volmat wrote: > > Addition of the stm32mp25 compatible for the DCMIPP. > > "Add" > See submitting patches. Commit message corrected in the v2. > > > The stm32mp25 distinguish with the stm32mp13 by the fact that: > > - supports also csi inputs in addition to parallel inputs > > - requires an addition csi clock to be present > > > > The commit also adds access-controllers, an optional property that > > "Add", see submitting patches. Here as well. > > > allows a peripheral to refer to one or more domain access controller(s). > > > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > > --- > > .../devicetree/bindings/media/st,stm32-dcmipp.yaml | 53 +++++++++++++++++++--- > > 1 file changed, 47 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > index 87731f3ce7bd..bda28fef0b78 100644 > > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml > > @@ -10,9 +10,40 @@ maintainers: > > - Hugues Fruchet <hugues.fruchet@foss.st.com> > > - Alain Volmat <alain.volmat@foss.st.com> > > > > +allOf: > > Please put allOf: like in example schema, so after required:. Done in v2. > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml index 87731f3ce7bd..bda28fef0b78 100644 --- a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml @@ -10,9 +10,40 @@ maintainers: - Hugues Fruchet <hugues.fruchet@foss.st.com> - Alain Volmat <alain.volmat@foss.st.com> +allOf: + - if: + properties: + compatible: + contains: + enum: + - st,stm32mp13-dcmipp + then: + properties: + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + + port: + properties: + endpoint: + properties: + bus-type: + enum: [5, 6] + else: + properties: + clocks: + minItems: 2 + + clock-names: + minItems: 2 + properties: compatible: - const: st,stm32mp13-dcmipp + enum: + - st,stm32mp13-dcmipp + - st,stm32mp25-dcmipp reg: maxItems: 1 @@ -21,11 +52,24 @@ properties: maxItems: 1 clocks: - maxItems: 1 + items: + - description: bus clock + - description: csi clock + minItems: 1 + + clock-names: + items: + - const: kclk + - const: mclk + minItems: 1 resets: maxItems: 1 + access-controllers: + minItems: 1 + maxItems: 2 + port: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false @@ -39,7 +83,7 @@ properties: properties: bus-type: - enum: [5, 6] + enum: [4, 5, 6] default: 5 bus-width: @@ -50,9 +94,6 @@ properties: hsync-active: true vsync-active: true - required: - - pclk-sample - required: - compatible - reg
Addition of the stm32mp25 compatible for the DCMIPP. The stm32mp25 distinguish with the stm32mp13 by the fact that: - supports also csi inputs in addition to parallel inputs - requires an addition csi clock to be present The commit also adds access-controllers, an optional property that allows a peripheral to refer to one or more domain access controller(s). Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- .../devicetree/bindings/media/st,stm32-dcmipp.yaml | 53 +++++++++++++++++++--- 1 file changed, 47 insertions(+), 6 deletions(-)