From patchwork Tue Oct 8 11:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13826369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C956CEF15A for ; Tue, 8 Oct 2024 11:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WyJ7Z5sCax3H+U1/xrEos8F1I+KiAxNN6XMVHBXY4YM=; b=Q6vyfUA9Lftmhap5f1Rc3aOM/r uz6pzF908mpRnJ1JCng/rUKHS62sTeOGDWa6irzF4eqnIcrtxNy5erVI8Ru1jrww3QQGOf3oL++IN njL0IPvyh9t5eGX1RkrmaLZLC+WUMcFPfNK4C33OMZplIMtEDVxeS282+sl7jJCOOtp6RrbtUY0AB nzsFKRanQQMzBr0hk4rlnXor2uLpITaMjnlGZI4ib1O0smdFdZp+p1RiQWeSD2JNBG7B+FRafCZQx 7TSqbUky29uqgeedtjWIhEB3dCgPy3WEAoezrF+FAiOeTnUxOxQFQ+dlBvbKNhBxlIgYCkeTtJmdo 3szbDMFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy8jU-00000005hNF-0XbR; Tue, 08 Oct 2024 11:50:28 +0000 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy8U0-00000005dzI-2vYH for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 11:34:30 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728387265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyJ7Z5sCax3H+U1/xrEos8F1I+KiAxNN6XMVHBXY4YM=; b=GEDW03eJ3ggGaiWlnJZzvdHe2KnXWLCVhZE2Ly0QfRU60p6HxGcEy3sEz4zYCVsVYk6pkO /R8n4MlSnb76WoQKEvLP9xwV56S8m4VS99AYVRrNVFtYlh48IosF7o8CH3MYFOociduR0M nKuiqlzoCSvj8E61OY0eWKk59BS/sDAGg+cxFDoRJR4K5WoVWAdJEDTJV3sYdEb7FinaZ9 IbCVmafzbuuz7c+ofPoOVTVtLoxeNqFBvlkg9BSTSjPTExL+BfV2XrsK0qi1Bq9X8xIkRu 0yE5ztEWRZnD1dmGEtBrO5wxd5qhs8mKU5xl39PJqqdYfC7Zumw1NU03wbLeWA== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , Michael Riesch , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 Date: Tue, 8 Oct 2024 13:15:37 +0200 Message-ID: <20241008113344.23957-3-didi.debian@cknow.org> In-Reply-To: <20241008113344.23957-1-didi.debian@cknow.org> References: <20241008113344.23957-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_043428_890681_3149CBF1 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts property of the hdmi node has 'maxItems: 1', so the hdmi node in rk3328.dtsi having 2 is incorrect. Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1 page 16 and 17 define the following hdmi related interrupts: - 67 hdmi_intr - 103 hdmi_intr_wakeup The difference of 32 is due to a different base used in the TRM. The RK3399 (which uses the same binding) has '23: hdmi_irq' and '24: hdmi_wakeup_irq' according to its TRM (page 19). The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi' according to page 17 of its TRM. In both cases the non-wakeup IRQ was used, so use that too for rk3328. Helped-by: Heiko Stuebner Fixes: 725e351c265a ("arm64: dts: rockchip: add rk3328 display nodes") Signed-off-by: Diederik de Haas --- changes in v2: - Added Fixes tag arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b5cbe7cab10b..0597de415fe0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -754,8 +754,7 @@ hdmi: hdmi@ff3c0000 { compatible = "rockchip,rk3328-dw-hdmi"; reg = <0x0 0xff3c0000 0x0 0x20000>; reg-io-width = <4>; - interrupts = , - ; + interrupts = ; clocks = <&cru PCLK_HDMI>, <&cru SCLK_HDMI_SFC>, <&cru SCLK_RTC32K>;