From patchwork Tue Oct 8 17:27:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13826763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D1FDCEFC35 for ; Tue, 8 Oct 2024 17:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rPo7yuMQUseeUfF5xw8F+I5twxmXEKkNF8gXD40MNsk=; b=pirDQTWjdiAVBg17GNVduWrisq OLzCC/recY8pKkr77U9f9aMEnyKURbnh153WqQ9WOVvP6lTAbvTwQENxh5n2znmM6WWWQKZe9wZUa v4D53RZcHUTPlGt3VCWGoQ9XY2ei2Dkv8mM/ylI1cQ5ZENpbAN3ltQO3WBbBd7f4ZB7i2ywjc2Vem +j0cBDrEnNORWDGogJAdHFZ9nqqGo9KryAIilJ8isFAdt8HHxiuVdjnJ+qpGHGWC4shOELs+ShofI z6gL1LphV34h5nAgQhjFTAiN8G8yYLfxT/l4k2StwVgMTTw3T6/0EI62Z831FZLIdAUMZinG8Ra3l j9cPXPwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syECV-00000006g6A-1hNU; Tue, 08 Oct 2024 17:40:47 +0000 Received: from mgamail.intel.com ([192.198.163.17]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syE6h-00000006eqi-2QPp for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 17:34:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728408887; x=1759944887; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M41KJpPTgtZC1kvfB0ok8XtGl6qr+rtNSYSFho5CTIc=; b=FXAZjBZZ1KHv4VCWAQPyutEIbQFBcg1Dp4UmGK3bjuFPN3iEiEbF+WSF wllj4g9sbhkTW+nIf473LhoI96rkgWYNbb+1G5GRuisRZwVnuai/5YC4D FMUgchTijK6mBWuDJm6ZoyD0YHyOiBN6BG+QKmU495ocxnZg6424fTN+K jBtd6+L86gujYyE/Azk7WNZt+DlpVeXmRjSxuYfNbgc/9trUBR7ImBqD1 54VzHOED4LTgCrG8MtLIYfg2ZW8LMwRH84vkQXpQiSOOfE01xYzlUZZdZ ot/RbpTSdRprA48UpEp8wNAkAJJ/QRffCSgMW8T9LhNYkUgVkR+xqytNK Q==; X-CSE-ConnectionGUID: uqF9FbtJTluTaBO9FxUD9g== X-CSE-MsgGUID: GYzSsKMlTPemzTExpjBdTw== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27510137" X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="27510137" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 10:34:11 -0700 X-CSE-ConnectionGUID: t8RFXAV7Sqyt6MzY8WQMWg== X-CSE-MsgGUID: zeSFKaSOS52rpb6wYKZVXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="106677517" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa001.fm.intel.com with ESMTP; 08 Oct 2024 10:34:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AEE59347; Tue, 08 Oct 2024 20:34:06 +0300 (EEST) From: Andy Shevchenko To: Vinod Koul , Paul Cercueil , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andy Shevchenko Subject: [PATCH v2 3/4] dmaengine: Add a comment on why it's okay when kasprintf() fails Date: Tue, 8 Oct 2024 20:27:46 +0300 Message-ID: <20241008173351.2246796-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20241008173351.2246796-1-andriy.shevchenko@linux.intel.com> References: <20241008173351.2246796-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_103447_661480_94A9F089 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a comment in dma_request_chan() to clarify kasprintf() missing return value check and it is correct functionality. Signed-off-by: Andy Shevchenko --- drivers/dma/dmaengine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index c1357d7f3dc6..dd4224d90f07 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -854,8 +854,8 @@ struct dma_chan *dma_request_chan(struct device *dev, const char *name) found: #ifdef CONFIG_DEBUG_FS - chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev), - name); + chan->dbg_client_name = kasprintf(GFP_KERNEL, "%s:%s", dev_name(dev), name); + /* No functional issue if it fails, users are supposed to test before use */ #endif chan->name = kasprintf(GFP_KERNEL, "dma:%s", name);