| Message ID | 20241008203940.2573684-8-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > There are two LEDs on the board, power and user events. > Currently both are assigned undocumented IR(-remote) > triggers that are probably only part of the vendor-kernel. > > To make dtbs check happier, assign the power-led to a generic > default-on trigger and the user led to the documented rc-feedback > trigger that should mostly match its current usage. > > Fixes: 4403e1237be3 ("arm64: dts: rockchip: Add devicetree for board > roc-rk3308-cc") > Cc: Andy Yan <andy.yan@rock-chips.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Looking rather meh to me, but I guess that's as good as it gets. Thanks for the patch. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > index 9232357f4fec..d9e191ad1d77 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > @@ -36,14 +36,14 @@ leds { > > power_led: led-0 { > label = "firefly:red:power"; > - linux,default-trigger = "ir-power-click"; > + linux,default-trigger = "default-on"; > default-state = "on"; > gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; > }; > > user_led: led-1 { > label = "firefly:blue:user"; > - linux,default-trigger = "ir-user-click"; > + linux,default-trigger = "rc-feedback"; > default-state = "off"; > gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_HIGH>; > };
diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts index 9232357f4fec..d9e191ad1d77 100644 --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts @@ -36,14 +36,14 @@ leds { power_led: led-0 { label = "firefly:red:power"; - linux,default-trigger = "ir-power-click"; + linux,default-trigger = "default-on"; default-state = "on"; gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; }; user_led: led-1 { label = "firefly:blue:user"; - linux,default-trigger = "ir-user-click"; + linux,default-trigger = "rc-feedback"; default-state = "off"; gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_HIGH>; };
There are two LEDs on the board, power and user events. Currently both are assigned undocumented IR(-remote) triggers that are probably only part of the vendor-kernel. To make dtbs check happier, assign the power-led to a generic default-on trigger and the user led to the documented rc-feedback trigger that should mostly match its current usage. Fixes: 4403e1237be3 ("arm64: dts: rockchip: Add devicetree for board roc-rk3308-cc") Cc: Andy Yan <andy.yan@rock-chips.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)