| Message ID | 20241010205237.1245318-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func() | expand |
On Thu, Oct 10, 2024 at 10:52 PM Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > 'new_map' is allocated using devm_* which takes care of freeing the > allocated data on device removal, call to > > .dt_free_map = pinconf_generic_dt_free_map > > double frees the map as pinconf_generic_dt_free_map() calls > pinctrl_utils_free_map(). > > Fix this by using kcalloc() instead of auto-managed devm_kcalloc(). > > Cc: stable@vger.kernel.org > Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver") > Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/nuvoton/pinctrl-ma35.c b/drivers/pinctrl/nuvoton/pinctrl-ma35.c index 1fa00a23534a..59c4e7c6cdde 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-ma35.c +++ b/drivers/pinctrl/nuvoton/pinctrl-ma35.c @@ -218,7 +218,7 @@ static int ma35_pinctrl_dt_node_to_map_func(struct pinctrl_dev *pctldev, } map_num += grp->npins; - new_map = devm_kcalloc(pctldev->dev, map_num, sizeof(*new_map), GFP_KERNEL); + new_map = kcalloc(map_num, sizeof(*new_map), GFP_KERNEL); if (!new_map) return -ENOMEM;
'new_map' is allocated using devm_* which takes care of freeing the allocated data on device removal, call to .dt_free_map = pinconf_generic_dt_free_map double frees the map as pinconf_generic_dt_free_map() calls pinctrl_utils_free_map(). Fix this by using kcalloc() instead of auto-managed devm_kcalloc(). Cc: stable@vger.kernel.org Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver") Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- This is based on static analysis and reading code, only compile tested. Added the stable tag as the commit in Fixes is also in 6.11.y --- drivers/pinctrl/nuvoton/pinctrl-ma35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)