| Message ID | 20241014061256.21858-2-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: vchiq_arm: Two memory leak fixes | expand |
On Mon, Oct 14, 2024 at 11:42:55AM +0530, Umang Jain wrote: > The struct vchiq_arm_state 'platform_state' is currently allocated > dynamically using kzalloc(). Unfortunately, it is never freed and is > subjected to memory leaks in the error handling paths of the probe() > function. > > To address the issue, use device resource management helper > devm_kzalloc(), to ensure cleanup after its allocation. > > Cc: stable@vger.kernel.org > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- Checkpatch warns that: WARNING: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag? (I'm the person who created this checkpatch warning.) Fixes tags aren't just for regressions they're for any bug fixes. So the Fixes tag here should point to when the driver was introduced. Even if the Fixes tag points to the first git commit, it's useful information so, please, always include it. regards, dan carpenter
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 29e78700463f..146442a3552c 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -285,7 +285,7 @@ vchiq_platform_init_state(struct vchiq_state *state) { struct vchiq_arm_state *platform_state; - platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL); + platform_state = devm_kzalloc(state->dev, sizeof(*platform_state), GFP_KERNEL); if (!platform_state) return -ENOMEM;
The struct vchiq_arm_state 'platform_state' is currently allocated dynamically using kzalloc(). Unfortunately, it is never freed and is subjected to memory leaks in the error handling paths of the probe() function. To address the issue, use device resource management helper devm_kzalloc(), to ensure cleanup after its allocation. Cc: stable@vger.kernel.org Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)