From patchwork Tue Oct 15 07:58:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13835841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9639ACFC273 for ; Tue, 15 Oct 2024 08:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Serkv7hNFtY4D3bnyXYbdSB08g8blJhZd6xiLIbNR0k=; b=cmRaZYvcjZVl1cV1IzFjwN5Qg2 yRIwAXbxmVSqMxv4zKpruB+ruJC0b3+1WSJQR+z4/rf03bPXFUcxJZl8l0BfuaeNGsUfH7Sfh5/+y Q0tmGBakiPal9O/w4g7a8+zJYZ58mIw7EMapyAn9q6PBp8R5ZaHpeCRDj7yn7Zq5EuQCbzOejltCD ckeb2P0HePqfA+Vwf8NzssgsyNjEfOvc+rcyP8Ma/91cTaObXbPEqdb9TU6wqniruvkLEgicdxAeL CSgyACxC719V1IrFSKQ781z/kl4spd8l2Ml/DRjK3MYbnSe/9jjXy4l+JsTebVbgYEFbBNFxi4/4L ecG0l8uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0cbm-00000007Rqm-3Y8u; Tue, 15 Oct 2024 08:08:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0cRs-00000007Pta-1CbL; Tue, 15 Oct 2024 07:58:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2DFF35C4BBC; Tue, 15 Oct 2024 07:58:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF396C4CEC7; Tue, 15 Oct 2024 07:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728979110; bh=rvW2wHCfM1t7JqZTRgngSugH0a6MrEwATljOLSw10Dg=; h=From:Date:Subject:To:Cc:From; b=lSCE9mic9AaeJuK5pOaJwQwSfeqTB65pEIcACMfZsZXJPl91NWQ97Nv8e8ULAk0jy MiHpa0H/7O7ItH5LXOGzBFs2KXkBPWR0HogEdHID3g0y893US0490Dv4Ap8V//zr6f /c5t+FLAGbW+F3KorjZ6Vq/oJvqYkpfHGX9xbabmZ+3dSS5GXPkccTyqkuAPirR4P6 BwWTFo+w/Y8+h/W3Azp8WCDA4ztygcb0+TtSLXOMs1+jD2kh/Cw701b9qvYISzi2IY /fmHqD4QNKT4iekXzTAP7Ii2fd/rFAJKUb6/5YtsbUYPZJfKxs5d91oIzNk2OJWJyV BS4RlL69+lZIg== From: Lorenzo Bianconi Date: Tue, 15 Oct 2024 09:58:09 +0200 Subject: [PATCH net-next] net: airoha: Fix typo in REG_CDM2_FWD_CFG configuration MIME-Version: 1.0 Message-Id: <20241015-airoha-eth-cdm2-fixes-v1-1-9dc6993286c3@kernel.org> X-B4-Tracking: v=1; b=H4sIAJAgDmcC/x3LPQqAMAxA4atIZgNp7GC9ijiUNtoM/tCKCOLdL Y4fj/dAkaxSYGgeyHJp0X2rMG0DIfltEdRYDUxsDRmLXvOePMqZMMSVcdZbCjqOjlxHPZOF+h5 Z/lDXcXrfD4Wme5lnAAAA X-Change-ID: 20241014-airoha-eth-cdm2-fixes-92d909308204 To: Felix Fietkau , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno Cc: lorenzo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, ChihWei Cheng X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_005832_484037_7DDFFCC0 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typo in airoha_fe_init routine configuring CDM2_OAM_QSEL_MASK field of REG_CDM2_FWD_CFG register. This bug is not introducing any user visible problem since Frame Engine CDM2 port is used just by the second QDMA block and we currently enable just QDMA1 block connected to the MT7530 dsa switch via CDM1 port. Introduced by commit 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") Reported-by: ChihWei Cheng Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman --- drivers/net/ethernet/mediatek/airoha_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: 60b4d49b9621db4b000c9065dd6457c9a0eda80b change-id: 20241014-airoha-eth-cdm2-fixes-92d909308204 Best regards, diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c index e037f725f6d3505a8b91815ae26322f5d1b8590c..45665a5b14f5c646d23aaf4830e55a118e9f1a8a 100644 --- a/drivers/net/ethernet/mediatek/airoha_eth.c +++ b/drivers/net/ethernet/mediatek/airoha_eth.c @@ -1371,7 +1371,8 @@ static int airoha_fe_init(struct airoha_eth *eth) airoha_fe_set(eth, REG_GDM_MISC_CFG, GDM2_RDM_ACK_WAIT_PREF_MASK | GDM2_CHN_VLD_MODE_MASK); - airoha_fe_rmw(eth, REG_CDM2_FWD_CFG, CDM2_OAM_QSEL_MASK, 15); + airoha_fe_rmw(eth, REG_CDM2_FWD_CFG, CDM2_OAM_QSEL_MASK, + FIELD_PREP(CDM2_OAM_QSEL_MASK, 15)); /* init fragment and assemble Force Port */ /* NPU Core-3, NPU Bridge Channel-3 */