From patchwork Wed Oct 16 21:01:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilkka Koskinen X-Patchwork-Id: 13838951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F9C8D2F7C0 for ; Wed, 16 Oct 2024 21:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=pN9txQLKthGoeSTXu2dItqRQgavVQjKgc2fh5tvggGM=; b=E87ccQ9/lnnnzZ5y15kS0OrERt GqFTBqra4RMr/pCQFduTLUdFNYaLlfZ6eQKxLOSKCrmsV5XW33F0RluSwMd5orHKd/jWOQR/SgUTr wWr59xWGrcSKrCiH6YcUHdQ06kXch+l1Cg1rDU2ILH4WYi37pxPuV5vfiSobKHH9LIr7Nfdkp6Vzz h2JzX8hFkNgeFh0SiPBcTuIWx+MqKAD7PCbkVktRFkD9+LqmwsREdoBWde0rBH+WTyi908LwimkBh ZrY0DU1+IfRl0YzwqTHOVRsi+zrkmyrq6nN4sT3AjFIrvGPH3fjH79pr65Kb07uORcyy+g9iY5jbp LKaFgNjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1BBZ-0000000D14w-2pp8; Wed, 16 Oct 2024 21:04:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1BAA-0000000D12O-3Tx4 for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Oct 2024 21:02:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=pN9txQLKthGoeSTXu2dItqRQgavVQjKgc2fh5tvggGM=; b=KsMMHJFWCyYPrSTQr9DCJaCEBw lmBfpp4hMmozVXXp3ZdadU+K2RrsAZCHNPDxbGEFHeeCzKJlzBeEaFVEsh+xyMhgtSbC4AMxZ74fU MslVV7ZRpLGFaRXRZcPIDw+PpNKHieNDPIy8Ky9gDv/xOBcRPAhrleUEDsXPiDvbbTdtVVWFgNHru UY1mjTn0K64Mi2SPipevi6DyBPOZQHx2HYpR5rc3E/S/nWumXZQ95XYGUxLSc5ekabsC1QovmdeC9 LIU7jt8TcFFqavvoLJUG5n2ZEpK0tRTV1zE/XiwkFxqSnPkgEqd7CX2GVRBmVioh3rgzpgyx1M2q/ 57gABYeg==; Received: from mail-northcentralusazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c105::7] helo=CH4PR04CU002.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1BA7-00000006vHU-0ZLN for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 21:02:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=swHvSN4HeMq8IZk/acGmq2AY9fG2ZrtvyTC//8Io73nAQu8oZzJli4zsGikPux6jZOsSIDsxijVcSJy/Z/PDZw0aeKjk6HENNBja89kFf6ypXBRkN+vgKbZ4DOihTGC6khNq4N3CUTCNE+SMCmb6ekP7E0sNGU1Bd2mESWCtU/bAMJMztMCMNAWesobhOFL6O0V0A7AvR5GsBNfvWMyfNCCCyFtwAT0EV49VORQq5iFOvYdznR4LHrMg7GHkXEdyVpSuqg8nnNIUTgCC2ZmX7QkDxKgSnMHriLGkukvpleGqFIbrqCdvpkv2xFv+8h103d6/4lkl79dKm9+ky9vAyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pN9txQLKthGoeSTXu2dItqRQgavVQjKgc2fh5tvggGM=; b=GVAeINN6G7V70ZXZQriPgxr38YnjsBKWhyFfjpUtEsvnYqJ7FuWGOdVNR93rHTcbnwVHjE6w53NEwn4cQaWo97zNEY3scj6wpdm49EyzkkrvbfpAJJtyiN2wTsorpEYdiMoFJKWFXHfv+YKXlM2vY2TJc5nlk6vXzLZKjyzd83u8boWecuDq4YMORmFjKkJ/PGT7q1vdUwBK+vYguukoUm/yLEenaVVJRPLFIV2+2MejjGEGzlE8N4jwBxDUDHlDMIpNa4bQ85TGF+I35geUJ22Ba9FH1ETEq+85GuR5atuTdjo742SdYYwU8hexyeUnAbJl+QAudKknZr+NA9LQOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pN9txQLKthGoeSTXu2dItqRQgavVQjKgc2fh5tvggGM=; b=Gs7uEydO6YXN1ya5zSv6saCkgNZv+XdKmpo1jal7GGmOCB7x8Ag3jt992uOI3HJGn2bqoQTPNPEXjac3QU/dG4QC/hvV3Ok6wpGVgKibbEEf4WufyQxwbLkDFgWKq8N7QBoKcJs0Zixea0WLLvHBUgegTzgGYmkXG8bVq28VD5U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW4PR01MB6228.prod.exchangelabs.com (2603:10b6:303:76::7) by BL3PR01MB6866.prod.exchangelabs.com (2603:10b6:208:351::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.34; Wed, 16 Oct 2024 21:02:14 +0000 Received: from MW4PR01MB6228.prod.exchangelabs.com ([fe80::13ba:df5b:8558:8bba]) by MW4PR01MB6228.prod.exchangelabs.com ([fe80::13ba:df5b:8558:8bba%7]) with mapi id 15.20.7982.033; Wed, 16 Oct 2024 21:02:14 +0000 From: Ilkka Koskinen To: Shuai Xue , Jing Zhang , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ilkka Koskinen Subject: [PATCH] perf/dwc_pcie: Convert the events with mixed case to lowercase Date: Wed, 16 Oct 2024 14:01:36 -0700 Message-Id: <20241016210136.65452-1-ilkka@os.amperecomputing.com> X-Mailer: git-send-email 2.40.1 X-ClientProxiedBy: CY8P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:930:46::16) To MW4PR01MB6228.prod.exchangelabs.com (2603:10b6:303:76::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR01MB6228:EE_|BL3PR01MB6866:EE_ X-MS-Office365-Filtering-Correlation-Id: 74530bce-817d-4499-8f09-08dcee25cf37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 0PnpvWe+b0X7YCiBx/CsN3pJ0kRYrtUUlo/D3/pEumVqJnQCz4b2plqHUmZC4pl3Xcm628jhNCPPzraI/3M4Z5dbLuOIUXklN7XUPl9/oKparEHUzsVEwM5oFGOIZy9q1xO2hKfMq7+SfuhaW5TjducJaPatb6If+LIXcGjProXV0gIvdcW98lkUaqwDyceYIAiwpbTN5CaZXew6cFm2RzD6dg0wulREYLPn4sP8o3kODV1Hb82JCsGXhtiq1qgyDGbZ7y7uFj01XIypR0CW0Pw8LH8NSVh1Q9ubr6faxMV3y/I18VpVFq/H77ljwZNrV8/1N0slFrIgp9fVMU6iMb0N8Qj0hFMeROrB0p+5EANZtDkAo8NA349Z5DNgZmuTdZtIY/mJmS/we4KcCHsNudMJhNRcK9JdTvT18RE7qtv6sFPzGhtjc9I62mWFkKyvCFAvJirM36BNpXYpw62PqeZbZPbgruy20N1wvvj+8Ab8JHmJL15maggC1rJ1N0n3Mnst7PQ18xY+q6NRZCYAVjubUOaCSLgD9AsD7H1Gx/OQ/1+DPWuAn67abn9pYQYGmSBxkmW4PZFli+Ud40FEpSma8BqPmZdcP1bQeEMTjkGE6oWq4U1hEia78DmPE0RwnDXtJUBE4OsvC3bzmxfLj/93XkwuT7OxOK3YLMO902R8BJvGSfBGigiMfC+Pk+dmweAxgAWYqyjUalP65v2zeuZJIa+VVERg098pPBs1y2d6D34crzh/5zpRX4wlSepgQk+np/YkP5kpvDUtdBwRZS0tYWLy6xPFWZaMNIaL9X99giI760bW1O8Xpl3tmBSlBEv6VFzV5Ksbf0yOPlIwlTDqaPhX7j/G0EPAhqtD8ruGLPgIFyJdzFeSjeFQxe2rd5SccbvXaVR8urwJck13rpZIeB9nPkg+s/Wz+f7tvPRz3QoqjEjnCUDH2NGEQShaSwzbS7iJiNf9BRyLpEDSX2N8qd3A8knJIDu2NkU7tVtzkWphdlci2a+duQAf8isDps3DvwuVWFBBE2wnQltiSOy7JzAZXAi4HDFhYjfL0pgXWUiP1JE47jrNFMPqWyZcYTM/DkgTnVQd8rR1+wHjpzESsKU0X1JUgTF5yUklfkQztcb653wpVerSz2o3JZu3ca7cSz/jXEpFKjIip6RT6es2KhOQemBy4G0BWxEtt9Fkgd5mnzLEysFE1B8FJJ9EGe4KO291C5S4UvsBnFX9XenbhMrbQ+bdNzlwQLux3gjdUUV8z3gq4tbGZblvvPq8dC/7tF7zWXh+seQ9cSkdT84wcGAnbMnMztju7Ihhpu3qzGY19hk0AcMVKUzjNfCfOXBEV08vXJiqcMGISUpK8OmLztyCJ6LQfOBEolM6gBc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR01MB6228.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mjCvlymB2H3xdlksuzef6m5IetzErm8rPsE3HOIJaFtUF6gZWKT+qMHk/9HPSJMULBdd2ldIkyVGGkRB+vllpQfEUqHL5R2cFAA+aYwGFdb/JEF/TnIp1CIa/vmTtajSdqvrn7He2Cq4U/2QxLt4YOT0fyXmnXXI0AP80LUPDKRi0Umubcrw87m+YX4zZK3xhUN4htHy80hsc2QrCingGKfQ1x7lJfMyPRJdqSrnhWvmNl2rbCevbI0CN1EteOvt4SbK75FVxkfohau65KMwQtZIlgYV98BlgN/nhQlVkdqWboueAlm00IdJ5R99EFdBowKs/pOkb0CKBnMhwLlF7ja8/6r2KBknvNOr1emiAMEik5B3NBpUwr5MbbY+e6oc6f+bGiKVvL4DhI7XKwzaSYgwElEVO+5tFuh8INVwjgZf+6BT1GrqeES0b3rPV+jKBhT82Qy1rozt7wc7UDXK6jSMb/Uhyd3Di/2rHChtga0n5oVHgfXOCN4P65ZvzaIOoSvANfdFod8dDYv8jeX5MSTJYb2ZeZ8s5f95hvGat3YpxuSYfmgxyp9trKTXvm38RhkUbK9E499CPybDw6OBdPkxJ/HD49FLsd82KuehLczHoFZ2klJrRHht8x8av3FYWMzfDu79IY745wTXtoPXB6cGa16x/Xfxp+js8nNLU2kVwiymSP0uiFaykJqYwQrJFoROD1iURiBfwYXqnrN2GUIbBNKBemMqh77GDHPv/jVUuxy+EZmlXxuf2zxUW/uO5+AV2WSY3GFpNCWpQ/Ma++pMdcnqKMShsSzGOVmxjgu2+UBFHXmYkes09dgdugKXG0FPPRmSarLu9v8aWGMwUHVxDQ9MMJfliTpyNA/hMdarS5ZFoGDFD7oozHPopbTU5uH5OQwcxyhCYJg74PZEvw2U4KnkvkWH6CIxnTfHgbmmv67N7eEJY1GYwwJWXFOJDaRFfkr1n3pZnrm1C4kyyTyOVyoy4zvbTLWd9+lzJUIO+PY/xW+FljIT07/n3/J60EyZFQBYnuvkFvORwEfe0AQ09u/XnxMoOcZ8hLojW7HUuHspZA1SFe/09RKk5fJ6HbOR+DXT6mcdf3Ef+SNBoYorEiaRpuvgjUjaUAV8Ml9hGJLKQBvZalcKUZm/ybLu9XSY0Ctu3Uc0yFRziOsCAa6wmjFlRSYPIkkftdJu/Ep0RB6A2/r5FWZYSsQuacBvrTzDdL6toi9KY86ybY3vAchpfhlQyJqsF1olS1CuCtx3Re+aJQ+JcVmitUg1qZbKjRcBYGjQxTnEi+dpCIqUWdKtzu806DKnKCk09hPrPGVdrQhFT+2UPhWFyVH6XmLtYAQbuYNigKuSKjBJH511UtmWgj9MHy95qvCOOgK82bWgE8MbbylnHobuZxAncGetELD33rxqTvA0uusQWxTz7YAlcResFRZgHlfHs0/uTlDBYk4DOvSo+WjNZxj+Jyt1xkEuzxd+7KgaZyuR9xTwcBnFB40t/zLM4txtA1/YigEZ40JV0OClSAmyZkF4Luw6PYEd9S2hxbO2xWkVmeKwrTiMrK7c6TAm/P5u1tWoCjTcMNxGQYOWtEblwUTzkJj8/a11b458h4b5N7ZOCbnf3W28CDa0l6HQX6LKPq0WD24= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74530bce-817d-4499-8f09-08dcee25cf37 X-MS-Exchange-CrossTenant-AuthSource: MW4PR01MB6228.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 21:02:13.8833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oCkvwhOFABahLiM92Q87001bvIk9/9csqaOYGZPgaaRX3RDPKuHrHKyoLMokpRffjXOTP18XDdiwvdstMLcjNNhgeUMaO0aI8TqvtvA1tOquivzJSdFWQ1o3Ec28vzTK X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6866 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_220231_693121_6C06AEF2 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Group #1 events had both upper and lower case characters in their names. Trying to count such events with perf tool results in an error: $ perf stat -e dwc_rootport_10008/Tx_PCIe_TLP_Data_Payload/ sleep 1 event syntax error: 'dwc_rootport_10008/Tx_PCIe_TLP_Data_Payload/' \___ Bad event or PMU Unable to find PMU or event on a PMU of 'dwc_rootport_10008' event syntax error: '..port_10008/Tx_PCIe_TLP_Data_Payload/' \___ unknown term 'Tx_PCIe_TLP_Data_Payload' for pmu 'dwc_rootport_10008' valid terms: eventid,type,lane,config,config1,config2,config3,name,period,percore,metric-id Run 'perf list' for a list of valid events Usage: perf stat [] [] -e, --event event selector. use 'perf list' to list available events Perf tool assumes the event names are either in lower or upper case. This is also mentioned in Documentation/ABI/testing/sysfs-bus-event_source-devices-events "As performance monitoring event names are case insensitive in the perf tool, the perf tool only looks for lower or upper case event names in sysfs to avoid scanning the directory. It is therefore required the name of the event here is either lower or upper case." Change the Group #1 events names to lower case. Signed-off-by: Ilkka Koskinen --- drivers/perf/dwc_pcie_pmu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c index 59526a48499f..126d2c3516ad 100644 --- a/drivers/perf/dwc_pcie_pmu.c +++ b/drivers/perf/dwc_pcie_pmu.c @@ -202,10 +202,10 @@ static struct attribute *dwc_pcie_pmu_time_event_attrs[] = { DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(L1_AUX, 0x09), /* Group #1 */ - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(Tx_PCIe_TLP_Data_Payload, 0x20), - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(Rx_PCIe_TLP_Data_Payload, 0x21), - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(Tx_CCIX_TLP_Data_Payload, 0x22), - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(Rx_CCIX_TLP_Data_Payload, 0x23), + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(tx_pcie_tlp_data_payload, 0x20), + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(rx_pcie_tlp_data_payload, 0x21), + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(tx_ccix_tlp_data_payload, 0x22), + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(rx_ccix_tlp_data_payload, 0x23), /* * Leave it to the user to specify the lane ID to avoid generating