From patchwork Fri Oct 18 20:34:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13842388 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A3C1D3F29B for ; Fri, 18 Oct 2024 20:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8KNF3aZ80xlLK3q7tI6wiBMuQSM/G62kGRgo4sUnlVk=; b=PbmUn/5oMl/Y5y58oPs8V+JYNa yuizLMhWdcM+Tv3MqHnxU0lo2cTZoimO0NKpHX06AftW5thtlDucB1IVSzfjf33c2XpGkGGp2YoxQ 3GaOYuD2/mVidODiQzeltJbWC5Z3/xR9SyA2fqDrWAvHCpVmUciTyPhrGTuUF34t5HiefBalf8xdu X0ahuAFMQAXOMtxM2J3NHhUYPU32X7R2xiAIjSURdeo5Re8Kq2osK1Wkh8PE7TYfPS02dVqQA3/SP hxvwZFE31EQ8HkeQ1e/WVTy3sz5xH5ymBxMciVLDSJtndayTGml01LudE+Xf4axCT39K3GhrisAGn T6U8hFQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1tvz-0000000212u-3S8B; Fri, 18 Oct 2024 20:50:55 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1tgJ-00000001xh5-2xn5 for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 20:34:46 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-539fb49c64aso3755190e87.0 for ; Fri, 18 Oct 2024 13:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729283681; x=1729888481; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8KNF3aZ80xlLK3q7tI6wiBMuQSM/G62kGRgo4sUnlVk=; b=lG/RLpnijN651V+uqzFWmFpEQUM4NIuJxfbzvWpYrREp7G067oQYiF60NuflNbtRYg Svcu6oZ3CHZMnL1OA0jqRtmKOSad40kRD1W13VKtinM1O3Gf/ovf0mNdd2FJq95Muh6Y Xbik9W+IxW4dgitN70a8O01Dkgd1b1k2hqTphFttuC1wANm5EMIZdG4G3+qp+piQZFUS jCK5GiAaiB90W5/I56SKB372kJrLjF6uqmKvVETsmVfIcG/BhgXX7L+vzT2asmLtfsQ5 JaC8G0ixiPOyb2j9VmmX26OowM0QRCfWbi42aQvfBLxUNWsZIzgaxLcFly3m1OR7oKZ5 4/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729283681; x=1729888481; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KNF3aZ80xlLK3q7tI6wiBMuQSM/G62kGRgo4sUnlVk=; b=B2VVxuYWQE0pnbOVXJ/X0Bxa8hZtLco4ACeZlgtFyHnVXEFIKuqbfmg9NPtvcI04RG X8phJwbhQt5XZTwxL6W6pzvO0CEI6FKdtYwVedHJY4F956b81e9J8QOEtRn6BTkLgSyT 2EQzSaqVjN/NUMx/Eh/QNivvbt3I5ENJ+B0uG0EliY94QytkHJ0DlDvsSoUTM6uL5Vj4 Y5S4JesvdPAhjXKvjOiieLD8fjXtOzMjT6hTkijZnspLgqNNg9nwR0HNuWDyHDMTSGec wq7aGbFGixoHhDC+Iya2zuLOcLRvSdRl4reviaxr6ZLo0m00XZrUhBlo5XOV9Rq9mF+r 3fVA== X-Forwarded-Encrypted: i=1; AJvYcCUIQ8nY2U3dZ3TTuov6JZEzKHoxttdNniFO+2o2ivbX9+H4H8Vstbfl0VZxkIchaPc12apV9LEg9ZlEpUn7DK+W@lists.infradead.org X-Gm-Message-State: AOJu0YxAWefsab/ffpIb/mb8YU+r0J5RgPnlAmsCnqH5XqBVRNVEIlqn DDyJ9OeQeVzn71OLBndHa3tosvp117jYNc9q4g/V4qgIeEFic4WLZGAHXWgZXHk= X-Google-Smtp-Source: AGHT+IGB98MZ4b+WRaD4A9VvwnCwxRN8d8/Fl30hE0Oq/p3vkPf3ZXCtCy1fbIicLKx9CCVIxFGzog== X-Received: by 2002:a05:6512:e98:b0:539:93b2:1380 with SMTP id 2adb3069b0e04-53a154d80a7mr3793237e87.48.1729283681263; Fri, 18 Oct 2024 13:34:41 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53a151f0e09sm314047e87.146.2024.10.18.13.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 13:34:40 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 18 Oct 2024 23:34:24 +0300 Subject: [PATCH 6/6] drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate MIME-Version: 1.0 Message-Id: <20241018-hdmi-mode-valid-v1-6-6e49ae4801f7@linaro.org> References: <20241018-hdmi-mode-valid-v1-0-6e49ae4801f7@linaro.org> In-Reply-To: <20241018-hdmi-mode-valid-v1-0-6e49ae4801f7@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Cana?= =?utf-8?q?l?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1944; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=62YpkgWLFOCHVyXEfwzdT8WXezDQplIIX6XUhdEmdrA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnEsZX9lakH8ExWkyFJBh3Vc/U3dgf2jd+BXIqJ 6Bk7kv5Vj+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZxLGVwAKCRCLPIo+Aiko 1S68B/0X7Ry1mckj6d7MJuKYGTrRuZOVLxsRWDxeWeqwBQoQpAxzeojZvPJev6Oxh31fNJfDHlv viIPEJeCikJpCIWZRjx18K0IkZgFjHF+4lPgja+L45P7s9www21/P9l8yxpZxaeY8tfp9Feeva1 w8zMRXKb2SIsoV5auELsD4HbL/zMAREVeDlAM+MAs/gM5SsfNbu0xS82tMU2PvLaWr23nj+XDiN M4NgU0NZh7rhHdbrRlo9A18C9fmxpbOkQCz/+cPA/upYzQy4eY6ZKOT9ZTAWLc6fVO78/I18bp1 5I4arn059C+4n+6SO3O3HL370p623RGL7qCqpFj6x7vdg7A9 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_133443_965324_83D6FC4B X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace .mode_valid() callback with .hdmi_tmds_char_rate_valid(). It is more generic and is used in other mode validation paths. The rate validation for .mode_valid() will be performed by the drm_bridge_connector code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index 181c5164b231..c686671e4850 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -442,16 +442,14 @@ dw_hdmi_qp_bridge_edid_read(struct drm_bridge *bridge, } static enum drm_mode_status -dw_hdmi_qp_bridge_mode_valid(struct drm_bridge *bridge, - const struct drm_display_info *info, - const struct drm_display_mode *mode) +dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge, + const struct drm_display_mode *mode, + unsigned long long rate) { struct dw_hdmi_qp *hdmi = bridge->driver_private; - unsigned long long rate; - rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); if (rate > HDMI14_MAX_TMDSCLK) { - dev_dbg(hdmi->dev, "Unsupported mode clock: %d\n", mode->clock); + dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); return MODE_CLOCK_HIGH; } @@ -510,7 +508,7 @@ static const struct drm_bridge_funcs dw_hdmi_qp_bridge_funcs = { .atomic_disable = dw_hdmi_qp_bridge_atomic_disable, .detect = dw_hdmi_qp_bridge_detect, .edid_read = dw_hdmi_qp_bridge_edid_read, - .mode_valid = dw_hdmi_qp_bridge_mode_valid, + .hdmi_tmds_char_rate_valid = dw_hdmi_qp_bridge_tmds_char_rate_valid, .hdmi_clear_infoframe = dw_hdmi_qp_bridge_clear_infoframe, .hdmi_write_infoframe = dw_hdmi_qp_bridge_write_infoframe, };