From patchwork Tue Oct 22 09:27:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 13845470 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D40FBD1CDCB for ; Tue, 22 Oct 2024 09:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BYjhwaRAM/9WODFsKNNZt3fJCxRPDx5r/c40WTgRkjU=; b=c+0shq8XLQ3NM3kJJajyQ/CFDF Yg2wZkA1OJTx+aEnNApPlDr8ZHD3FoBLouklbNJ443wchcuNH/qyX+uFLA8aOb3eJUbfZu1EKm7xi ufHOc56bhz0V1WZD9NWPKu+3oRqqmnWcwublMcf7uBnWnKG/2TEkk7/+SW7dl7QVWb2qBP2xjhSV1 FWOXOubEPfZQF6lBegONsouHYxLhCMKI1/xjOvMeDOlQKfbBMXfGO+YAHCLCUht82bVSUpDlkSq8j y2yAM2BCDtzINmiRRZn03cmYpIwicP33KHfjCTBPePNRdWbsto9fU6+omKyCp3P2ujN8iQHmG+0sE fLJ85zVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3BcM-0000000ARkl-3BT5; Tue, 22 Oct 2024 09:55:58 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3BBP-0000000ALsj-175b for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 09:28:09 +0000 Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XXmy16TkNzpXBm; Tue, 22 Oct 2024 17:26:01 +0800 (CST) Received: from kwepemd200014.china.huawei.com (unknown [7.221.188.8]) by mail.maildlp.com (Postfix) with ESMTPS id 190E71402CA; Tue, 22 Oct 2024 17:27:59 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by kwepemd200014.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Tue, 22 Oct 2024 17:27:58 +0800 From: Yicong Yang To: , , , , , CC: , , , , , , , , Subject: [PATCH v3 5/5] arm64: pgtable: Warn unexpected pmdp_test_and_clear_young() Date: Tue, 22 Oct 2024 17:27:34 +0800 Message-ID: <20241022092734.59984-6-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20241022092734.59984-1-yangyicong@huawei.com> References: <20241022092734.59984-1-yangyicong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd200014.china.huawei.com (7.221.188.8) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_022807_626249_D15BCAA7 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Yicong Yang Young bit operation on PMD table entry is only supported if FEAT_HAFT enabled system widely. Add a warning for notifying the misbehaviour. Signed-off-by: Yicong Yang --- arch/arm64/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index e4712b969aba..bb0600a24016 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -1265,6 +1265,8 @@ static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, unsigned long address, pmd_t *pmdp) { + /* Operation applies to PMD table entry only if FEAT_HAFT is enabled */ + VM_WARN_ON(pmd_table(READ_ONCE(*pmdp)) && !system_support_haft()); return __ptep_test_and_clear_young(vma, address, (pte_t *)pmdp); } #endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG */