diff mbox series

arm64: dts: imx8mn-bsh-smm-s2/pro: add simple-framebuffer

Message ID 20241024102800.3481574-1-dario.binacchi@amarulasolutions.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mn-bsh-smm-s2/pro: add simple-framebuffer | expand

Commit Message

Dario Binacchi Oct. 24, 2024, 10:27 a.m. UTC 
Add a simple-framebuffer node for U-Boot to further fill and activate.

Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 .../freescale/imx8mn-bsh-smm-s2-display.dtsi  | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

Shawn Guo Nov. 1, 2024, 11:51 a.m. UTC | #1 
On Thu, Oct 24, 2024 at 12:27:56PM +0200, Dario Binacchi wrote:
> Add a simple-framebuffer node for U-Boot to further fill and activate.
> 
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>  .../freescale/imx8mn-bsh-smm-s2-display.dtsi  | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> index 7675583a6b67..3d670534a714 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> @@ -4,6 +4,34 @@
>   */
>  
>  / {
> +	chosen {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		framebuffer-panel0 {
> +			compatible = "simple-framebuffer";
> +			clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, /* lcdif */
> +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>,
> +				 <&clk IMX8MN_VIDEO_PLL1>,
> +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>, /* pgc_dispmix */
> +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> +				 <&clk IMX8MN_CLK_DISP_AXI>,
> +				 <&clk IMX8MN_CLK_DISP_APB>,
> +				 <&clk IMX8MN_SYS_PLL2_1000M>,
> +				 <&clk IMX8MN_SYS_PLL1_800M>,
> +				 <&clk IMX8MN_CLK_DSI_CORE>, /* mipi_disi */
> +				 <&clk IMX8MN_CLK_DSI_PHY_REF>;
> +

Unneeded newline.

I dropped it and applied the patch.

Shawn

> +			power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_LCDIF>,
> +					<&disp_blk_ctrl IMX8MN_DISPBLK_PD_MIPI_DSI>;
> +			dvdd-supply = <&reg_3v3_dvdd>;
> +			avdd-supply = <&reg_v3v3_avdd>;
> +			status = "disabled";
> +		};
> +	};
> +
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm1 0 700000 0>;	/* 700000 ns = 1337Hz */
> -- 
> 2.43.0
>
Shawn Guo Nov. 1, 2024, 12:01 p.m. UTC | #2 
On Fri, Nov 01, 2024 at 07:51:57PM +0800, Shawn Guo wrote:
> On Thu, Oct 24, 2024 at 12:27:56PM +0200, Dario Binacchi wrote:
> > Add a simple-framebuffer node for U-Boot to further fill and activate.
> > 
> > Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > 
> > ---
> > 
> >  .../freescale/imx8mn-bsh-smm-s2-display.dtsi  | 28 +++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > index 7675583a6b67..3d670534a714 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > @@ -4,6 +4,34 @@
> >   */
> >  
> >  / {
> > +	chosen {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		framebuffer-panel0 {
> > +			compatible = "simple-framebuffer";
> > +			clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, /* lcdif */
> > +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>,
> > +				 <&clk IMX8MN_VIDEO_PLL1>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>, /* pgc_dispmix */
> > +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI>,
> > +				 <&clk IMX8MN_CLK_DISP_APB>,
> > +				 <&clk IMX8MN_SYS_PLL2_1000M>,
> > +				 <&clk IMX8MN_SYS_PLL1_800M>,
> > +				 <&clk IMX8MN_CLK_DSI_CORE>, /* mipi_disi */
> > +				 <&clk IMX8MN_CLK_DSI_PHY_REF>;
> > +
> 
> Unneeded newline.
> 
> I dropped it and applied the patch.

I replied too quick.

arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #size-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #size-cells (1) differs from / (2)

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
index 7675583a6b67..3d670534a714 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
@@ -4,6 +4,34 @@ 
  */
 
 / {
+	chosen {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		framebuffer-panel0 {
+			compatible = "simple-framebuffer";
+			clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, /* lcdif */
+				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
+				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>,
+				 <&clk IMX8MN_VIDEO_PLL1>,
+				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>, /* pgc_dispmix */
+				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
+				 <&clk IMX8MN_CLK_DISP_AXI>,
+				 <&clk IMX8MN_CLK_DISP_APB>,
+				 <&clk IMX8MN_SYS_PLL2_1000M>,
+				 <&clk IMX8MN_SYS_PLL1_800M>,
+				 <&clk IMX8MN_CLK_DSI_CORE>, /* mipi_disi */
+				 <&clk IMX8MN_CLK_DSI_PHY_REF>;
+
+			power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_LCDIF>,
+					<&disp_blk_ctrl IMX8MN_DISPBLK_PD_MIPI_DSI>;
+			dvdd-supply = <&reg_3v3_dvdd>;
+			avdd-supply = <&reg_v3v3_avdd>;
+			status = "disabled";
+		};
+	};
+
 	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm1 0 700000 0>;	/* 700000 ns = 1337Hz */