| Message ID | 20241028134218.54727-1-lists@steffen.cc (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection | expand |
Hi, On 28/10/2024 15:42, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > > drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init. > zynqmp_dpsub_kms_init creates the connector and without it we don't > enable hotplug detection. > > Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge") > Cc: stable@vger.kernel.org > Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > --- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c > index bd1368df7870..311397cee5ca 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c > @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub) > if (ret) > return ret; > > - drm_kms_helper_poll_init(drm); > - > ret = zynqmp_dpsub_kms_init(dpsub); > if (ret < 0) > goto err_poll_fini; > > + drm_kms_helper_poll_init(drm); > + > /* Reset all components and register the DRM device. */ > drm_mode_config_reset(drm); > Thanks, will apply to drm-misc-next. Btw, don't send a fixed version with the same version number as the last one. Tools get confused... Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index bd1368df7870..311397cee5ca 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub) if (ret) return ret; - drm_kms_helper_poll_init(drm); - ret = zynqmp_dpsub_kms_init(dpsub); if (ret < 0) goto err_poll_fini; + drm_kms_helper_poll_init(drm); + /* Reset all components and register the DRM device. */ drm_mode_config_reset(drm);