| Message ID | 20241104190836.278117-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties | expand |
On Mon, 2024-11-04 at 13:08 -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/irqchip/irq-stm32mp-exti.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c > index 33e0cfdea654..cb83d6cc6113 100644 > --- a/drivers/irqchip/irq-stm32mp-exti.c > +++ b/drivers/irqchip/irq-stm32mp-exti.c > @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev) > if (ret) > return ret; > > - if (of_property_read_bool(np, "interrupts-extended")) > - host_data->dt_has_irqs_desc = true; > + host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended"); > > return 0; > } Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com> Thanks, Antonio
diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c index 33e0cfdea654..cb83d6cc6113 100644 --- a/drivers/irqchip/irq-stm32mp-exti.c +++ b/drivers/irqchip/irq-stm32mp-exti.c @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev) if (ret) return ret; - if (of_property_read_bool(np, "interrupts-extended")) - host_data->dt_has_irqs_desc = true; + host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended"); return 0; }
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/irqchip/irq-stm32mp-exti.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)